Your message dated Wed, 19 Apr 2006 07:02:10 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#344695: fixed in gftp 2.0.18-12
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: gftp
Version: 2.0.18-11
Severity: normal
Tags: patch

Some settings(append_transfers, view_program and network_timeout for
example) is not stored when gftp started on ja_JP locale.
Thus, those settings are reverted to the default value when start up the
gftp next time.

gftp writes a comment on each setting line in the config file.
However, if comment string is
1) includes no space(' '), and
2) length(bytes) of comment string is greater than 76
then needless '#' character will be appended after a comment line.
(In other words, needless '#' character will be placed on head of the
setting line.)

I have read the gftp's sources code, and I see this problem is
due to "write_comment" function in gftp-2.0.18/lib/config_file.c.
The code of text wrapping has small bug.
I have attached a patch to fix this problem.

regards,

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14-2-k7
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8)

Versions of packages gftp depends on:
ii  gftp-gtk                      2.0.18-11  X/GTK+ FTP client
ii  gftp-text                     2.0.18-11  colored FTP client using GLib

gftp recommends no packages.

-- no debconf information

diff -ru gftp-2.0.18.orig/lib/config_file.c gftp-2.0.18/lib/config_file.c
--- gftp-2.0.18.orig/lib/config_file.c	2005-12-25 04:30:16.000000000 +0900
+++ gftp-2.0.18/lib/config_file.c	2005-12-25 04:30:25.000000000 +0900
@@ -704,14 +704,14 @@
 	       endpos++);
 	}
       fwrite (pos, 1, endpos - pos, fd);
-      fwrite ("\n# ", 1, 3, fd);
+      fwrite ("\n", 1, 1, fd);
       if (*endpos == '\0')
 	{
 	  pos = endpos;
 	  break;
 	}
-      else
-	pos = endpos + 1;
+      pos = endpos + 1;
+      fwrite ("# ", 1, 2, fd);
     }
   if (strlen (pos) > 1)
     {


--- End Message ---
--- Begin Message ---
Source: gftp
Source-Version: 2.0.18-12

We believe that the bug you reported is fixed in the latest version of
gftp, which is due to be installed in the Debian FTP archive:

gftp-common_2.0.18-12_amd64.deb
  to pool/main/g/gftp/gftp-common_2.0.18-12_amd64.deb
gftp-gtk_2.0.18-12_amd64.deb
  to pool/main/g/gftp/gftp-gtk_2.0.18-12_amd64.deb
gftp-text_2.0.18-12_amd64.deb
  to pool/main/g/gftp/gftp-text_2.0.18-12_amd64.deb
gftp_2.0.18-12.diff.gz
  to pool/main/g/gftp/gftp_2.0.18-12.diff.gz
gftp_2.0.18-12.dsc
  to pool/main/g/gftp/gftp_2.0.18-12.dsc
gftp_2.0.18-12_all.deb
  to pool/main/g/gftp/gftp_2.0.18-12_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aurelien Jarno <[EMAIL PROTECTED]> (supplier of updated gftp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 19 Apr 2006 15:47:51 +0200
Source: gftp
Binary: gftp gftp-text gftp-common gftp-gtk
Architecture: source amd64 all
Version: 2.0.18-12
Distribution: unstable
Urgency: low
Maintainer: Aurelien Jarno <[EMAIL PROTECTED]>
Changed-By: Aurelien Jarno <[EMAIL PROTECTED]>
Description: 
 gftp       - X/GTK+ FTP client
 gftp-common - shared files for other gFTP packages
 gftp-gtk   - X/GTK+ FTP client
 gftp-text  - colored FTP client using GLib
Closes: 344695 362771
Changes: 
 gftp (2.0.18-12) unstable; urgency=low
 .
   * Update the translation from CVS (closes: bug#362771).
   * Fix the configuration file routines with japanese locales. Thanks to
     Morita Sho for the patch (closes: bug#344695).
Files: 
 7494e3d3aa32e0b3f55bf828b7667329 710 net optional gftp_2.0.18-12.dsc
 14d5fc1acc9fee602b9624ebfaf81563 981161 net optional gftp_2.0.18-12.diff.gz
 242e02da8f7c149b126c830ea78ff438 45080 net optional gftp_2.0.18-12_all.deb
 be7c84bb51fd71188e5b1c49c41c5d77 287108 net optional 
gftp-gtk_2.0.18-12_amd64.deb
 2cd6c02c6fd939591df0235efd425f07 129272 net optional 
gftp-text_2.0.18-12_amd64.deb
 0682e3d0ead0a54a845b00cb0a53c8dd 730660 net optional 
gftp-common_2.0.18-12_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFERkJgw3ao2vG823MRAnB4AJ9E8F2+KXEmDDU1DhmpbwXgbFDf0wCfdMH8
g0GEUF/VtDNgaRAZqO/9R+0=
=gyjN
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to