Your message dated Wed, 14 Aug 2019 07:33:00 +0000 with message-id <dc4cec25-42ff-dd96-19c0-c62d5c147...@thykier.net> and subject line Re: Bug#934405: debhelper: Please ignore binNMUs in get_source_date_epoch() function has caused the Debian Bug report #934405, regarding debhelper: Please ignore binNMUs in get_source_date_epoch() function to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 934405: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=934405 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: debhelper Version: 12.3 Severity: wishlist Dear debhelper maintainers, Our package qtbase5-dev (which is marked as Multi-Arch: same) was recently binNMUed, after which it started producing errors when trying to install it for different architectures (so it has become non-same actually). Please see bugs #934215 and #934265. diffoscope showed me the following diff for /usr/share/qt5/doc/global/template/images/Qt-logo.png: tIME { - # 7 Aug 2019 18:06:40 GMT + # 7 Aug 2019 17:59:06 GMT ... I figured out that these timestamps are coming from binNMU changelogs. For example, usr/share/doc/qtbase5-dev/changelog.Debian.i386.gz has: qtbase-opensource-src (5.11.3+dfsg1-2+b1) sid; urgency=low, binary-only=yes * Binary-only non-maintainer upload for i386; no source changes. * Rebuild with libdouble-conversion3. -- i386 Build Daemon (x86-grnet-01) <buildd_amd64-x86-grnet...@buildd.debian.org> Wed, 07 Aug 2019 17:59:06 +0000 The date in PNG metadata is changed by dh_strip_nondeterminism. Originally I wanted to submit a bug against that tool, but I noticed that it uses get_source_date_epoch() function from Debian::Debhelper::Dh_Lib module. I think it would be nice if that function ignored binNMU changelog entries. As a workaround, we will use the -X option of dh_strip_nondeterminism for now. -- Dmitry Shachnev
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---On Tue, 13 Aug 2019 14:53:03 +0300 Dmitry Shachnev <mity...@debian.org> wrote: > Hi all, > > On Mon, Aug 12, 2019 at 06:53:01PM +0200, Mattia Rizzolo wrote: > > On Mon, Aug 12, 2019 at 03:48:06PM +0000, Holger Levsen wrote: > > > > I think it would be nice if that function ignored binNMU changelog > > > > entries. > > > > > > nope, please dont. using changelog entries inconsistently is a recipe > > > for desaster. > > > > Same. > > > > My notes from IRC, so they can last longer: > > > > [09:08:42 PM] <nthykier> comments on #934405 is welcome > > [09:08:45 PM] -zwiebelbot- Debian#934405: debhelper: Please ignore binNMUs > > in get_source_date_epoch() function - https://bugs.debian.org/934405 > > [10:53:13 PM] <mapreri> nthykier: well, we used to do that in the past, i.e. > > using the previous changelog date. But we switched away because it was also > > causing problems: #843773 > > [10:53:18 PM] -zwiebelbot- Debian#843773: sbuild should use build date as > > binnmu changelog date - https://bugs.debian.org/843773 > > [10:53:45 PM] <mapreri> nthykier: I fear that having debhelper's > > get_source_date_epoch() do that, would still lead to the same situation it > > was in the past, leading to that same bug once again, just via a different > > route. > > OK, fair enough — using the previous changelog entry has its downsides. > > For now I have just disabled normalizing PNGs in qtbase-opensource-src. > > Feel free to close this bug as wontfix. > > > [10:55:06 PM] <mapreri> If I have to express my opinion on this matter, > > it's a clear case on why keeping the timestamps within file metadata of > > generated files is mostly a horrible idea and should be removed, instead of > > normalized. > > +1. > > -- > Dmitry Shachnev Sorry, I missed there had been replies already. Closing the bug as it has already been resolved. Thanks, ~Niels
--- End Message ---
