Your message dated Wed, 14 Aug 2019 19:35:00 +0000
with message-id <b5a2506a-7ec1-a6e7-3630-e18000c5c...@thykier.net>
and subject line Re: debhelper: Dependency added by dh_installdocs --link-doc
breaks binary-only NMUs
has caused the Debian Bug report #766711,
regarding debhelper: dh_installdocs --link-doc silently breaks package
binNMUability
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
766711: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=766711
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: debhelper
Version: 9.20160115
Severity: important
Tags: patch
As predicted in the discussion in #747141, the current implementation for
the link-doc option, in compat +< 9, only causes warnings that no one notices
and results in warnings in build logs that no one will read and broken
packages as described in #811433.
As discussed on IRC, I think that the current behavior is just broken and
needn't wait for a compat bump. With the attached patch broken packages will
FTBFS when the arch all packages are built. I think this is a reasonable way
to do it since it is the arch all package with the wrong depends.
I did test this and it failed in the arch all -> any case and does not fail
for arch any -> arch any.
Scott K
diff -Nru debhelper-9.20160115/debian/changelog debhelper-9.20160116/debian/changelog
--- debhelper-9.20160115/debian/changelog 2016-01-15 20:28:44.000000000 +0000
+++ debhelper-9.20160116/debian/changelog 2016-01-19 12:35:22.000000000 +0000
@@ -1,3 +1,13 @@
+debhelper (9.20160116) UNRELEASED; urgency=medium
+
+ * Change dh_installdocs --link-doc functionality, regardless of compate, so
+ an error is generated when there is an architecture mismatch between the
+ two packages in order to preclude misuse of --link-doc breaking
+ binNMUability of packages (See #811433 for an example of the behavior this
+ change prevents)
+
+ -- Scott Kitterman <sc...@kitterman.com> Tue, 19 Jan 2016 12:30:19 +0000
+
debhelper (9.20160115) unstable; urgency=medium
* Fix brown paper bag bug that caused many packages to
diff -Nru debhelper-9.20160115/dh_installdocs debhelper-9.20160116/dh_installdocs
--- debhelper-9.20160115/dh_installdocs 2016-01-14 19:49:48.000000000 +0000
+++ debhelper-9.20160116/dh_installdocs 2016-01-19 12:37:12.000000000 +0000
@@ -178,11 +178,7 @@
getpackages('both') unless $called_getpackages++;
if (package_arch($package) ne package_arch($dh{LINK_DOC})) {
- if (compat(9)) {
- warning("WARNING: --link-doc between architecture all and not all packages breaks binNMUs");
- } else {
- error("--link-doc not allowed between ${package} and $dh{LINK_DOC} (one is arch:all and the other not)");
- }
+ error("--link-doc not allowed between ${package} and $dh{LINK_DOC} (one is arch:all and the other not)");
}
# Make sure that the parent directory exists.
if (! -d "$tmp/usr/share/doc" && ! -l "$tmp/usr/share/doc") {
--- End Message ---
--- Begin Message ---
On Sat, 25 Oct 2014 09:10:15 +0200 Robert Luberda <rob...@debian.org> wrote:
> Package: debhelper
> Version: 9.20141022
> Severity: serious
> Justification: Policy 12.3
>
> afterstep package after recent binary-only NMU is no longer installable,
> because dh_installdocs has added the following strict dependency on
> arch-independent package:
> afterstep-data (=2.2.12-2+b2)
>
> See this log:
> https://buildd.debian.org/status/fetch.php?pkg=afterstep&arch=i386&ver=2.2.12-2%2Bb2&stamp=1413508373
> and compare it with the log of previous binary-only NMU from last year:
> https://buildd.debian.org/status/fetch.php?pkg=afterstep&arch=i386&ver=2.2.12-2%2Bb1&stamp=1387741360
>
>
> The policy in section 12.3 and footnote 116 refers to source versions,
> not binary versions:
> /usr/share/doc/package may be a symbolic link to another directory in
> /usr/share/doc only if the two packages both come from the same source
> and the first package Depends on the second.[116]
>
> [116] Please note that this does not override the section on changelog files
> below, so the file /usr/share/doc/package/changelog.Debian.gz must refer
> to the changelog for the current version of package in question. In
> practice, this means that the sources of the target and the destination
> of the symlink must be the same (same source package and version).
>
>
> Regards,
> robert
>
>
> [...]
Hi,
I am taking the liberty of closing this wontfix bug in debhelper, which
has not seen any updates since 2017. Note I am leaving the related
policy bug #767839 open.
My remarks from 2018 (#767839 comment 43) are still relevant for any one
considering to work on supporting --link-doc in more cases.
Thanks,
~Niels
--- End Message ---
