Your message dated Wed, 04 Sep 2019 14:12:57 +0000
with message-id <[email protected]>
and subject line Bug#939222: fixed in gcab 1.2-4
has caused the Debian Bug report #939222,
regarding libgcab-dev: missing dependency on libglib2.0-dev
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
939222: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=939222
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libgcab-dev
Version: 1.2-3
Severity: important
Tags: patch
Without libglib2.0-dev installed, invoking
`pkg-config --cflags --libs libgcab-1.0` will fail. See attached patch
0001 for the obvious fix.
Please consider adding a superficial autopkgtest: this is easy to do
for -dev packages, and proves that the development library can be used
successfully. See attached patch 0002. I've been adding these to GNOME
team libraries, and started writing one for gcab before I realised it
wasn't a GNOME-team-maintained library :-)
(A more involved autopkgtest using gcab-self-test requires upstream
changes, which I'll propose separately.)
smcv
>From 51c955c128c969c3f9245a71ce466933a5a0734f Mon Sep 17 00:00:00 2001
From: Simon McVittie <[email protected]>
Date: Mon, 2 Sep 2019 09:54:13 +0100
Subject: [PATCH 1/3] libgcab-dev: Add missing dependency on libglib2.0-dev
Without libglib2.0-dev installed, invoking
`pkg-config --cflags --libs libgcab-1.0` will fail.
---
debian/control | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/control b/debian/control
index 78f7daa..eb012c9 100644
--- a/debian/control
+++ b/debian/control
@@ -47,6 +47,7 @@ Multi-Arch: same
Section: libdevel
Depends: gir1.2-gcab-1.0 (= ${binary:Version}),
libgcab-1.0-0 (= ${binary:Version}),
+ libglib2.0-dev,
${misc:Depends}
Suggests: libgcab-doc
Description: Microsoft Cabinet file manipulation library - development files
--
2.23.0
>From 652c561e45a7bf9fd51c58d718d962e5e19f5976 Mon Sep 17 00:00:00 2001
From: Simon McVittie <[email protected]>
Date: Mon, 2 Sep 2019 09:04:27 +0100
Subject: [PATCH 2/3] Add a superficial autopkgtest for libgcab-dev
This checks that the -dev package is usable, and in particular detected
the missing dependency fixed by the previous commit.
---
debian/tests/control | 5 +++++
debian/tests/libgcab-dev | 30 ++++++++++++++++++++++++++++++
2 files changed, 35 insertions(+)
create mode 100644 debian/tests/control
create mode 100755 debian/tests/libgcab-dev
diff --git a/debian/tests/control b/debian/tests/control
new file mode 100644
index 0000000..93d2696
--- /dev/null
+++ b/debian/tests/control
@@ -0,0 +1,5 @@
+Tests: libgcab-dev
+Depends: build-essential,
+ libgcab-dev,
+ pkg-config,
+Restrictions: allow-stderr superficial
diff --git a/debian/tests/libgcab-dev b/debian/tests/libgcab-dev
new file mode 100755
index 0000000..93b2a68
--- /dev/null
+++ b/debian/tests/libgcab-dev
@@ -0,0 +1,30 @@
+#!/bin/sh
+# autopkgtest check: Build and run a program against gcab, to verify that the
+# headers and pkg-config file are installed correctly
+# (C) 2012 Canonical Ltd.
+# (C) 2018-2019 Simon McVittie
+# Authors: Martin Pitt, Simon McVittie
+
+set -eux
+
+WORKDIR="$(mktemp -d)"
+export XDG_RUNTIME_DIR="$WORKDIR"
+trap 'rm -rf "$WORKDIR"' 0 INT QUIT ABRT PIPE TERM
+cd "$WORKDIR"
+cat <<EOF > test.c
+#include <libgcab.h>
+
+int main(void)
+{
+ g_assert_cmpuint (GCAB_TYPE_FILE, !=, G_TYPE_INVALID);
+ return 0;
+}
+EOF
+
+# Deliberately word-splitting pkg-config's output:
+# shellcheck disable=SC2046
+gcc -o gcab-test test.c $(pkg-config --cflags --libs libgcab-1.0)
+echo "build: OK"
+[ -x gcab-test ]
+./gcab-test
+echo "run: OK"
--
2.23.0
--- End Message ---
--- Begin Message ---
Source: gcab
Source-Version: 1.2-4
We believe that the bug you reported is fixed in the latest version of
gcab, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Stephen Kitt <[email protected]> (supplier of updated gcab package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 03 Sep 2019 13:43:30 +0200
Source: gcab
Binary: gcab gcab-dbgsym gir1.2-gcab-1.0 libgcab-1.0-0 libgcab-1.0-0-dbgsym
libgcab-dev libgcab-doc libgcab-tests libgcab-tests-dbgsym
Architecture: source amd64 all
Version: 1.2-4
Distribution: unstable
Urgency: medium
Maintainer: Stephen Kitt <[email protected]>
Changed-By: Stephen Kitt <[email protected]>
Description:
gcab - Microsoft Cabinet file manipulation tool
gir1.2-gcab-1.0 - Microsoft Cabinet file manipulation library - gir bindings
libgcab-1.0-0 - Microsoft Cabinet file manipulation library
libgcab-dev - Microsoft Cabinet file manipulation library - development files
libgcab-doc - Microsoft Cabinet file manipulation library - documentation
libgcab-tests - Microsoft Cabinet file manipulation library - as-installed
tests
Closes: 939222 939223
Changes:
gcab (1.2-4) unstable; urgency=medium
.
* Register the documentation through /usr/share/doc/libgcab-doc rather
than /usr/share/gtk-doc, as required by doc-base.
* Switch to debhelper compatibility level 12.
* Make libgcab-dev depend on libglib2.0-dev; thanks to Simon McVittie
for the report and patch! Closes: #939222.
* Add autopkgtests, a superficial one building and linking a simple test
program, and a more thorough one using the upstream "as-installed"
tests, shipped in the new libgcab-tests package. Thanks to Simon
McVittie for both of these! Closes: #939223.
* Standards-Version 4.4.0, no further change required.
Checksums-Sha1:
d66d95ac2b467c2b1974419ef0ef0ebb6d71a3c2 2261 gcab_1.2-4.dsc
8f622030e503a8bdd76ca9af3c58b7c9226a0c77 8920 gcab_1.2-4.debian.tar.xz
0979af19fabbd5e574dc802ac546e8e1d6afa58b 17700 gcab-dbgsym_1.2-4_amd64.deb
5adfa97f721d936dbf81af062b57a1049bfaea77 11277 gcab_1.2-4_amd64.buildinfo
dd1a5bb0239e402c46081ce728179532fdf3918b 32100 gcab_1.2-4_amd64.deb
245dfe147de80c1519de7fa4a030c1dc251069d1 6156 gir1.2-gcab-1.0_1.2-4_amd64.deb
67b59e3735edabf334f7af3a81850740ef7a4b6f 83856
libgcab-1.0-0-dbgsym_1.2-4_amd64.deb
012344e475b86073c64208c4643d13d3227c7317 30788 libgcab-1.0-0_1.2-4_amd64.deb
b6d21f13479148ff13fef1a3711f3512cc5467ec 11236 libgcab-dev_1.2-4_amd64.deb
fcaf012d42568c727470ad91b0a9bd4c11b3b4f7 17812 libgcab-doc_1.2-4_all.deb
6c5d9ae35769aa97e545310a9a62fff2c4f3d8c3 32748
libgcab-tests-dbgsym_1.2-4_amd64.deb
a84955f512bd7d604a3063480e686d06bcb2c78c 23416 libgcab-tests_1.2-4_amd64.deb
Checksums-Sha256:
fcd6aa411eb3d5edb836072e78c82763e318686a0c927f39f538111257647516 2261
gcab_1.2-4.dsc
c2254021cba582f5a23ae7fd46421a3df5c85a609f009cd50c6668aaf6c28c6c 8920
gcab_1.2-4.debian.tar.xz
1f79082f0381ce60aa36fbb99fc3df77ba0538d8d8d51fad23d84a8d6dbd57ef 17700
gcab-dbgsym_1.2-4_amd64.deb
f648ef143c32143766a5fe4eba7b01593a67a643ed3abd670ae690c7c19bcd91 11277
gcab_1.2-4_amd64.buildinfo
702fae8b5ae3dd63b72afad014bfb9e781eb6e0c6df4d2122bf8acac2863b9c4 32100
gcab_1.2-4_amd64.deb
788a3fd402df9bcdac08aca879e017a2772e263f1e796552928b7bbe2365fa37 6156
gir1.2-gcab-1.0_1.2-4_amd64.deb
f5f90c0ffd5bb2e9002e5e6fd246d858eeb74db5943ea0215e4f502362e041de 83856
libgcab-1.0-0-dbgsym_1.2-4_amd64.deb
486fd2fecdcf3bfbc808254edbc025ed9d23c41c3d5176f852a5af9bbd875e22 30788
libgcab-1.0-0_1.2-4_amd64.deb
3b18a82329a63473296339ca94702baab4403e1f95bd340f198b7ecadb17450b 11236
libgcab-dev_1.2-4_amd64.deb
2a69cee34001ac37e9a6c5e589f262804a7dde9ef43163aa416a9d52006f6dc7 17812
libgcab-doc_1.2-4_all.deb
de4cc3f67bb992c74e64f9902130416f542738d1589b84ec3d2e8ff5f2b01a97 32748
libgcab-tests-dbgsym_1.2-4_amd64.deb
9deb633b532c5f045a0ccccceec2f32fe7bf66135fd711a62aa25a11dafeb25c 23416
libgcab-tests_1.2-4_amd64.deb
Files:
a0b163dc8c55d9f1c24f8671effa9c43 2261 utils optional gcab_1.2-4.dsc
a214b2ee69641d0b6241befc7bf89a41 8920 utils optional gcab_1.2-4.debian.tar.xz
bb19006992f4c8a0ba4b55382777f079 17700 debug optional
gcab-dbgsym_1.2-4_amd64.deb
5580d3a770bfc1e22b6c43b52d405a68 11277 utils optional
gcab_1.2-4_amd64.buildinfo
dc8752b57a9a01a44c4396272d663ed0 32100 utils optional gcab_1.2-4_amd64.deb
3a8b82f2f4b7351cda7771cd2612efab 6156 introspection optional
gir1.2-gcab-1.0_1.2-4_amd64.deb
cbc55b60ef24462a64e03a2b72bd510a 83856 debug optional
libgcab-1.0-0-dbgsym_1.2-4_amd64.deb
d50bdedc9f9d4e0a125e500bfce18b89 30788 libs optional
libgcab-1.0-0_1.2-4_amd64.deb
6b473772b9ddb34d623c35f4d20ae0f9 11236 libdevel optional
libgcab-dev_1.2-4_amd64.deb
d09779dcdefb70ebf85f1cfe3aa22003 17812 doc optional libgcab-doc_1.2-4_all.deb
8d76c0b4f6829b9e6659a1ffbc6d72e5 32748 debug optional
libgcab-tests-dbgsym_1.2-4_amd64.deb
729ae08a125ea2c9703bf7df05796eaa 23416 misc optional
libgcab-tests_1.2-4_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAl1uUk0ACgkQgNMC9Yht
g5y7Gw//ee2g3lYjvFKHSMy6aSjNuerW1n75m0OGuhJUh49mqI3SBf/I6RyulWrI
PHTF0o0dOQp7+QrnwTeWDciIfbw0Mww6+KkupngivzfAlw6DMFEwmOPAxuuO7BeY
Me+/vV+8sg2ZG6KS5ZE8zmf+8GemtTJP4FfFfugRNJyBu9v/hS/Ijq2AzQ8Ja/kx
WvM8De/uKlEw/joKmrXgAgtOTLa/GvjQOCLmqTbrfk8Efpc4Yx6POJcUy9Bho5Cs
TeEK9xjQhjTKmaS4NwEeJA+hxrZZdiJPcmD75Xn0KGG6j/VtFzo0m5TisutDB3Ie
jCSqIzBsIO97Oe/uyd2eXm5XYIM01M+nEdFaslYl//QhNx59oUKokhFd4Wpo+ZYH
mytyNtZs7nwAswXg0rGQIlyHEBW75fXTnFQqKH4AC7H9WmyKR3UGaspFIFD315mb
ux9w6NS36ANS2HZARJRWFpgMGx0g+tTov+hk2xT57jV9YL1GnK/XxL/cSnwE3M3n
BsK7+M+QDVsdM/oQz92RQ9+7s4gWpLBkkDke6pBWtZu8Bbdk9oVQaKEiSYKwEI0I
LRgMJaeBilvSf79n4871sWa36J6Ym4/8v8MbP5Xz2Na9DnT4bMhGtuuNKw59TJpt
OYPYMbwlA98KiQcwUW1DmFzcHztTXEDgrRNASDaaUsk72/q6vnk=
=RaBs
-----END PGP SIGNATURE-----
--- End Message ---
