Your message dated Fri, 06 Sep 2019 08:35:48 +0000
with message-id <[email protected]>
and subject line Bug#939523: fixed in iraf-fitsutil 2018.07.06-4
has caused the Debian Bug report #939523,
regarding iraf-fitsutil: autopkgtest fail with glibc 2.29 due to missing
tm_isdst initialization
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
939523: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=939523
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: iraf-fitsutil
Version: 2018.07.06-3
Severity: normal
Tags: patch upstream
As discussed in bug#939048, the autopkgtest from iraf-fitsutil fail in a
strange way when run with glibc 2.29 instead of glibc 2.28:
| cl> fitsutil
| This is the initial release of the IRAF FITSUTIL package
| to include support for FITS tile compression via 'fpack'.
| Please send comments and questions to [email protected].
|
| cl> copy dev$pix.pix pix.pix
| cl> copy dev$pix.imh pix.imh
| cl> fgwrite "pix.pix pix.imh" pix.fits verb-
| cl> mkdir out
| cl> cd out
| cl> fgread ../pix.fits "" "" verb-
| cl> sum32 *
| ERROR: No write permission on file (String_File)
| "directory (img, long+) | scan (junk, junk, filsiz)"
| line 42: fitsutil$src/sum32.cl
| called as: `sum32 (input=*)'
| called as: `cl ()'
| "clbye()"
| line 41: fitsutil$fitsutil.cl
| called as: `fitsutil ()'
| called as: `cl ()'
| Error while reading login.cl file - may need to rebuild with mkiraf
| Fatal startup error. CL dies.
This happens because the error checking in mktime() have been improved
in case a non-valid date is provided in the tm struct. More precisely
in fgread.c, it should be noted that strptime does NOT setup the
tm_isdst of tm struct, which is instead getting a random value from the
stack. For this field 0 means no DST, positive value means DST and
negative values means that the value should be computed by mktime().
In the iraf-fitsutil, tm_isdst is not known from the file so it should
be set to -1, just like it's done in the POSIX.1-2018 strptime example:
https://pubs.opengroup.org/onlinepubs/9699919799/
Therefore the following patch fixes the issue:
--- iraf-fitsutil-2018.07.06.orig/src/fgread.c
+++ iraf-fitsutil-2018.07.06/src/fgread.c
@@ -469,6 +469,9 @@ char *type; /* Extension type */
s = kwdb_GetValue (kwdb, "FG_MTIME");
+ /* Not set by strptime(); tells mktime() to determine whether daylight
+ * saving time is in effect */
+ tm.tm_isdst = -1;
strptime (s, "%Y-%m-%dT%T",&tm);
fh->mtime = mktime(&tm) - get_timezone();
-- System Information:
Debian Release: bullseye/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
--- End Message ---
--- Begin Message ---
Source: iraf-fitsutil
Source-Version: 2018.07.06-4
We believe that the bug you reported is fixed in the latest version of
iraf-fitsutil, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Ole Streicher <[email protected]> (supplier of updated iraf-fitsutil package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 06 Sep 2019 09:27:30 +0200
Source: iraf-fitsutil
Architecture: source
Version: 2018.07.06-4
Distribution: unstable
Urgency: low
Maintainer: Debian Astro Team <[email protected]>
Changed-By: Ole Streicher <[email protected]>
Closes: 939523
Changes:
iraf-fitsutil (2018.07.06-4) unstable; urgency=low
.
* Add gitlab-ci.yml for salsa
* Push Standardss-Version to 4.4.0. No changes needed.
* Push compat to 12. Remove d/compat
* Add missing tm_isdst initialization (Closes: #939523)
Checksums-Sha1:
763debd61cd2dd57b553f9e4d0ed46a5a60ca14d 2005 iraf-fitsutil_2018.07.06-4.dsc
a9ee49385761e1bec4b9c2134d7490cc257be995 10000
iraf-fitsutil_2018.07.06-4.debian.tar.xz
Checksums-Sha256:
84f849930cc6046903756a769b56a11e5e5b9d9445d8a07996e656ffedc644ed 2005
iraf-fitsutil_2018.07.06-4.dsc
dcf278ff77331e3cbbd12dd7f65027acce4db34432ced5fcee1ea6f44efaa524 10000
iraf-fitsutil_2018.07.06-4.debian.tar.xz
Files:
cd874174d7910bc29516b4c78ccbb04f 2005 science optional
iraf-fitsutil_2018.07.06-4.dsc
24c009657ae72e36e4845e4a4e3e124d 10000 science optional
iraf-fitsutil_2018.07.06-4.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEuvxshffLFD/utvsVcRWv0HcQ3PcFAl1yF5QACgkQcRWv0HcQ
3PcIDRAAyuFAbhGCY8O1GrBeIQyIrrnjk+FO+dRwmXacOCSo+KHWHz07mVo0GKaO
tdTIr2qBvr+Zig5L1F3zLYaAskSgpnq4R8wdqf9B+Bza+Rp2MtaSnu5begpIVgLv
rubOMeO7hIxPBBZ4ETB+i5Oo1O2PHq6DRm8HjKc67JA0FiSfIqKOFf9v6//pvpRB
+09SZqG5M26Jt7dmFShWXFBxqbqzZOFnWH8uGuBZYCtSHeyfmdEUiwt8pcg9kWRN
8d97S27hNNYimZ/CL3VuJ5fshW8V8XQCHaYiwW5Q8LtL8JJK6X68/P0/ohh/gjfK
ijO2ChIXxcoq4cTTE++nlHmcJtUx05hAvHCpBu2fDikaFdv1xsYcbF7cHOkDgNd0
riUmRfS8ItTNbzWNMHr52rqR7X9yrw3eqCvtux9R6ftxtu0ZkO5SdHTx1oq4sQP+
I6RtGCCSvdPIFXXzAb+B/w7kiuWQbqvjpPSaLfvwH35o+qor86jqF2Q9zHnuAQw0
IFFlJXsxh38ZFxG4zXnGA26PU6sUcBMj4oZuR6oYl7XVm/AsWhoOUYMXGdLMWTZy
26ESNueAyOX5DVWlrLJRI0TLO+AR+chOrQO4BOtwL6MqLovm1woR56RCQ/9oUxVq
FFbPQnnHYRHaFchGqHHTyt3klkMEUwV2fJDdjFuzXy11Tf51+TA=
=HCEC
-----END PGP SIGNATURE-----
--- End Message ---
