Your message dated Wed, 11 Sep 2019 14:47:23 +0000
with message-id <e1i83tz-000dci...@fasolo.debian.org>
and subject line Bug#930944: fixed in pd-lua 0.7.3-3
has caused the Debian Bug report #930944,
regarding pd-lua FTCBFS: multiple reasons
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
930944: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930944
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: pd-lua
Version: 0.7.3-2
Tags: patch
User: debian-cr...@lists.debian.org
Usertags: ftcbfs

pd-lua fails to cross build from source, because debian/rules hard codes
the build architecture pkg-config. Letting dpkg's buildtools.mk supply
it fixes this part. Additionally make install strips with the wrong
strip. Beyond breaking cross compilation, this breaks
DEB_BUILD_OPTIONS=nostrip as well as generation of -dbgsym packages. You
simply shouldn't strip during make install. The attached patch fixes all
of that. Please consider applying it.

Helmut
diff --minimal -Nru pd-lua-0.7.3/debian/changelog pd-lua-0.7.3/debian/changelog
--- pd-lua-0.7.3/debian/changelog       2018-02-01 23:19:43.000000000 +0100
+++ pd-lua-0.7.3/debian/changelog       2019-06-23 09:27:16.000000000 +0200
@@ -1,3 +1,12 @@
+pd-lua (0.7.3-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Supply pkg-config from dpkg's buildtools.mk.
+    + Don't strip during make install.
+
+ -- Helmut Grohne <hel...@subdivi.de>  Sun, 23 Jun 2019 09:27:16 +0200
+
 pd-lua (0.7.3-2) unstable; urgency=medium
 
   * Switched buildsystem from dh to cdbs
diff --minimal -Nru pd-lua-0.7.3/debian/rules pd-lua-0.7.3/debian/rules
--- pd-lua-0.7.3/debian/rules   2018-02-01 23:19:43.000000000 +0100
+++ pd-lua-0.7.3/debian/rules   2019-06-23 09:27:16.000000000 +0200
@@ -14,9 +14,11 @@
     BUILD_DATE ?= $(shell date "+$(DATE_FMT)")
 endif
 
+-include /usr/share/dpkg/buildtools.mk
+PKG_CONFIG ?= pkg-config
 CPPFLAGS+=-DBUILD_DATE='\"$(BUILD_DATE)\"'
-CFLAGS+=$(shell pkg-config --cflags lua5.2 pd)
-LIBS+=$(shell   pkg-config --libs lua5.2 pd)
+CFLAGS+=$(shell $(PKG_CONFIG) --cflags lua5.2 pd)
+LIBS+=$(shell   $(PKG_CONFIG) --libs lua5.2 pd)
 
 LDFLAGS += -Wl,-as-needed
 
@@ -34,7 +36,7 @@
                $(empty)
 
 override_dh_auto_install:
-       dh_auto_install -- prefix=/usr pkglibdir=$(pkglibdir)
+       dh_auto_install -- prefix=/usr pkglibdir=$(pkglibdir) STRIP=true
 # fix permissions
        find $(CURDIR)/debian/*/$(pkglibdir) -name "*.pd_linux" -exec \
                chmod 0664 {} +

--- End Message ---
--- Begin Message ---
Source: pd-lua
Source-Version: 0.7.3-3

We believe that the bug you reported is fixed in the latest version of
pd-lua, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 930...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
IOhannes m zmölnig (Debian/GNU) <umlae...@debian.org> (supplier of updated 
pd-lua package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 11 Sep 2019 15:40:38 +0200
Source: pd-lua
Architecture: source
Version: 0.7.3-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multime...@lists.debian.org>
Changed-By: IOhannes m zmölnig (Debian/GNU) <umlae...@debian.org>
Closes: 930944
Changes:
 pd-lua (0.7.3-3) unstable; urgency=medium
 .
   [ Ondřej Nový ]
   * Use debhelper-compat instead of debian/compat
 .
   [ IOhannes m zmölnig ]
   * Fix FTCBFS
     + Supply pkg-config from dpkg's buildtools.mk
     + Don't strip during make install.
     Thanks to Helmut Grohne <hel...@subdivi.de> (Closes: #930944)
   * Declare that building this package doesn't require "root" powers
   * Remove obsolete d/source/local-options
   * Bump dh compat to 12
   * Bump standards version to 4.4.0
Checksums-Sha1:
 06efbf9b4ba84dc5d546140809411906078fc147 2154 pd-lua_0.7.3-3.dsc
 b129e23c812d95288d96ea6c2132b94473e4e5d3 4200 pd-lua_0.7.3-3.debian.tar.xz
Checksums-Sha256:
 c2be93c26a682889971b231e9efa685c8a4b9eca84acc4ac41bb9842c1014592 2154 
pd-lua_0.7.3-3.dsc
 eeb678e955184b8f9233de7b788af5adfb75ac4e4a49bf425ac7e8ba5e3747ea 4200 
pd-lua_0.7.3-3.debian.tar.xz
Files:
 53053fe9d1d0ebdc23be4b6dccb1c840 2154 sound optional pd-lua_0.7.3-3.dsc
 c34778673f6de7173ec5c79d99eb6ed2 4200 sound optional 
pd-lua_0.7.3-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJQBAEBCAA6FiEEdAXnRVdICXNIABVttlAZxH96NvgFAl14+wAcHGpvaGFubmVz
Lnptb2VsbmlnQGt1Zy5hYy5hdAAKCRC2UBnEf3o2+BptD/9KOCm+GRIJgLsHJmtj
/wsWdggnQyTZNj8TugUW5iHTNhEgOmk27l7q8CswtdtxXh4X54wCxkfVd/BpbBHB
aJqqHUdelwlwyub+HLHXg+QNchVPobCredd3kC+QLb9Ay1fq8sW8wJydd79Xyr7/
VDuXXkeUmIyZKEY9bMO4iIYXv9xBRyRdBjijq/cDz9Fk0TUPW0Ek3qQ8O+YKeRSv
Yi9nB5qzRGBIUyW8NMtMWf5kXegyeE/c9tw5LG8OPB+6H3QNFLszEq9F3tLYX5da
lchCvkptxf24Iwny37dosdSBrLaD8Ozz77FADBHPSBBO14SEkhfHGBamKFFoSRVa
PaS/dW0ZsX3vUJQmpg0++KfZBfQBwFn3TNtc06HIwHBjhAmodDZIKVvLHusd1PUO
HdqrpS32syAZje2VulYkvoJxV7LqDFsvRfG6TF6pv1kVPEx8LQ08XVB/bYEP/25g
JUAskS+SBUiqU1gOhaqDyNRmBR6HZzZV8ThhLiN5/atf7eIJwBVuuShf7e6Eic5s
OXu8l6SnO3oFGHAcZK4QtSgUICYyowDa8DO7DnFTgfs2jyYx7ASilkGEI1+PaLAN
MQmWSH0fvV36ezpStx4Fzc2/S1f8ac0vX9ifin2TMEUxDdgx0K1gGiusp0cmaoED
of50IDiShbvwcHasYICLkTBU0g==
=otSB
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to