Your message dated Fri, 13 Sep 2019 20:35:59 +0000
with message-id <[email protected]>
and subject line Bug#940001: fixed in autodep8 0.19
has caused the Debian Bug report #940001,
regarding Source: python-foo + Binary: python3-foo + Binary: python-foo-common
-> bad
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
940001: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=940001
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: autodep8
Version: 0.18
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu eoan ubuntu-patch
Dear maintainers,
In Ubuntu, I discovered when dropping python2 support from python-os-api-ref
that autodep8 has some bugginess in how it decides what versions of python
to run tests for. (The python-os-api-ref Debian maintainer also found this,
but handled it by adding manual tests; we have not synced the Debian
solution because it's a new upstream version of the package and we're in
feature freeze.)
Specifically, python-os-api-ref has the following setup:
Source: python-os-api-ref
Binary: python-os-api-ref-common
Binary: python3-os-api-ref
The correct module to test imports of is os_api_ref, of course, not
os_api_ref_common; and it should be tested only for python3.
The attached patch fixes this, and also adds a test case for this situation.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru autodep8-0.18/support/python/generate
autodep8-0.18ubuntu2/support/python/generate
--- autodep8-0.18/support/python/generate 2019-01-30 11:17:41.000000000
-0800
+++ autodep8-0.18ubuntu2/support/python/generate 2019-09-10
15:16:56.000000000 -0700
@@ -13,10 +13,12 @@
py3_package=python3-$module
fi
-source_package=$(grep-dctrl -n -s Source -F Source -r '^pypy-.*$'
debian/control || true)
-if [ -n "$source_package" ] ; then
- module=${source_package#pypy-}
- pypy_package=pypy-$module
+if [ -z "$module" ]; then
+ source_package=$(grep-dctrl -n -s Source -F Source -r '^pypy-.*$'
debian/control || true)
+ if [ -n "$source_package" ] ; then
+ module=${source_package#pypy-}
+ pypy_package=pypy-$module
+ fi
fi
# Try binary package(s)
@@ -39,7 +41,7 @@
fi
# Try binary package(s)
-if [ -z "$source_package" ] ; then
+if [ -z "$pypy_package" ]; then
binary_packages=$(grep-dctrl -n -s Package -F Package -r '^pypy-.*$'
debian/control || true)
if [ -n "$binary_packages" ] ; then
for binary_package in $binary_packages ; do
diff -Nru autodep8-0.18/test/python_test.sh
autodep8-0.18ubuntu2/test/python_test.sh
--- autodep8-0.18/test/python_test.sh 2019-01-30 11:17:41.000000000 -0800
+++ autodep8-0.18ubuntu2/test/python_test.sh 2019-09-10 15:16:41.000000000
-0700
@@ -85,6 +85,14 @@
assertTrue 'have pypy test' 'grep --quiet "pypy -c" stdout'
}
+test_python_ignore_py2_non_module() {
+ has 'debian/control' 'Source: python-foo\n\nPackage:
python-foo-common\n\nPackage: python3-foo'
+ check_run autodep8
+ assertTrue 'get upstream name' 'grep --quiet "import foo;" stdout'
+ assertFalse 'dont have py2 test' 'grep --quiet "pyversions" stdout'
+ assertTrue 'have py3 test' 'grep --quiet "py3versions" stdout'
+}
+
test_Testsuite_autopkgtest_pkg_python() {
has debian/control "Testsuite: autopkgtest-pkg-python"
check_run autodep8
--- End Message ---
--- Begin Message ---
Source: autodep8
Source-Version: 0.19
We believe that the bug you reported is fixed in the latest version of
autodep8, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Paul Gevers <[email protected]> (supplier of updated autodep8 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 13 Sep 2019 21:49:46 +0200
Source: autodep8
Architecture: source
Version: 0.19
Distribution: unstable
Urgency: medium
Maintainer: Debian CI team <[email protected]>
Changed-By: Paul Gevers <[email protected]>
Closes: 940001
Changes:
autodep8 (0.19) unstable; urgency=medium
.
[ Xavier Guimard ]
* perl support: use tags skippable and superficial
.
[ Antonio Terceiro ]
* Add gitlab-ci integration
* gitlab-ci: use stable-backports for stable
.
[ Xavier Guimard ]
* nodejs: add nodejs in "require" test to be able to test libjs-*
packages
.
[ Steve Langasek ]
* Fix situation for Python packages that drop Python 2 support but have
a python-* package (Closes: #940001)
Checksums-Sha1:
054dcb64c5f05d434df44e46ed4cb7dfe0d6f23a 1513 autodep8_0.19.dsc
20003bd0addd13ced0519a821400b87000b4cf23 11920 autodep8_0.19.tar.xz
Checksums-Sha256:
c58ef60ee2d59d66a7fefb8ae715544c94026efdee1a5dc4abc9f74eac82e52b 1513
autodep8_0.19.dsc
8cff1b18a82626d08e931a6383580dfabf034f79db79a08ed58e27e2e10d03b4 11920
autodep8_0.19.tar.xz
Files:
176307fe068489dbc5cb5c4e1f8e0ecc 1513 devel optional autodep8_0.19.dsc
d57b26b68959f650b95e64522b44a8c0 11920 devel optional autodep8_0.19.tar.xz
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEWLZtSHNr6TsFLeZynFyZ6wW9dQoFAl179PEACgkQnFyZ6wW9
dQrAxQf/fuzSCoc2sxkLBGzpqzVti5K0Wj1SyvIczE2NcRbqQ/woqQ6SdLyYOQnB
C2loXLwTRnoaFtkrcdR0Dl8FddzR3NiyMrpcyGrTk8oivGZZi3jRsOn2DmlfLImf
KNzsEpejTt9O05qoSPGIpLg+c2CKcUt1shegVAwNKB742k2aBbOvz6fEojf48eC0
J0G4+1qoCupm5Pkoln87VkXxVWekR5DgFDvXztxIIfXIhgNFUsn+niz2zHnH1vje
4yKO5lFw20WS0qml/a5AhJFvIfmNZf8u3cgOooICl0XwnzXTY+TLo5/20/SbmGX2
51qm/hOaZ8YX9Mj4+bqaeoM46cB0ng==
=59zl
-----END PGP SIGNATURE-----
--- End Message ---
