Your message dated Sat, 28 Sep 2019 06:15:35 +0000 (UTC)
with message-id <[email protected]>
and subject line Re: Bug#941196: ccls: please drop llvm hacks?
has caused the Debian Bug report #941196,
regarding ccls: please drop llvm hacks?
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
941196: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=941196
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: ccls
Version: 0.20190823-4
Severity: normal
tags: patch
hello, after having a deeper look on ccls (not so deep, apologizes if I made a
mistake), I discovered that upstream cmake file,
uses clang -print-resource-dir to find out the include location, and this seems
to be just working correctly
clang -print-resource-dir
/usr/lib/llvm-9/lib/clang/9.0.0
./obj-x86_64-linux-gnu/CMakeFiles/ccls.dir/build.make: /usr/bin/c++
$(CXX_DEFINES)
-DCLANG_RESOURCE_DIRECTORY="R\"(/usr/lib/llvm-9/lib/clang/9.0.0)\""
$(CXX_INCLUDES) $(CXX_FLAGS) -S /ccls-0.20190823/src/utils.cc -o
CMakeFiles/ccls.dir/src/utils.cc.s
so, why can't we just drop all that code?
Also, this:
CLANG_RESOURCE_DIR := /usr/include/clang/$(CLANG_VER)
CCLS_SUBSTVARS += -Vccls:Recommends=$(shell dpkg-query -S $(CLANG_RESOURCE_DIR)
| sed -e 's/: .*//')
Why recommend libclang-common-9-dev? can't you just use libclang-dev as runtime
dependency?
Do you want to be sure the same clang as the one used in build is picked up?
In this case I guess it is fine to do it, but since it is just a recommends...
a simpler way might be useful
thanks
Gianfranco
--- End Message ---
--- Begin Message ---
thanks, I'm closing it then!
G.
Il giovedì 26 settembre 2019, 10:54:44 CEST, Shengjing Zhu
<[email protected]> ha scritto:
> > Do you want to be sure the same clang as the one used in build is picked
> > up?
>
> No, just a package contains clang header files, whatever version.
>
Oh, the recommended package should contain the directory(clang
resource dir) that compiled into ccls binary.
--
Shengjing Zhu
--- End Message ---
