Your message dated Thu, 10 Oct 2019 20:33:54 +0530
with message-id <[email protected]>
and subject line Re: node-rollup: please make the build reproducible
has caused the Debian Bug report #891899,
regarding node-rollup: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
891899: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891899
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: node-rollup
Version: 0.50.0-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: timestamps
X-Debbugs-Cc: [email protected]
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed
that node-rollup could not be built reproducibly as it encodes
the current build time via "new Date()".
Patch attached.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
--- a/debian/patches/0001-reproducible-build.patch 1970-01-01
01:00:00.000000000 +0100
--- b/debian/patches/0001-reproducible-build.patch 2018-03-02
09:41:49.392154726 +0000
@@ -0,0 +1,19 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2018-03-02
+
+--- node-rollup-0.50.0.orig/rollup.config.js
++++ node-rollup-0.50.0/rollup.config.js
+@@ -14,9 +14,11 @@ const commitHash = (function() {
+ }
+ })();
+
++const now = new Date(process.env.SOURCE_DATE_EPOCH ?
(process.env.SOURCE_DATE_EPOCH * 1000) : new Date().getTime());
++
+ const banner = readFileSync('src/banner.js', 'utf-8')
+ .replace('${version}', pkg.version)
+- .replace('${time}', new Date())
++ .replace('${time}', now.toUTCString())
+ .replace('${commitHash}', commitHash);
+
+ export default [
--- a/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/series 2018-03-02 09:20:55.357126507 +0000
@@ -0,0 +1 @@
+0001-reproducible-build.patch
--- End Message ---
--- Begin Message ---
On Fri, 02 Mar 2018 09:48:49 +0000 Chris Lamb <[email protected]> wrote:
> Whilst working on the Reproducible Builds effort [0], we noticed
> that node-rollup could not be built reproducibly as it encodes
> the current build time via "new Date()".
>
> Patch attached.
This patch is now obsolete, we don't use rollup.config.js anymore and
build is now reproducible without this patch. Even if we were to use
rollup.config.js in a future version, we already have 0.68.2 (patch
merged upstream in 0.56.4) in experimental which will be uploaded to
unstable soon (unstable has 0.56.3).
--- End Message ---
