Your message dated Mon, 04 Nov 2019 15:35:28 +0000
with message-id <[email protected]>
and subject line Bug#943449: fixed in mu-editor 1.0.2+dfsg-4
has caused the Debian Bug report #943449,
regarding mu-editor: autopkgtest unnecessarily tests against non-default python
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
943449: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943449
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: mu-editor
Version: 1.0.2+dfsg-3
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu focal ubuntu-patch

Dear maintainers,

With the introduction of python3.8 as a "supported" python in Ubuntu, the
mu-editor autopkgtest is now failing, looks like it's because its
dependencies are not yet python3.8-enabled:

[...]
autopkgtest [17:52:34]: test mu-editor: [-----------------------
=== python3.8 ===
============================= test session starts ==============================
platform linux -- Python 3.8.0, pytest-4.6.5, py-1.8.0, pluggy-0.13.0 -- 
/usr/bin/python3.8
cachedir: .pytest_cache
Using --random-order-bucket=module
Using --random-order-seed=375701

rootdir: /tmp/autopkgtest.YC64py/autopkgtest_tmp
plugins: xvfb-1.2.0, random-order-1.0.4
collecting ... collected 301 items / 11 errors / 290 selected

==================================== ERRORS ====================================
______________________ ERROR collecting tests/test_app.py ______________________
ImportError while importing test module 
'/tmp/autopkgtest.YC64py/autopkgtest_tmp/tests/test_app.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_app.py:8: in <module>
    from mu.app import excepthook, run, setup_logging, debug, setup_modes
/usr/share/mu-editor/mu/app.py:34: in <module>
    from mu.interface import Window
/usr/share/mu-editor/mu/interface/__init__.py:1: in <module>
    from .main import Window
/usr/share/mu-editor/mu/interface/main.py:34: in <module>
    from mu.interface.panes import (DebugInspector, DebugInspectorItem,
/usr/share/mu-editor/mu/interface/panes.py:37: in <module>
    from qtconsole.rich_jupyter_widget import RichJupyterWidget
/usr/lib/python3/dist-packages/qtconsole/rich_jupyter_widget.py:14: in <module>
    from .jupyter_widget import JupyterWidget
/usr/lib/python3/dist-packages/qtconsole/jupyter_widget.py:24: in <module>
    from .frontend_widget import FrontendWidget
/usr/lib/python3/dist-packages/qtconsole/frontend_widget.py:22: in <module>
    from qtconsole.base_frontend_mixin import BaseFrontendMixin
/usr/lib/python3/dist-packages/qtconsole/base_frontend_mixin.py:3: in <module>
    from jupyter_client import BlockingKernelClient
/usr/lib/python3/dist-packages/jupyter_client/__init__.py:4: in <module>
    from .connect import *
/usr/lib/python3/dist-packages/jupyter_client/connect.py:23: in <module>
    import zmq
/usr/lib/python3/dist-packages/zmq/__init__.py:47: in <module>
    from zmq import backend
/usr/lib/python3/dist-packages/zmq/backend/__init__.py:40: in <module>
    reraise(*exc_info)
/usr/lib/python3/dist-packages/zmq/utils/sixcerpt.py:34: in reraise
    raise value
/usr/lib/python3/dist-packages/zmq/backend/__init__.py:27: in <module>
    _ns = select_backend(first)
/usr/lib/python3/dist-packages/zmq/backend/select.py:27: in select_backend
    mod = __import__(name, fromlist=public_api)
/usr/lib/python3/dist-packages/zmq/backend/cython/__init__.py:6: in <module>
    from . import (constants, error, message, context,
E   ImportError: cannot import name 'constants' from partially initialized 
module 'zmq.backend.cython' (most likely due to a circular import) 
(/usr/lib/python3/dist-packages/zmq/backend/cython/__init__.py)
[...]

  (http://autopkgtest.ubuntu.com/packages/m/mu-editor/focal/amd64)

I understand that it's useful to get early indications that your software is
incompatible with upcoming versions of python, but it's not appropriate to
use autopkgtests in this way, because mu-editor is an application not a
module and will only ever be executed using /usr/bin/python3 on the system -
you have added an artificial test dependency on python3-all and as a result
these failing tests will artificially block the addition of python3.8 as a
supported (but not default) python version in the archive.

The attached patch adjusts the test and the build-dependencies so that the
mu-editor tests instead test the actual behavior that is relevant to the
package.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
[email protected]                                     [email protected]
diff -Nru mu-editor-1.0.2+dfsg/debian/control 
mu-editor-1.0.2+dfsg/debian/control
--- mu-editor-1.0.2+dfsg/debian/control 2019-06-17 17:34:00.000000000 -0700
+++ mu-editor-1.0.2+dfsg/debian/control 2019-10-24 14:03:24.000000000 -0700
@@ -8,7 +8,7 @@
  dh-python,
  fonts-inconsolata,
  pandoc,
- python3-all (>= 3.6),
+ python3 (>= 3.6),
  python3-appdirs (>= 1.4.3),
  python3-matplotlib (>= 2.2.2),
  python3-mock,
diff -Nru mu-editor-1.0.2+dfsg/debian/tests/mu-editor 
mu-editor-1.0.2+dfsg/debian/tests/mu-editor
--- mu-editor-1.0.2+dfsg/debian/tests/mu-editor 2019-06-17 17:34:00.000000000 
-0700
+++ mu-editor-1.0.2+dfsg/debian/tests/mu-editor 2019-10-24 14:02:47.000000000 
-0700
@@ -7,12 +7,7 @@
 export HOME="$AUTOPKGTEST_TMP"
 export PYTHONPATH=/usr/share/mu-editor
 
-pythons="$(py3versions -s)"
-
 cp -a tests $AUTOPKGTEST_TMP
 cd "$AUTOPKGTEST_TMP"
 
-for py in $pythons; do
-    echo "=== $py ==="
-    xvfb-run -a $py -m pytest --random-order --tb=long --verbose
-done
+xvfb-run -a python3 -m pytest --random-order --tb=long --verbose

--- End Message ---
--- Begin Message ---
Source: mu-editor
Source-Version: 1.0.2+dfsg-4

We believe that the bug you reported is fixed in the latest version of
mu-editor, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nick Morrott <[email protected]> (supplier of updated mu-editor package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 04 Nov 2019 12:30:14 +0000
Source: mu-editor
Architecture: source
Version: 1.0.2+dfsg-4
Distribution: unstable
Urgency: medium
Maintainer: Python Applications Packaging Team 
<[email protected]>
Changed-By: Nick Morrott <[email protected]>
Closes: 943449
Changes:
 mu-editor (1.0.2+dfsg-4) unstable; urgency=medium
 .
   [ Ondřej Nový ]
   * Use debhelper-compat instead of debian/compat.
   * Bump Standards-Version to 4.4.1.
 .
   [ Nick Morrott ]
   * d/control:
     - Uploaders: use my new Debian address
     - Expand definition of "REPL" in long description
     - Mark mu-editor-doc as M-A: foreign
     - Add Rules-Requires-Root field
     - Depend on default python3 rather than python3-all
   * d/tests/mu-editor:
     - Run autopkgtests against default python3. Thanks to
       Steve Langasek for the patch (Closes: #943449)
   * d/patches:
     - add use-https-urls-in-appstream-data
Checksums-Sha1:
 d081d88462b52d5c1c8b78d728570f50e6551900 2679 mu-editor_1.0.2+dfsg-4.dsc
 10f7fcad71018bdac4bdfc37c755e8ed73302749 11508 
mu-editor_1.0.2+dfsg-4.debian.tar.xz
 29260cb7fb0d4e09d1d691df2dc5abce02bd6e5d 13409 
mu-editor_1.0.2+dfsg-4_amd64.buildinfo
Checksums-Sha256:
 d2eeb56f4334e2186075686ae42c302e67a14aac904d9e3c79318354eefddd0a 2679 
mu-editor_1.0.2+dfsg-4.dsc
 54b94eab0fc808772f4170450ea348dfcefbd0fe12b6cde31759629e47e46591 11508 
mu-editor_1.0.2+dfsg-4.debian.tar.xz
 41638e5b8bde9bcda7c5199a956d6ec9773d5bdbe4619edcba5f430b589d3500 13409 
mu-editor_1.0.2+dfsg-4_amd64.buildinfo
Files:
 f600d9b8a61e152d670c55667bee8459 2679 python optional 
mu-editor_1.0.2+dfsg-4.dsc
 1ddeec2f18352098ce725730089a10e1 11508 python optional 
mu-editor_1.0.2+dfsg-4.debian.tar.xz
 5a5df1f2d659a56517127b8c1c43f4d5 13409 python optional 
mu-editor_1.0.2+dfsg-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEIrPZe+nomMkP9lI7PptZrG7C01kFAl3AQIIACgkQPptZrG7C
01lmlg/+NJkLk0pIGWC7SwIp12QAzRsc3pwoh83vcDp7dbfswpxdOPVgT73PI6Zu
Muakh4lzrm5uJsN4aqNYTyMF7mIn65PmTBKfvacSUHvEARjdPbQYVT58s9niSrg4
a27qpALmX9d3b3vnSqg2XHRF6ZoytdfMfFNnJnLSU01hZjrKisfRBS8hhxVb6e8C
s+QN7tRXdwN8+5PiXLUMnWffzm/L2tCalq9iXocvxGTzB3CEBITTsD3E2ZIwHJPD
RSybBsMZlsgdtcceCXrMsTM3zPGvEUyT+g8JFVHtxnPVvBcap51Kq4TQWDjl0OWX
5AFzK8mqh5FFXoMHxojzEA8JATOndrVKPCchjV/4abqXyr4zsTrmEfiDlE/lDsDo
uQu7xkivIdibxeG5HN6aRdziXsXmNfyZzjFkqCqUy1bYhW2R7Ytcd6QtAr3fNLVB
LEH+CnApgWJgsInjXXyvISmwRq7Iy77NU092SZJ1VGCdd9mw7527PwiqgojKQ4kI
YA1/+ADPhHsWcveHtADCg3Gwr6XFCV+t+z8Q59zJNxH4hunei+BhAzYpbd9EPJ9n
7Bd7j8io7pVErMlkOnd5PKMtB9ngStBWIFwt8SDWPL6HZsqp9xjiM+VZCtsQjmGb
F373g6g3S72Add04ehexLSMxXx3TP+lwAHHiybzjhx4CRLk0LOQ=
=MOQB
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to