Your message dated Thu, 05 Dec 2019 15:06:20 +0000
with message-id <[email protected]>
and subject line Bug#934272: fixed in python-asdf 2.4.2-2
has caused the Debian Bug report #934272,
regarding python-asdf: newer pyyaml changes default_flow_style
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
934272: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=934272
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: python-asdf
Version: 2.3.3-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu eoan ubuntu-patch
Dear Maintainer,
default_flow_style=None changed to default_flow_style=False by default
in pyyaml 5.1 [1].
I wrote the following pretty heavy-handed patch to address the situation
and maintain previous behavior, though you might want to change the tests
instead and follow the changes made upstream.
[1] https://github.com/yaml/pyyaml/issues/265
*** /tmp/tmpGHYumu/bug_body
In Ubuntu, the attached patch was applied to achieve the following:
* debian/patches/fix_pyyaml_default_flow_style.patch: Make sure all calls
to yaml.dump() include default_flow_style=None, to retain previous behavior
that is checked for in tests, unless it's already otherwise specified.
Thanks for considering the patch.
-- System Information:
Debian Release: buster/sid
APT prefers eoan
APT policy: (500, 'eoan')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.2.0-8-generic (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_CA:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru python-asdf-2.3.3/debian/patches/fix_pyyaml_default_flow_style.patch
python-asdf-2.3.3/debian/patches/fix_pyyaml_default_flow_style.patch
--- python-asdf-2.3.3/debian/patches/fix_pyyaml_default_flow_style.patch
1969-12-31 19:00:00.000000000 -0500
+++ python-asdf-2.3.3/debian/patches/fix_pyyaml_default_flow_style.patch
2019-08-08 17:58:05.000000000 -0400
@@ -0,0 +1,31 @@
+From: Mathieu Trudel-Lapierre <[email protected]>
+Subject: Force yaml.dump() calls to specify default_flow_style=None
+
+default_flow_style changed to False by default, which actually changes
+the output format. Make sure we retain the previous behavior expected
+by the tests.
+
+cf. https://github.com/yaml/pyyaml/issues/265
+
+Index: python-asdf-2.3.3/asdf/block.py
+===================================================================
+--- python-asdf-2.3.3.orig/asdf/block.py
++++ python-asdf-2.3.3/asdf/block.py
+@@ -397,6 +397,7 @@ class BlockManager:
+ offsets, Dumper=yamlutil._yaml_base_dumper, stream=fd,
+ explicit_start=True, explicit_end=True,
+ version=yaml_version,
++ default_flow_style=None,
+ allow_unicode=True, encoding='utf-8')
+
+ _re_index_content = re.compile(
+Index: python-asdf-2.3.3/asdf/yamlutil.py
+===================================================================
+--- python-asdf-2.3.3.orig/asdf/yamlutil.py
++++ python-asdf-2.3.3/asdf/yamlutil.py
+@@ -340,4 +340,5 @@ def dump_tree(tree, fd, ctx):
+ explicit_start=True, explicit_end=True,
+ version=yaml_version,
+ allow_unicode=True, encoding='utf-8',
++ default_flow_style=None,
+ tags=tags)
diff -Nru python-asdf-2.3.3/debian/patches/series
python-asdf-2.3.3/debian/patches/series
--- python-asdf-2.3.3/debian/patches/series 2019-07-18 08:16:44.000000000
-0400
+++ python-asdf-2.3.3/debian/patches/series 2019-08-08 17:56:37.000000000
-0400
@@ -3,3 +3,4 @@
Emulate-importlib.resources-for-Python-3.6.patch
Remove-loopback-internet-access-test.patch
Remove-test-that-requires-the-non-existence-of-an-externa.patch
+fix_pyyaml_default_flow_style.patch
--- End Message ---
--- Begin Message ---
Source: python-asdf
Source-Version: 2.4.2-2
We believe that the bug you reported is fixed in the latest version of
python-asdf, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Ole Streicher <[email protected]> (supplier of updated python-asdf package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 05 Dec 2019 14:16:14 +0100
Source: python-asdf
Architecture: source
Version: 2.4.2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Astronomy Team
<[email protected]>
Changed-By: Ole Streicher <[email protected]>
Closes: 934272 940720
Changes:
python-asdf (2.4.2-2) unstable; urgency=medium
.
[ Mathieu Trudel-Lapierre ]
* Force yaml.dump() calls to specify default_flow_style=None (Closes:
#934272)
.
[ Ole Streicher ]
* replace SpecItem with SimpleSpec
* Explicitly add subpackages (Closes: #940720)
* Push Standards-Version to 4.4.1. No changes needed
* Remove unused copyright of astropy_helpers
* Copy from conftest.py to get small_tree fixture
* Add astropy-pytest to build deps
* Mark failing test
Checksums-Sha1:
fb01a3726f381f68b7644e8491e43c94ff9c00d1 2469 python-asdf_2.4.2-2.dsc
500b2af2c19f65ef21f4a617f1b9b55756a7b32c 8548 python-asdf_2.4.2-2.debian.tar.xz
Checksums-Sha256:
8d3630cdf48f2597175baa71cd318c3cb4630ef084608c668316e329447e9a47 2469
python-asdf_2.4.2-2.dsc
a873ec30b29c8164ce518bb6c82e39da1701d209e436c58cee03917d4b54239e 8548
python-asdf_2.4.2-2.debian.tar.xz
Files:
50f685f1840d14e81b4995abcfffad25 2469 python optional python-asdf_2.4.2-2.dsc
c3e724c216a76a904de6038fd186b9d8 8548 python optional
python-asdf_2.4.2-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEuvxshffLFD/utvsVcRWv0HcQ3PcFAl3pGDAACgkQcRWv0HcQ
3PcsKQ/+MrGBvjA8rvfvnWWSR/ochWO15tQIEvB1jeGbDekiCrswJWjYf0p8G87Y
AqWnO4kuAX2DyciW53BXpzho72+fyh0qZ+4EQqqIPe1z/MRFAbyI1M9b6Xr3OZ1W
t5R15sYT3SMj7Ses0+25VQV+KUt5e+Z3o5SKF/j8Nz2UaXCjqolhtllohXqqIcZQ
shDYmpnvI2EMJaQ2jkZT1oaqFHpwVYvaq6jq2MMCm+QQJXheZo3dUXMT0th4bWwT
JWBXWDrL245qn+BPW10W1BEiUS9eASmbGHuhIjSd08EcyoBwPmuzxmeNEtK2nVyx
6BZPMbZ6gP6vaREoIYwqf3hjb4bUzyb6iU959OFPbvP03sqkbSQrTef7F+ZCxvxE
QlpeEQT5XzQDuNOEI/lrkglbOOUMdv3rW1S64WJMK4EcGO5/I7ljB/o8p//P8gPZ
5dsKEX+gurLM5TW9eNGl+gmwPXJFkFGA98WNxQOFjIClXQ7ppYdHyl/Pq2OHzmPt
3J8my951eC3PUWfin79C7sIypuJ/rjXYhrFbf6ES48dz7LUxEUwH64ytu7sxEpBF
Ty+GO+W6u00NK46qDUzKfphgeptVLj5mIMDWxaGYKzP6Vh7dVdx1z0Xoa/D6+r/X
r1wbEWwAHEogHtYbzJVcOXBA1iUQVOUjiwjlYhlKDkzGOu2xpvM=
=Q3ZS
-----END PGP SIGNATURE-----
--- End Message ---
