Your message dated Sun, 22 Dec 2019 22:10:07 +0100
with message-id <[email protected]>
and subject line Re: Bug#922870: insserv FTCBFS: rebuilds three times
forgetting about cross tools
has caused the Debian Bug report #922870,
regarding insserv FTCBFS: rebuilds three times forgetting about cross tools
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
922870: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=922870
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: insserv
Version: 1.18.0-2
Tags: patch upstream
User: [email protected]
Usertags: rebootstrap
insserv fails to cross build from source. It actually cross builds
correctly (during dh_auto_build). Then it builds all the files again
during dh_auto_test (unless passing DEB_BUILD_OPTIONS=nocheck). And then
it builds all the files again during dh_auto_install. For
dh_auto_install, debhelper does not pass cross tools and that becomes
fatal. Buildding insserv three times does not seem useful to me. The
attached patch fixes the rebuild logic. Please consider applying it.
Helmut
--- insserv-1.18.0.orig/Makefile
+++ insserv-1.18.0/Makefile
@@ -113,9 +113,11 @@
sed -r '\!@@BEGIN_SUSE@@!,\!@@(ELSE|END)_SUSE@@!d;\!@@(NOT|END)_SUSE@@!d' < $< > $@
endif
-.system: SYSTEM=$(shell cat .system 2> /dev/null)
-.system: .force
- @test "$(SYSTEM)" = "$(ISSUSE)$(DEBUG)" || echo "$(ISSUSE)$(DEBUG)" > .system
+ifneq ($(shell cat .system 2>/dev/null),$(ISSUSE)$(DEBUG))
+.system-changed = yes
+endif
+.system: $(if $(.system-changed),.force)
+ @echo "$(ISSUSE)$(DEBUG)" > .system
.force:
--- End Message ---
--- Begin Message ---
Version: 1.20.0-1
On Fri, Feb 22, 2019 at 11:45:02AM +0000, Dmitry Bogatov wrote:
> Thank you very much. Given that you used severity: normal, I guess
> that fix could wait for next upstream release. Am I right?
Yes. It was included in 1.19. The next upload of that was 1.20.0-1 and
the issue is resolved now. Thus closing the bug.
Helmut
--- End Message ---
