Your message dated Wed, 08 Jan 2020 21:47:09 +0000
with message-id <[email protected]>
and subject line Bug#946679: fixed in libburn 1.5.0-1+deb10u1
has caused the Debian Bug report #946679,
regarding cdrskin in Debian 10 cannot burn usual Audio CD sessions but spoils
CD-R
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
946679: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946679
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: cdrskin
Version: 1.5.0-1
Severity: important
Tags: upstream
Dear Release Team,
due to a hapless bug fix before upstream release of cdrkin-1.5.0 the program
lost its ability to burn multiple tracks in one session. Multiple tracks
are the most expectable situation with burning Audio CDs.
Regrettably this is the version in current "stable".
The offending upstream commit is very simple:
https://dev.lovelyhq.com/libburnia/libburn/commit/84fad99ebaa8cb9e16a8939bb2449073038924c1
It was supposed to fix a rare bug, but created a common one.
The symptoms are
- If the first track is smaller than the fifo buffer (default 4 MiB), then
the burn run hangs with waiting for the fifo to get full.
- If the first track can fill the fifo completely, then it gets written
very slowly. Burning hangs forever at the end of the first track.
The affected medium is not blank any more. In case of CD-R it is used up
afterwards.
To reproduce the problem, i booted debian-live-10.0.0-amd64-xfce.iso and
did
# Install
sudo apt-get update
sudo apt-get install cdrskin
# Create dummy input files (CD-DA sector size is 2352 bytes)
dd if=/dev/zero bs=2352 count=5000 of=dummy_track1
dd if=/dev/zero bs=2352 count=6000 of=dummy_track2
dd if=/dev/zero bs=2352 count=7000 of=dummy_track3
# Let cdrskin misburn a CD-RW, "blank=as_needed" will erase it before burn
cdrskin -v dev=/dev/sr0 blank=as_needed -eject -audio dummy_track[1-3]
The cdrskin run has finally to be interrupted by Ctrl+C.
After about 30 to 60 seconds, the drive is released and cdrskin ends.
The older releases of Debian are not affected, because the bug was introduced
after upstream version 1.4.6, which is in Debian 9.
The freshly uploaded version 1.5.2 got a last-minute patch to fix the problem:
https://salsa.debian.org/optical-media-team/libburn/raw/master/debian/patches/01-ban-o_direct-to-fix-cdrskin-multi-track.patch
It reverts the bad change and forcefully disables the exotic configuration
of using O_DIRECT in libburn, which that change was meant to fix.
Meanwhile it migrated to testing.
The O_DIRECT configuration of libburn does not happen in the production of
Debian binary package libburn4.
So my proposal for a patch in stable is even more sparse than in testing
and avoids any change in libburn4, which is in use with Xfburn, Brasero,
and xorriso.
I created a patched cdrskin_1.5.0-2+deb10u1_amd64.deb (by debuild -S and
debuild -b) and tested on Debian 10 Live by above procedure, plus
sudo dpkg -i cdrskin_1.5.0-2+deb10u1_amd64.deb
that it burns multiple tracks with the expectable speed and result.
==========================================================================
$ debdiff libburn_1.5.0-1.dsc libburn_1.5.0-2+deb10u1.dsc
diff -Nru libburn-1.5.0/debian/changelog libburn-1.5.0/debian/changelog
--- libburn-1.5.0/debian/changelog 2018-09-24 10:48:38.000000000 +0200
+++ libburn-1.5.0/debian/changelog 2019-11-27 16:17:00.000000000 +0100
@@ -1,3 +1,14 @@
+libburn (1.5.0-2+deb10u1) UNRELEASED; urgency=low
+ * Patch taken from upstream development
+ + cdrskin multi-track burning was slow and stalled after track 1.
+ Regression introduced in version 1.5.0 by commit 84fad99, 2018.02.05,
+ which should fix a bug with O_DIRECT track reading.
+ Debian never enabled O_DIRECT, so 84fad99 was never desirable.
+ The patch reverts the upstream commit to bring the fifo code of cdrskin
+ back to the state in Debian 9 and Debian 8.
+
+ -- Thomas Schmitt <[email protected]> Wed, 27 Nov 2019 16:17:00 +0100
+
libburn (1.5.0-1) UNRELEASED; urgency=low
* New upstream release
diff -Nru libburn-1.5.0/debian/patches/01-fix-cdrskin-multi-track.patch libburn-
1.5.0/debian/patches/01-fix-cdrskin-multi-track.patch
--- libburn-1.5.0/debian/patches/01-fix-cdrskin-multi-track.patch 1970-01-
01 01:00:00.000000000 +0100
+++ libburn-1.5.0/debian/patches/01-fix-cdrskin-multi-track.patch 2019-11-
27 16:17:00.000000000 +0100
@@ -0,0 +1,18 @@
+Description: Bug fix: cdrskin multi-track burning was slow and stalled
+ after track 1.
+ Regression introduced in version 1.5.0 by commit 84fad99, 2018.02.05,
+ which should fix a bug with O_DIRECT track reading.
+ This patch reverts the upstream commit to bring the fifo code of cdrskin back
+ to the state of cdrskin-1.4.6 in Debian 9 and cdrskin-1.3.2 in Debian 8.
+Author: Thomas Schmitt <[email protected]>
+
+--- a/cdrskin/cdrfifo.c
++++ b/cdrskin/cdrfifo.c
+@@ -28,7 +28,6 @@
+ #ifndef Cdrfifo_standalonE
+ /* for burn_os_alloc_buffer() */
+ #include "../libburn/libburn.h"
+-#define Libburn_has_open_trac_srC 1
+ #endif
+
+ #include "cdrfifo.h"
diff -Nru libburn-1.5.0/debian/patches/series
libburn-1.5.0/debian/patches/series
--- libburn-1.5.0/debian/patches/series 2018-04-03 19:59:27.000000000 +0200
+++ libburn-1.5.0/debian/patches/series 2019-11-27 16:17:00.000000000 +0100
@@ -0,0 +1,2 @@
+01-fix-cdrskin-multi-track.patch
+
==========================================================================
-- System Information:
Debian Release: buster
Architecture: amd64 (x86_64)
(I write this on a Sid system. But as said, i tested on Debian 10 Live
and the problem is in upstream code, where it is fixed similarly now.)
Have a nice day :)
Thomas
--- End Message ---
--- Begin Message ---
Source: libburn
Source-Version: 1.5.0-1+deb10u1
We believe that the bug you reported is fixed in the latest version of
libburn, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Thomas Schmitt <[email protected]> (supplier of updated libburn package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 27 Nov 2019 16:17:00 +0100
Source: libburn
Architecture: source
Version: 1.5.0-1+deb10u1
Distribution: buster
Urgency: low
Maintainer: Debian Libburnia packagers
<[email protected]>
Changed-By: Thomas Schmitt <[email protected]>
Closes: 946679
Changes:
libburn (1.5.0-1+deb10u1) buster; urgency=low
.
* Patch taken from upstream development
+ cdrskin multi-track burning was slow and stalled after track 1.
Regression introduced in version 1.5.0 by commit 84fad99, 2018.02.05,
which should fix a bug with O_DIRECT track reading.
Debian never enabled O_DIRECT, so 84fad99 was never desirable.
The patch reverts the upstream commit to bring the fifo code of cdrskin
back to the state in Debian 9 and Debian 8. Closes: #946679
Checksums-Sha1:
4104885a36a8a31752e6db453874e70d48bbd5c0 2230 libburn_1.5.0-1+deb10u1.dsc
6cb578ba2f9fcf132eac869dfd0aec6cedc66ecd 9884
libburn_1.5.0-1+deb10u1.debian.tar.xz
110f9b409b5e5dc1b9b4588b3d8b404d251e2781 5586
libburn_1.5.0-1+deb10u1_source.buildinfo
Checksums-Sha256:
aaf115f93fb9b56d712362e81b66cf08a26a7814f95b080dada6e7696bd6db7a 2230
libburn_1.5.0-1+deb10u1.dsc
90930eb0909b3f4033c030f513b06350e41ce6b15cc7eedda8b8003e09f11a6d 9884
libburn_1.5.0-1+deb10u1.debian.tar.xz
395d6bf5ee44674c4b4ec2ef83925f8e6eba6bdad17c068859a9abeff65d98c1 5586
libburn_1.5.0-1+deb10u1_source.buildinfo
Files:
901c89619e493f6f40288db1f8ff5964 2230 libs optional libburn_1.5.0-1+deb10u1.dsc
f4301fd15ed1a541b9ed9ad20591d452 9884 libs optional
libburn_1.5.0-1+deb10u1.debian.tar.xz
2f378e8bbd02ef908ed285add8431344 5586 libs optional
libburn_1.5.0-1+deb10u1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEzrtSMB1hfpEDkP4WWHl5VzRCaE4FAl4OJ94ACgkQWHl5VzRC
aE4T9A/9EXLLmZwNjFJwJAOXwR7dC68rQyVC3qqpxqdTogXJ6bhZW0o268pxPmc5
NR0Up3DbGx6czwpVDf3rtPjBv58JHJ6AG+a8GvLrpTVNWLc1iojYbiB+wdTMq1rx
bWUO0cvdf/8juI5NsyuDKfukQZ3gSjpTqB1OXuX6Mm9MTU/zH8vR24tMIGTcX+6r
fV9Znw0qWfsPyVKNGXGgD5vFt54SoB5VocA4bHs10ny+JfxYeWjdxf7xaNND7dkd
WrBE7cGywsoiNtfrzPtL2AZU9FSt94mw9AXzw0dHMZUpdIwIX1sRct+1AjnhV1wc
UkMmL34SaM5C6uLoYahyN/6qrxhv0hxWkJDf+bwuO1O2ZHRW11C6x8OJpITQyVnF
l88qlwP7Jg7Z5uA1Yr+ypbNrGLISH7B5W9ZinjOYVvJJqvXRBXBaByYs4v6G7OUe
rbJx/45cRAm8qSvZnTcXLdme1LTft+Su4G4w5+IirnGq2L2UGr5scnK/hX7E2PCC
n95XVZuHzO6LQdY2iHDU9ItlhgEkBULlFgo4DSgVnGvLaTxA96d9sqilDMoD9uCe
khUsm3a+X0N2liMww+t0xhlNbJH/FEihgiDbT6ANL2TAHf/JwQ23qP8yT2k5ekqV
mCnUrPE3usBLH1VeRcXqVhYVXOuchK7Dijs1iQKx7ToBdb2qC9A=
=rkH7
-----END PGP SIGNATURE-----
--- End Message ---
