Your message dated Sat, 11 Jan 2020 06:49:20 +0000
with message-id <[email protected]>
and subject line Bug#948559: fixed in double-conversion 3.1.5-5
has caused the Debian Bug report #948559,
regarding double-conversion: Please make autopkgtests cross-test-friendly
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
948559: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=948559
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: double-conversion
Version: 3.1.5-4
Severity: minor
Tags: patch
User: [email protected]
Usertags: origin-ubuntu focal ubuntu-patch
Hi Mo,
In Ubuntu, we are in the process of moving the i386 architecture to a
compatibility-only layer on amd64, and therefore we are also moving our
autopkgtest infrastructure to test i386 binaries in a cross-environment.
This requires changes to some tests so that they are cross-aware and can do
the right thing.
The double-conversion tests currently fail in this environment, because
there are build tests that do not invoke the toolchain in a cross-aware
manner. I've verified that the attached patch lets the tests successfully
build (and run) i386 tests on an amd64 host.
As part of the patch I am dropping the first of the two tests listed in
debian/tests/control, after determining that the two tests are redundant
with one another since both are just building and running the test suite.
Note that upstream autopkgtest doesn't currently set DEB_HOST_ARCH so this
is a complete no-op in Debian for the moment. Support for cross-testing in
autopkgtest is currently awaiting review at
https://salsa.debian.org/ci-team/autopkgtest/merge_requests/69 and once
landed, will still have no effect unless autopkgtest is invoked with a '-a'
option. So this change should be safe to land in your package despite this
not being upstream in autopkgtest.
Thanks for considering,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru double-conversion-3.1.5/debian/tests/control
double-conversion-3.1.5/debian/tests/control
--- double-conversion-3.1.5/debian/tests/control 2019-07-09
19:40:33.000000000 -0700
+++ double-conversion-3.1.5/debian/tests/control 2020-01-09
22:28:28.000000000 -0800
@@ -1,7 +1,3 @@
-# build and run upstream unit tests
-Test-Command: g++ test/cctest/*.cc -ldouble-conversion -o run_tests; make test
-Depends: @, build-essential
-
Tests: unittest.sh
Depends: @, build-essential
diff -Nru double-conversion-3.1.5/debian/tests/unittest.sh
double-conversion-3.1.5/debian/tests/unittest.sh
--- double-conversion-3.1.5/debian/tests/unittest.sh 2019-11-23
22:40:08.000000000 -0800
+++ double-conversion-3.1.5/debian/tests/unittest.sh 2020-01-09
22:28:13.000000000 -0800
@@ -3,18 +3,24 @@
elfname="run_tests"
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+ CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+ CROSS_COMPILE=
+fi
+
# compile src into object files
srcs=$(find test/cctest -type f -name '*.cc' -print)
for src in $srcs; do
if ! test -r ${src%.cc}.o; then
- g++ -march=native -c $src -o ${src%.cc}.o
+ ${CROSS_COMPILE}g++ -march=native -c $src -o ${src%.cc}.o
echo CXX $src
fi
done
# link
objs=$(find test/cctest -type f -name '*.o' -print)
-g++ -o $elfname $objs -ldouble-conversion
+${CROSS_COMPILE}g++ -o $elfname $objs -ldouble-conversion
echo LD $elfname
# execute
--- End Message ---
--- Begin Message ---
Source: double-conversion
Source-Version: 3.1.5-5
We believe that the bug you reported is fixed in the latest version of
double-conversion, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mo Zhou <[email protected]> (supplier of updated double-conversion package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 11 Jan 2020 14:36:44 +0800
Source: double-conversion
Architecture: source
Version: 3.1.5-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Team
<[email protected]>
Changed-By: Mo Zhou <[email protected]>
Closes: 948559
Changes:
double-conversion (3.1.5-5) unstable; urgency=medium
.
[ Steve Langasek ]
* Drop one of the redundant autopkgtests.
* Make remaining autopkgtests cross-test-friendly. (Closes: #948559)
.
[ Mo Zhou ]
* Add a pkg-config template.
* Add static Config.cmake files for double-conversion.
* Install the pkg-config and cmake files to the -dev package.
* And a corresponding autopkgtest case for the cmake files.
Checksums-Sha1:
2e9da0ffaef1f7c893ac3848e12efd3b5a802fa5 2212 double-conversion_3.1.5-5.dsc
bb47d742d54503825f02c0d036e0030a4ab9a7d4 7876
double-conversion_3.1.5-5.debian.tar.xz
6f3e2f68f488ae5194d1a8797308595551e4ed6d 5898
double-conversion_3.1.5-5_source.buildinfo
Checksums-Sha256:
5a3b8da32dc8c2faf0bfc178d701e777b94b0a10559cc80afbc6ed3701903d51 2212
double-conversion_3.1.5-5.dsc
60cd85f586faa4454692a11d4ff85c304219ff7e58be50af1c45ed4e2cce32a9 7876
double-conversion_3.1.5-5.debian.tar.xz
86cc52ce4e4976f1aaa04aede4baf2ab449137fde2d7b88c38f43cdc1e15c0ac 5898
double-conversion_3.1.5-5_source.buildinfo
Files:
f4acbe1888997a6ce6d1db89ef335fd9 2212 libs optional
double-conversion_3.1.5-5.dsc
6083f44b9fe985ca316a9865b1ffa010 7876 libs optional
double-conversion_3.1.5-5.debian.tar.xz
3c1d36df0a4ecde39121fab60938898f 5898 libs optional
double-conversion_3.1.5-5_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCgAvFiEEY4vHXsHlxYkGfjXeYmRes19oaooFAl4ZbWARHGx1bWluQGRl
Ymlhbi5vcmcACgkQYmRes19oaoo5tQ//ax69wsC1ggUvAdWeT/BFi06aa5OjQWRm
wK6V9I52lZN/LOt2EAOqVpdPDovAJmvarq2KdzllCU39tVdkdFYXDOqsz8HSOmZ7
HZ+QYBziGGnLVUDCjy1AS2BYCB5GckQGc+AUupjCjmn89LM5jmVswp5bsUuoakfw
5WmT/o7Rgb4xg6KsYRdIsY2tgqdxt2+OuVDMKaep/R9gjRkIU/IVo6JtbRs9IY8W
iVevZix5vz9v631FeGS9F67YiUB8Sek/OIOl+ABPHP/FIiNRM26lTiHReCF8L/QZ
qc8AD31APBrXept6igJtvY9Hr65lkkqLJrARZ5j0gqSnE9Cve8Bi9JIvK/rOnlc4
APMPjtAgSn/xcFfJOuy7Vj5WGFYl7SEsDv2b+hnSuGguW4L/dv0h5YrQw3f9veb7
vTodiT0Mpz12uGE95UMzdQ4uQbeU8dspCnoQvAu8ACO0a4gpPZV2Rn940hn8DTZY
Nq/K6v2S7GjenMieDfePf/3Tw3YYwovKskePWjyHvWwuXPgXXvh56WK2lPzfNJzU
Rm8orjdlPjP7lg1shrVaG32lQuuq3aoIo6purhg1iwMceIcEgx3xm/cxgVir/iEf
vRw5b2TiSJ6Urr4pI3BFkaOwnPnYSmiXKhmzP2EqEUXSFmA6Rip5MfM6cRuwea2s
lV960WPq/Xw=
=/afS
-----END PGP SIGNATURE-----
--- End Message ---
