Your message dated Sat, 11 Jan 2020 23:05:21 +0100 with message-id <[email protected]> and subject line Re: Bug#857454: qtltools: please make the build reproducible has caused the Debian Bug report #857454, regarding qtltools: please make the build reproducible to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 857454: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857454 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Source: qtltools Version: 1.1+dfsg-1 Severity: wishlist Tags: patch User: [email protected] Usertags: randomness X-Debbugs-Cc: [email protected] Hi, Whilst working on the Reproducible Builds effort [0], we noticed that qtltools could not be built reproducibly. This is because the examples.tar.xz can contain itself: ├── ./usr/share/doc/qtltools/examples/examples.tar.xz ├── 6-content ├── file list │ │ │ │ │ │ @@ -1,7 +1,8 @@ │ │ │ │ │ │ +-rw-r--r-- 0 0 0 0 2018-03-21 07:15:07.000000 ./examples.tar.xz Patch attached; we should be removing this file in the clean target anyway. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` [email protected] / chris-lamb.co.uk `-diff --git a/debian/rules b/debian/rules index cc7f05e..2b25c1a 100755 --- a/debian/rules +++ b/debian/rules @@ -11,6 +11,10 @@ override_dh_auto_build: mkdir -p $(CURDIR)/bin/ dh_auto_build +override_dh_auto_clean: + rm -f debian/upstream.example/examples.tar.xz + dh_auto_clean + override_dh_install: cd debian/upstream.example && find -type f | LC_ALL=C sort | tar -T - --sort=name --mode=go=rX,u+rw,a-s --owner=root --group=root --numeric-owner -Jcvf examples.tar.xz dh_install
--- End Message ---
--- Begin Message ---On Sun, Dec 29, 2019 at 11:44:35AM +0000, Chris Lamb wrote: > > This appears to have reoccured: > > │ │ │ ├── ./usr/share/doc/qtltools/examples/examples.tar.xz > │ │ │ │ ├── examples.tar > │ │ │ │ │ ├── file list > │ │ │ │ │ │ @@ -1,8 +1,7 @@ > │ │ │ │ │ │ --rw-r--r-- 0 0 0 0 2019-12-28 > 13:56:00.000000 ./examples.tar.xz > │ │ │ │ │ │ -rw-r--r-- 0 0 0 1230243 2019-09-30 > 21:26:57.000000 ./genes.50percent.chr22.bed.gz > │ │ │ │ │ │ -rw-r--r-- 0 0 0 4634 2019-09-30 > 21:26:57.000000 ./genes.50percent.chr22.bed.gz.tbi > > ie. the examples.tar.xz can include itself. My previous patch has still > been applied so I wonder what has changed upstream (or in the toolchain) > that could have caused this regression. As Michael explained this is not the case in his recent upload any more. I also added in Git[1] some | grep -v examples.tar.xz before the tar command to make really sure it should not happen again in the next upload. Thus closing the bug. Kind regards Andreas. [1] https://salsa.debian.org/med-team/qtltools/blob/master/debian/rules#L22 -- http://fam-tille.de
--- End Message ---
