Your message dated Sun, 19 Jan 2020 10:19:22 +0000
with message-id <[email protected]>
and subject line Bug#944478: fixed in debhelper 12.8
has caused the Debian Bug report #944478,
regarding suboptimal handling of tmpfiles if dh_installsystemd is called
multiple times
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
944478: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944478
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: debhelper
Version: 12.7.1
Severity: normal
Hi,
I'm currently working on updating the debhelper compat level in systemd
from 10 to 12:
https://salsa.debian.org/systemd-team/systemd/commits/wip/compat-12
systemd ships several units files, which are currently enabled manually
in the maintainers scripts.
systemd also ships several tmpfiles, which are currenly enabled via
dh_installinit.
With compat level 12 and dh_installsystemd, tmpfiles are no longer
handled by dh_installinit.
Since I need to call dh_installsystemd several times (with different
argument), the following code is currently added multiple times as well:
if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
# In case this system is running systemd, we need to ensure that all
# necessary tmpfiles (if any) are created before starting.
if [ -d /run/systemd/system ] ; then
systemd-tmpfiles --create debian.conf home.conf
journal-nocow.conf legacy.conf systemd-nologin.conf systemd.conf tmp.conf
var.conf x11.conf >/dev/null || true
fi
fi
https://salsa.debian.org/systemd-team/systemd/commit/25bbc8de507f2f9317149eb1f152e899e77776a1
This is not really great.
Somehow I think it would the cleanest solution if tmpfiles handling was
split into a separate helper, say dh_installtmpfile which can be called
individually from dh_installsystemd.
Technically this would make sense, as a tmpfile is strictly speaking no
unit file. We would leave handling of unit files solely to
dh_installsystemd.
Only issue would be, that we need to get the ordering right, but I think
it would be sufficient if we always call dh_installtmpfile before
dh_installsystemd (at least I can't think of a reason why we ever need
to run it after dh_installsystemd).
Comments most welcome.
Maybe there is different solution to fix this directly in
dh_installsystemd which I'm not seeing.
Regards,
Michael
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable
APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.3.0-2-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_WARN
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8),
LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages debhelper depends on:
ii autotools-dev 20180224.1
ii dh-autoreconf 19
ii dh-strip-nondeterminism 1.6.2-1
ii dpkg 1.19.7
ii dpkg-dev 1.19.7
ii dwz 0.13-2
ii file 1:5.37-6
ii libdebhelper-perl 12.7.1
ii libdpkg-perl 1.19.7
ii man-db 2.9.0-1
ii perl 5.30.0-9
ii po-debconf 1.0.21
debhelper recommends no packages.
Versions of packages debhelper suggests:
ii dh-make 2.201902
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: debhelper
Source-Version: 12.8
We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Niels Thykier <[email protected]> (supplier of updated debhelper package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 19 Jan 2020 10:02:16 +0000
Source: debhelper
Architecture: source
Version: 12.8
Distribution: unstable
Urgency: medium
Maintainer: Debhelper Maintainers <[email protected]>
Changed-By: Niels Thykier <[email protected]>
Closes: 198507 885994 906723 917368 944478 944691
Changes:
debhelper (12.8) unstable; urgency=medium
.
[ Niels Thykier ]
* Dh_Lib.pm: Simplify internal loggning of which commands
have been run. We are no longer interested in whether
it was an override target or not.
* dh: Support "execute_before_X" and "execute_after_X"
targets in debian/rules. This is useful for injecting
commands before or after the command "X" that dh runs.
Note this feature requires compat 10 or later due to
internal limitations in debhelper. Attempts to use
it in compat 9 will trigger an error. Thanks to
Christoph Berg for the suggestion. (Closes: #885994)
* dh: Detect and warn about override and hook targets
for known obsolete commands. In compat 13, this will
be an error instead of a warning.
* dh: Reset umask to 0022 as a consistent default value.
Thanks to Thorsten Glaser for the suggestion.
(Closes: #944691)
* dh_missing: The --fail-missing parameter is now default
in compat 13. Thanks to Mattia Rizzolo for the
suggestion. (Closes: #917368)
* dh_installtmpfiles: New command extracted from
dh_installsystem that will handle tmpfiles.d
configuration. Thanks to Michael Biebl for the
suggestion. (Closes: #944478)
* dh_installsystemd: In compat 13, this command will no
longer manage tmpfiles.d configuration.
* dh: Run dh_installtmpfiles by default in compat 13.
* Dh_Lib.pm: Emit "error" and "warning" with error and
warning messages. Thanks to Paul Wise for the
suggestion. (Closes: #906723)
* Dh_Lib.pm: Support colored output for warnings and
errors (enabled by default). The colors can be
controlled by setting DH_COLORS or DPKG_COLORS. The
latter will also affect dpkg-related tools.
Note: NO_COLOR is respected in the absence of
DH_COLORS and DPKG_COLORS.
* Dh_Lib.pm: Support substitution variables in files
handled by filearray and filedoublearray in compat 13.
This also applies to executable configuration files.
As the substitution occurs after splitting the files
into tokens, it can be used to include spaces in the
tokens (often file names). (Closes: #198507)
* dh_install: Support substitution configuration files.
* dh_clean: Ditto.
* dh_installcatalogs: Ditto.
* dh_installdeb: Ditto (maintscripts only).
* dh_installdirs: Ditto.
* dh_installdocs: Ditto.
* dh_installexamples: Ditto.
* dh_installinfo: Ditto.
* dh_installman: Ditto.
* dh_installwm: Ditto.
* dh_link: Ditto.
* dh_missing: Ditto.
* dh_ucf: Ditto.
* debian/rules: Remove override for dh_missing as the
--fail-missing parameter is default now.
.
[ Helmut Grohne ]
* Warn about missing perl-xs-dev for perl_* buildsystems.
Checksums-Sha1:
d7d6166a4b0adef3ff1fd09d0b8ca162c1c928c0 1835 debhelper_12.8.dsc
fa9331630bc7414d2af3251c61b7d6bf47758714 517508 debhelper_12.8.tar.xz
bab5a3ecb0ff79835ce8b8e6bce3c3e42c81cf0b 4578 debhelper_12.8_source.buildinfo
Checksums-Sha256:
5e586386833e5bc5a8307ba36c4fdb5a3e965756e92ac7a91ca9752a18416fdf 1835
debhelper_12.8.dsc
8ef5c8eae677b98d826405d0c323df7f74eba7fe4716545abf507235a86e8b5d 517508
debhelper_12.8.tar.xz
5d07a89fe4f4629dafd22bdd67c678dd40a3551133092975273613ec762d0a7a 4578
debhelper_12.8_source.buildinfo
Files:
dc997eef9382e8828617e150498b38f4 1835 devel optional debhelper_12.8.dsc
eafc304b3c69848e204e5eadf41e1f2a 517508 devel optional debhelper_12.8.tar.xz
25a631399bb0b3d12be2e8a23b663c8b 4578 devel optional
debhelper_12.8_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJGBAEBCgAwFiEE8f9dDX4ALfD+VfsMplt42+Z8eqwFAl4kKasSHG5pZWxzQHRo
eWtpZXIubmV0AAoJEKZbeNvmfHqstaUQAJmzBdm6FOaYneMYYIQFEuUWQEk0cSv+
0X72ik2pM8jCLHCJMvfa0fKMAc3KHsIqkeXaPbouuD/StdJCO4dIQI3GL7RNp03A
7z7e2IFi3FKg+9ExYU57JO8faSPWrnn4MVzmS6WlqYvce6A9hL5evqELoK+I8akn
RtWQnu03dzH/xBEdvvA5zVRa65A5uuvNfKy+pODqj6J1mrrz4cO93iqVgN6X7L64
9aGKE3MhkHqNxEoggqwDW2y9bVJCVJAlD4ctrxgmmn3lnOnA8aC4EMsSb3CwAOMb
d76VFpbW7eadxTTlti7HF2apJaP9iXqYUvw58s90ueVYKa18BNC894p/TUKn2LCE
/UsOGai3TZlvFfFlqwssXim3Mmi0kgjF1RAWROhO1/MxwnbjwHsln9R1s6QDwXLN
d+xTKGnBBqtFaKh6ryf18MSQDn/OU5Kuo73jbW4MzWN3IfC5dOIKiV54vWo6u/Hs
iTzeVsd8e5Mi0OPpTuFWuvMVsq4BOmYyyCZcS1k0pohJ9wcZe4387av5JKc7S0Cp
zi3rb/Ydu+8UCIgWFfnRYyKc58NJQPkhEMPIaMlVoRMPPTWCKXGcnlngkx9eHSxR
V66vOKwSDc033KtZuZJSlz1XOdgHPohEkaDb3/V08HaEx+uUCREjYvWV+zVSU6mA
P9MQsz4sOsV0
=cOIK
-----END PGP SIGNATURE-----
--- End Message ---
