Your message dated Sun, 19 Jan 2020 12:12:49 +0100 with message-id <[email protected]> and subject line Re: Bug#929295: Acknowledgement (fstrim.service: fstrim -a (not -A) or add ConditionPathExists=/etc/fstab) has caused the Debian Bug report #929295, regarding fstrim.service: fstrim -a (not -A) or add ConditionPathExists=/etc/fstab to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 929295: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929295 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: util-linux Version: 2.33.1-0.1 Severity: wishlist File: /lib/systemd/system/fstrim.service Currently fstrim.service runs "fstrim --fstab --verbose", so it silently ignores * Stuff mounted via hand-written systemd.mount units (e.g. /usr/share/systemd/tmp.mount); * ZFS datasets mounted via -o canmount and -o mountpoint properties. Why not use "fstrim --all --verbose" instead? Or, if you keep "fstrim --fstab --verbose", please consider adding [Unit] ConditionPathExists=/etc/fstab so that it will NOP instead of erroring when fstab is completely absent: systemd[1]: Condition check resulted in Discard unused blocks on filesystems from /etc/fstab being skipped. Whereas currently it does this: fstrim[5003]: fstrim: failed to parse /etc/fstab: No such file or directory systemd[1]: fstrim.service: Main process exited, code=exited, status=32/n/a systemd[1]: fstrim.service: Failed with result 'exit-code'. systemd[1]: Failed to start Discard unused blocks on filesystems from /etc/fstab. systemd[1]: fstrim.service: Consumed 38ms CPU time, no IP traffic. PS: fstrim.timer is disabled by default, so you only see errors if you have no /etc/fstab *and* enable fstrim.timer or start fstrim.service. -- System Information: Debian Release: 10.0 APT prefers testing APT policy: (990, 'testing'), (500, 'testing-proposed-updates'), (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 4.19.0-5-amd64 (SMP w/2 CPU cores) Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages util-linux depends on: ii fdisk 2.33.1-0.1 ii libaudit1 1:2.8.4-3 ii libblkid1 2.33.1-0.1 ii libc6 2.28-10 ii libcap-ng0 0.7.9-2 ii libmount1 2.33.1-0.1 ii libpam0g 1.3.1-5 ii libselinux1 2.8-1+b1 ii libsmartcols1 2.33.1-0.1 ii libsystemd0 241-3 ii libtinfo6 6.1+20181013-2 ii libudev1 241-3 ii libuuid1 2.33.1-0.1 ii login 1:4.5-1.1 ii zlib1g 1:1.2.11.dfsg-1 util-linux recommends no packages. Versions of packages util-linux suggests: ii dosfstools 4.1-2 ii kbd 2.0.4-4 ii util-linux-locales 2.33.1-0.1 -- no debconf information
--- End Message ---
--- Begin Message ---Hello, On Tue, May 21, 2019 at 03:12:44PM +1000, Trent W. Buck wrote: > > Why not use "fstrim --all --verbose" instead? > > I knew there would be a reason, I just didn't know what it was. > The reason is to avoid trimming on ad-hoc mounted devices: > > https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/commit/sys-utils/fstrim.service.in?id=0d73ea8bf96b036cc12fae6865158c936705238d > https://github.com/karelzak/util-linux/issues/673 > https://bugs.debian.org/889668 Seems like you answered your own questions (thanks for the followup), so I guess this bug report can simply be closed by this. Doing so. Regards, Andreas Henriksson
--- End Message ---
