Your message dated Thu, 23 Jan 2020 17:51:03 +0000
with message-id <[email protected]>
and subject line Bug#949275: fixed in geoip 1.6.12-6
has caused the Debian Bug report #949275,
regarding geoip: example Makefile contains build path
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
949275: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=949275
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: geoip
Severity: normal
Tags: patch
User: [email protected]
Usertags: buildpath
X-Debbugs-Cc: [email protected]

A makefile shipped in the examples directory contains build path
variations for several values
/usr/share/doc/libgeoip-dev/examples/Makefile:

  ACLOCAL·​=·​${SHELL}·​/​build/​1st/​geoip-​1.​6.​12/​missing·​aclocal-​1.​16


This makes the build unreproducible when built from a different path,
but the Makefile itself would require some manual configuration anyways,
since the end-user most likely does not contain the original build path
on their system.

I'd suggest simply removing the Makefile, as it's not functional, or
alternately, sanitizing it with the attached patch to debian/rules.

live well,
  vagrant

From 3cded7ea178083a9949612944e8001b459dc62ee Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <[email protected]>
Date: Sat, 18 Jan 2020 22:28:36 -0800
Subject: [PATCH 2/2] debian/rules: Strip build-path from example Makefile.

---
 debian/rules | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/debian/rules b/debian/rules
index eaaf945..086d01d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -29,3 +29,13 @@ override_dh_install:
 	dh_install
 	strip --remove-section=.comment \
 		$(CURDIR)/debian/libgeoip-dev/usr/lib/$(DEB_HOST_MULTIARCH)/libGeoIP.a
+
+override_dh_installexamples:
+	dh_installexamples
+	# Clean up embedded build paths in order to ensure reproducible builds.
+	sed -i -e "s,-fdebug-prefix-map=$(CURDIR)=\.,,g" \
+		-e "s,-ffile-prefix-map=$(CURDIR)=\.,,g" \
+		-e "s,abs_.*$(CURDIR).*,,g" \
+		-e "s,$(CURDIR).*missing --run,,g" \
+		-e "s,$(CURDIR),./,g" \
+		$(CURDIR)/debian/libgeoip-dev/usr/share/doc/libgeoip-dev/examples/Makefile
-- 
2.20.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: geoip
Source-Version: 1.6.12-6

We believe that the bug you reported is fixed in the latest version of
geoip, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Patrick Matthäi <[email protected]> (supplier of updated geoip package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 23 Jan 2020 16:32:51 +0100
Source: geoip
Architecture: source
Version: 1.6.12-6
Distribution: unstable
Urgency: medium
Maintainer: Patrick Matthäi <[email protected]>
Changed-By: Patrick Matthäi <[email protected]>
Closes: 949273 949275
Changes:
 geoip (1.6.12-6) unstable; urgency=medium
 .
   * Merge patch from Vagrant Cascadian to allow reproducible builds on systems
     with a merged /usr.
     Closes: #949273
   * Use the new debhelper-compat notation, and drop the d/compat file.
   * Add Rules-Requires-Root no.
   * Bump Standards-Version to 4.5.0.
   * Adjust source lintian-overrides.
   * Remove example Makefile whichn references the build path.
     Closes: #949275
Checksums-Sha1:
 db8a1d027d65685713d8dbba9c0c2ae3ef9d4057 1837 geoip_1.6.12-6.dsc
 90cfafee605c94cfa24858fe77193fa7fa949ac8 160826 geoip_1.6.12.orig.tar.gz
 5605587b9c71a9d4b74ebab0420fedb547ea491a 37848 geoip_1.6.12-6.debian.tar.xz
 803a7877c683b66b4d05be29db546dc2c3f16067 5931 geoip_1.6.12-6_source.buildinfo
Checksums-Sha256:
 0664b77c5575b1b8c920657274cec8fb420c8c7df194e938acd992e65c7a71da 1837 
geoip_1.6.12-6.dsc
 99b119f8e21e94f1dfd6d49fbeed29a70df1544896e76cd456f25e397b07d476 160826 
geoip_1.6.12.orig.tar.gz
 60aa0b3835fea38d70510d04e835a611ed8e9ba2e6357fa7d684affafca7d923 37848 
geoip_1.6.12-6.debian.tar.xz
 cfaee8ac1c9200f6916e21e179b24831b2097eef94c7eb297e372acbaa105b31 5931 
geoip_1.6.12-6_source.buildinfo
Files:
 f541ea9a0272a4cc7f70f9b0d78e0df2 1837 net optional geoip_1.6.12-6.dsc
 727e5d6df9e9fc039dbc3a323cc56d2e 160826 net optional geoip_1.6.12.orig.tar.gz
 d660b79f49ce7239d17e20cabca9dcd2 37848 net optional 
geoip_1.6.12-6.debian.tar.xz
 636e623bbe3a12437b2fc40c53b039bb 5931 net optional 
geoip_1.6.12-6_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEWKA9xYJCWk3IuQ4TEtmwSpDL2OQFAl4p19QACgkQEtmwSpDL
2OQs/A//VzYbD4bIOOgK9OpYqA1+/G8dfmY7CM2DkdTy4ST+bzM+4fVxVuQH9w9P
Y2NAMcjxFLW/Yrzg9bHKRU7vIWk1GdoGhts5rZytJhSiucO0gctCF/CzuB0iSQKr
+46zmzwzR/S61TiwK8hVxyk9RO3+62a+z6l04wlORiIvovc/rIM27TGTTgkb7eZE
Xsd4C23O/klNM3gzPc9YN89qmECb0/+ofnGrOnGHQD3hseXInd4EBi1TOuKVSvsh
9IdurtPZJYXXe0mhzIk8yLGO3WpE9mLKloS/1w4c2qoggoGhkPvAIHx0ovLifnzg
YCI1886d5ETuXmhkYtOr6AjblaTUDJFjrpAhGKcVIiTrlHBl+gmMQtT295bQKE+C
n6cay0pzI+pyEJvMHtCanWl/azUJ1YLmTUtgCVKqjeEDV0SmOlQVeSv9gVjheUwX
0rkSAUA3vcvwsZ0XbxyqklTYxOVHLU4533KIAcdwTuV+tpW5EyhBXmXJP0pNDEqc
h5DBsMx/6VdN8/s92xIh9eW6MBLO30Bnkv+0tiLvmb7J+LNYELE7qI3IoEzLZrbj
gx+2cH4c9diA9qnQtM0uV4AXuaKBpj2ukjwncHc8xt8gJoMc78FjjpZDVprc0hR/
CKy1NKXs7Cz7T+4nvckqbBG82Ik5cC6sosYOLGbaFQponhrHt3c=
=3uPd
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to