Your message dated Fri, 21 Feb 2020 06:34:36 +0000
with message-id <[email protected]>
and subject line Bug#935167: fixed in prometheus-node-exporter 0.18.1+ds-2
has caused the Debian Bug report #935167,
regarding prometheus-node-exporter: apt.sh text collector fails to deal with 
spaces in repository label
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
935167: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935167
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: prometheus-node-exporter
Version: 0.17.0+ds-3
Severity: normal

Hi,
the apt.sh script currently shipped with the prometheus-node-exporter package 
is not
able to deal with spaces in the repository label.
Result is output like:

~$ /usr/share/prometheus-node-exporter/apt.sh |grep Postgre
apt_upgrades_pending{origin="PostgreSQLfor",arch="Debian/Ubuntu"} 6
apt_upgrades_pending{origin="PostgreSQLfor",arch="Debian/Ubuntu"} 9

This fails basically because of duplicate label in a prometheus metric.
Beside of that the label values are of course wrong.

Anyway this is fixed upstream in:
https://github.com/prometheus-community/node-exporter-textfile-collector-scripts/commit/505079407a638c6a3cce6a7ce434500463d9cb28

Sadly the scripts were moved to a different repo lately and thus
probably missed by the packaging.
https://github.com/prometheus/node_exporter/tree/master/text_collector_examples

I'm not yet sure how we could handle that in a good way with the current 
packaging.
Either using git submodules or having several upstream branches and merge them 
somehow,
or build from several source packages.

Opened a MR at
https://salsa.debian.org/go-team/packages/prometheus-node-exporter/merge_requests/3
though I'd consider that at most a temporary workaround. The packaging basically
requires some adjustment to handle this unfortunate source split upstream.

Regards,
Sven

-- System Information:
Debian Release: 10.0
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (90, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages prometheus-node-exporter depends on:
ii  libc6         2.28-10
ii  moreutils     0.62-1
ii  systemd-sysv  241-5

Versions of packages prometheus-node-exporter recommends:
ii  dbus           1.12.16-1
ii  python3        3.7.3-1
pn  smartmontools  <none>

prometheus-node-exporter suggests no packages.

--- End Message ---
--- Begin Message ---
Source: prometheus-node-exporter
Source-Version: 0.18.1+ds-2
Done: Daniel Swarbrick <[email protected]>

We believe that the bug you reported is fixed in the latest version of
prometheus-node-exporter, which is due to be installed in the Debian FTP 
archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Swarbrick <[email protected]> (supplier of updated 
prometheus-node-exporter package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 21 Feb 2020 05:56:03 +0000
Source: prometheus-node-exporter
Architecture: source
Version: 0.18.1+ds-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Go Packaging Team 
<[email protected]>
Changed-By: Daniel Swarbrick <[email protected]>
Closes: 935167
Changes:
 prometheus-node-exporter (0.18.1+ds-2) unstable; urgency=medium
 .
   [ Daniel Swarbrick ]
   * Move bundled textfile collector example scripts and their associated
     systemd services / timers to new prometheus-node-exporter-collectors
     package.
 .
   [ Sven Hoexter ]
   * Add 05-apt-label-parsing.patch, to handle spaces in repository
     label correctly. Picked from the upstream repository. Closes: #935167
Checksums-Sha1:
 cd991ff7e7abce55cc6d8b3d329b1b233b0b2e45 2728 
prometheus-node-exporter_0.18.1+ds-2.dsc
 009c366d5973779b680cee5b796e08b1bad06952 13348 
prometheus-node-exporter_0.18.1+ds-2.debian.tar.xz
 7ba73fe4f86ea2ea74c87c74e4bb855ddbf21d35 8919 
prometheus-node-exporter_0.18.1+ds-2_amd64.buildinfo
Checksums-Sha256:
 bbee331cd43c51f9ce3cff4621ddd7b7229ca6019570dc7263f18bff37b8b9ea 2728 
prometheus-node-exporter_0.18.1+ds-2.dsc
 ad254adace8607e9c9a22bcdce4442b9b830d12b9bf015abf8dd1ad3818d3771 13348 
prometheus-node-exporter_0.18.1+ds-2.debian.tar.xz
 f454c00df7f8368fb97399b61644dda90e3383e3268f0def7ec4127245eedacb 8919 
prometheus-node-exporter_0.18.1+ds-2_amd64.buildinfo
Files:
 50d44806081134542d58e6fab7786e84 2728 net optional 
prometheus-node-exporter_0.18.1+ds-2.dsc
 749075d9b4fad9162349dc0755e117a9 13348 net optional 
prometheus-node-exporter_0.18.1+ds-2.debian.tar.xz
 cd9a7e8a10f196687681fd1926fb728c 8919 net optional 
prometheus-node-exporter_0.18.1+ds-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE2qbv8cYn6hwmsaaSqiMPxF+MJ7EFAl5PdYIACgkQqiMPxF+M
J7EqfBAAvx8YTwCk/haKhifTqNhcYlLpL2byDVVD6FsFYDQytGPnD/M9ey4SEe+5
1IO1TKLL0rn2N6GwjZSC/iuDS6/ID6+TdG1hWHWJr+MoNqtVPkcBCg8ey0yrcSBP
f9NCxaQcrSD2jxMgoGYfS5ITpjnQ+lfS6CVK7Zlo58A005ftNYGp84SqtcnAuCqM
0H+Njg10+XMGIM6peGaTuab4GQgjiFBWzp/oJcXB8mxEGqrT9f8dMYoHmYqCTrvB
xsK9LxxnU9ErwW32wXAHScw0Xec+slUlvM4CKvwYN4bcwzu6kRtuI3lWrsEei9cp
N7BRAPRLiikDfEBE2HAYnGlGOBX+b7uhJaBeBJqCsVfbWsKSekAvcRJTn58h+Gs8
HE0HkDyNBnosPt5jXmKHsFLox4/EGgBP6q8VdoRgDfXsE7MpFycXI1Y2V1UD2Pwf
Iq8v64SfhHTfP3glBQem62AKGgO2cRvujKiozgA+c6Q1MOL6kT3oYbUhEI9ffFy1
JnRziuv27O1QYgeOaLq8CBisAo1FthbltLU9ehEGlBcAXJGUyv1F+dzef6AbXDvF
4tY2nu0D77hsx2CVo5faydV3mDCDUAexixubyp70haYlnQfsf5UHuU0A02avWLpv
KCKKv+LR2Y84X4utnEAtUTw9a5/9Ea1kY9keEwausIYdfA1KsvQ=
=i3Lg
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to