Your message dated Sun, 01 Mar 2020 01:19:13 +0000
with message-id <[email protected]>
and subject line Bug#947048: fixed in acl 2.2.53-6
has caused the Debian Bug report #947048,
regarding acl: Please make autopkgtests cross-test-friendly
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
947048: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=947048
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: acl
Version: 2.2.53-5
Severity: minor
Tags: patch
User: [email protected]
Usertags: origin-ubuntu focal ubuntu-patch
Hi Guillem,
In Ubuntu, we are in the process of moving the i386 architecture to a
compatibility-only layer on amd64, and therefore we are also moving our
autopkgtest infrastructure to test i386 binaries in a cross-environment.
This requires changes to some tests so that they are cross-aware and can do
the right thing.
The acl tests currently fail in this environment, because they are build
tests that do not invoke the toolchain in a cross-aware manner. I've
verified that the attached patch lets the tests successfully build (and run)
i386 tests on an amd64 host. The "flaky" tests actually fail with or
without this patch, because the upstream test runner relies on an ld preload
of a just-built .so, but since these tests are flaky I don't consider it a
blocker.
Note that upstream autopkgtest doesn't currently set DEB_HOST_ARCH so this
is a complete no-op in Debian for the moment. Support for cross-testing in
autopkgtest is currently awaiting review at
https://salsa.debian.org/ci-team/autopkgtest/merge_requests/69 and once
landed, will still have no effect unless autopkgtest is invoked with a '-a'
option. So this change should be safe to land in your package despite this
not being upstream in autopkgtest.
Thanks for considering,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru acl-2.2.53/debian/tests/test-build acl-2.2.53/debian/tests/test-build
--- acl-2.2.53/debian/tests/test-build 2019-02-28 17:31:41.000000000 -0600
+++ acl-2.2.53/debian/tests/test-build 2019-12-19 15:51:52.000000000 -0600
@@ -5,6 +5,12 @@
set -u
set -x
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+ CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+ CROSS_COMPILE=
+fi
+
cd "$AUTOPKGTEST_TMP"
cat >example.c <<'EOF'
#include <sys/types.h>
@@ -29,10 +35,10 @@
}
EOF
-gcc -o example example.c $(pkg-config --libs libacl)
+${CROSS_COMPILE}gcc -o example example.c $(${CROSS_COMPILE}pkg-config --libs
libacl)
test -x ./example
./example
-gcc -o example-static example.c $(pkg-config --static --libs libacl)
+${CROSS_COMPILE}gcc -o example-static example.c $(${CROSS_COMPILE}pkg-config
--static --libs libacl)
test -x ./example-static
./example-static
diff -Nru acl-2.2.53/debian/tests/test-func acl-2.2.53/debian/tests/test-func
--- acl-2.2.53/debian/tests/test-func 2019-03-01 06:43:07.000000000 -0600
+++ acl-2.2.53/debian/tests/test-func 2019-12-19 15:52:04.000000000 -0600
@@ -2,6 +2,12 @@
set -e
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+ CROSS_COMPILE="--host=$DEB_HOST_GNU_TYPE"
+else
+ CROSS_COMPILE=
+fi
+
autoreconf -f -i 2>&1
-./configure
+./configure ${CROSS_COMPILE}
make check 2>&1
diff -Nru acl-2.2.53/debian/tests/test-func-root
acl-2.2.53/debian/tests/test-func-root
--- acl-2.2.53/debian/tests/test-func-root 2019-03-01 06:43:09.000000000
-0600
+++ acl-2.2.53/debian/tests/test-func-root 2019-12-19 15:52:04.000000000
-0600
@@ -2,6 +2,12 @@
set -e
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+ CROSS_COMPILE="--host=$DEB_HOST_GNU_TYPE"
+else
+ CROSS_COMPILE=
+fi
+
autoreconf -f -i 2>&1
-./configure
+./configure ${CROSS_COMPILE}
make check 2>&1
--- End Message ---
--- Begin Message ---
Source: acl
Source-Version: 2.2.53-6
Done: Guillem Jover <[email protected]>
We believe that the bug you reported is fixed in the latest version of
acl, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Guillem Jover <[email protected]> (supplier of updated acl package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 01 Mar 2020 02:06:51 +0100
Source: acl
Architecture: source
Version: 2.2.53-6
Distribution: unstable
Urgency: medium
Maintainer: Guillem Jover <[email protected]>
Changed-By: Guillem Jover <[email protected]>
Closes: 612599 947048 949688
Changes:
acl (2.2.53-6) unstable; urgency=medium
.
* Redirect stderr to stdout globally in autopkgtests instead of doing
that per command.
* Enable set -x and -u in autopkgtests.
* Add support for cross-compilation to autopkgtests. Closes: #947048
* Update upstream email address. Closes: #949688
* Fix usage of uninitialized variable in getfacl. Closes: #612599
Thanks to Vasily Gurevich <[email protected]>.
* Switch to Standards-Version 4.5.0 (no changes needed).
Checksums-Sha1:
6d79b0a257d9303df70319b9c92e48b73b4a4d4a 2336 acl_2.2.53-6.dsc
887d7fb033169b63dd6b1d8942f65ba2100e65b7 25108 acl_2.2.53-6.debian.tar.xz
f216c05afc5277a2f42596406e406f86db762e46 6428 acl_2.2.53-6_amd64.buildinfo
Checksums-Sha256:
02dad794aa09133e557552d75568324ed3e84fb56e93626e67993cf54a97df34 2336
acl_2.2.53-6.dsc
c80e6150d9b213e52f5e65ff78d4ee95a71b5a258c1f8b980365d20ed1753a5c 25108
acl_2.2.53-6.debian.tar.xz
6020b9872fa965287831b0637104e4df9e3dc44179ed2d77a8dd887ef3ecadad 6428
acl_2.2.53-6_amd64.buildinfo
Files:
aa0b2cc56da3e41676b4f1d54ef3d205 2336 utils optional acl_2.2.53-6.dsc
12bc35caf8da6ff8b4e79cea7cefea19 25108 utils optional
acl_2.2.53-6.debian.tar.xz
971d4e3d09742244a2ab9185cc0181d5 6428 utils optional
acl_2.2.53-6_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEETz509DYFDBD1aWV0uXK/PqSuV6MFAl5bDCMACgkQuXK/PqSu
V6O2hg/+IfkrJbpa+WkCtLlAnqfoOfNlA7vNK3gSxalE9rQLs/1bTY1Zf0st97eS
wLAbEkcSgI8/rzKBv0i92LjVSQTQ2ssR2MY6J5dtpjJOqZhNj77LbaP/mQPqiBkt
fnH5ircIeT3W698m01Bj8mixydkRTKwFLzj7xm/OjsQVHt+qtSTX/9r+mZ9iQmEx
eJ0+OQ051tNo8Btp6lNl+AZNSo9oqgJsJipVg0y/FBb1HM7l4KURWw7Y8vSgRgZH
PcDvuOY2KZT2mNToACS7dhgY49MQTsAoJZR/43RfWNRi95sXohJoobmP/B8BU8Yk
t6/PgonKSDfXJcddnVJb2UZf8bYqJ+dxPz8z09grMwJ2GOQhKPZFjUciJm++b/YK
MfZDAQtMfMnNldB/TfNCblbcfRA9PrneJ2TfFo/kV44/BT2ZgqloSMYMgNW/0XXi
AHv2+wHgz+Xcpwwb9stClR1XdJu6kiKXAunETKsVtZeZr7AjvdaohlEPVrvgD/su
akeXsIKXAoeXw530zFLpBY4SBWaThc2OyuIfrCuYlBH59NKXJu+FzhOkEQ39x4HH
8uPvCGdPnyWgTyygKfoWH4IyHeuJfJnPPOmhE+tExzWv1mET9D7IW1GCh0eKhkKi
m9A4FXgkCUOmNr1r8lLynoA9WAcoubEzblYR6sn7P4kT5rmqaGc=
=E75W
-----END PGP SIGNATURE-----
--- End Message ---
