Your message dated Sun, 26 Apr 2020 14:47:12 +0000
with message-id <[email protected]>
and subject line Bug#955635: fixed in purple-discord 
0.9.2019.02.07.git.e5d9627-1+deb10u1
has caused the Debian Bug report #955635,
regarding purple-discord: Crashes in ssl_nss_read
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
955635: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=955635
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: purple-discord
Version: 0.9.2020.03.10.git.4e71974-1
Severity: important

Hello,

I have been using purple-discord permanently in the past couple weeks,
and I have been hit by a crash several times:

#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007f94a4dd655b in __GI_abort () at abort.c:79
#2  0x000055d5cf6bbe6c in sighandler (sig=<optimized out>) at 
././pidgin/gtkmain.c:179
#3  sighandler (sig=<optimized out>) at ././pidgin/gtkmain.c:162
#4  0x00007f94a4dec7e0 in <signal handler called> () at 
/lib/x86_64-linux-gnu/libc.so.6
#5  0x00007f949fb2a4a5 in ssl_nss_read (gsc=0x55d5d0d3ae30, 
data=0x55d5d0d3ab40, len=1) at ././libpurple/plugins/ssl/ssl-nss.c:532
#6  0x00007f949faf8a33 in discord_socket_got_data (userdata=0x55d5d0d3aad0, 
conn=0x55d5d0d3ae30, cond=<optimized out>) at libdiscord.c:4501
#7  0x000055d5cf6a31e2 in pidgin_io_invoke (source=<optimized out>, 
condition=<optimized out>, data=0x55d5d148e6f0) at ././pidgin/gtkeventloop.c:73
#8  0x00007f94a52704de in g_main_dispatch (context=0x55d5d066a750) at 
../../../glib/gmain.c:3309
#9  g_main_context_dispatch (context=context@entry=0x55d5d066a750) at 
../../../glib/gmain.c:3974
#10 0x00007f94a5270890 in g_main_context_iterate (context=0x55d5d066a750, 
block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at 
../../../glib/gmain.c:4047
#11 0x00007f94a5270b63 in g_main_loop_run (loop=0x55d5d0d3b0a0) at 
../../../glib/gmain.c:4241
#12 0x00007f94a574c12a in IA__gtk_main () at ../../../../gtk/gtkmain.c:1270
#13 0x000055d5cf668970 in main (argc=<optimized out>, argv=<optimized out>) at 
././pidgin/gtkmain.c:939
(gdb) frame 5
#5  0x00007f949fb2a4a5 in ssl_nss_read (gsc=0x55d5d0d3ae30, 
    data=0x55d5d0d3ab40, len=1) at ././libpurple/plugins/ssl/ssl-nss.c:532
532     ././libpurple/plugins/ssl/ssl-nss.c: Aucun fichier ou dossier de ce 
type.
(gdb) p gsc->private_data
$4 = (void *) 0x0

I have never had such issue in the past years with pidgin, so it very
most probably is due to the discord plugin (and the backtrace suggests
so too)

It seems that somehow discord_socket_got_data passes an improper
connection, I used the attached browntape patch in pidgin to at least
avoid the issue by returning an error instead of crashing my whole
pidgin.

Samuel

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldstable-proposed-updates-debug'), (500, 
'oldstable-proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), 
(500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 
'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.5.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages purple-discord depends on:
ii  libc6               2.30-2
ii  libglib2.0-0        2.64.1-1
ii  libjson-glib-1.0-0  1.4.4-2
hi  libpurple0          2.13.0-2.2+fix

And additionally:

ii  pidgin              2.13.0-2.2+fix amd64        graphical multi-protocol in>
ii  pidgin-data         2.13.0-2.2+fix all          multi-protocol instant mess>
ii  pidgin-dbgsym       2.13.0-2.2+fix amd64        debug symbols for pidgin

purple-discord recommends no packages.

Versions of packages purple-discord suggests:
pn  python3-harmony  <none>

-- no debconf information
---
 libpurple/plugins/ssl/ssl-nss.c |    8 ++++++++
 1 file changed, 8 insertions(+)

--- a/libpurple/plugins/ssl/ssl-nss.c
+++ b/libpurple/plugins/ssl/ssl-nss.c
@@ -529,10 +529,18 @@ ssl_nss_read(PurpleSslConnection *gsc, v
        PRInt32 ret;
        PurpleSslNssData *nss_data = PURPLE_SSL_NSS_DATA(gsc);
 
+       if (!nss_data)
+       {
+               ret = -1;
+               errno = EFAULT;
+       }
+       else
+       {
        ret = PR_Read(nss_data->in, data, len);
 
        if (ret == -1)
                set_errno(PR_GetError());
+       }
 
        return ret;
 }

--- End Message ---
--- Begin Message ---
Source: purple-discord
Source-Version: 0.9.2019.02.07.git.e5d9627-1+deb10u1
Done: Paul Wise <[email protected]>

We believe that the bug you reported is fixed in the latest version of
purple-discord, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Paul Wise <[email protected]> (supplier of updated purple-discord package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 26 Apr 2020 17:47:55 +0800
Source: purple-discord
Architecture: source
Version: 0.9.2019.02.07.git.e5d9627-1+deb10u1
Distribution: buster
Urgency: medium
Maintainer: Paul Wise <[email protected]>
Changed-By: Paul Wise <[email protected]>
Closes: 955635
Changes:
 purple-discord (0.9.2019.02.07.git.e5d9627-1+deb10u1) buster; urgency=medium
 .
   * Backport workaround for crashes in ssl_nss_read (Closes: #955635)
Checksums-Sha1:
 52758151d5b344fe90ee70383464b4151dae4cd4 2031 
purple-discord_0.9.2019.02.07.git.e5d9627-1+deb10u1.dsc
 9323f2f2d7426aaffe6581ef6b21df96bcaf7601 2916 
purple-discord_0.9.2019.02.07.git.e5d9627-1+deb10u1.debian.tar.xz
Checksums-Sha256:
 78ee5dc2917c1936cb18ab3f70a5cd5c7a0bb30b94ce490b99d6d5d6338b295b 2031 
purple-discord_0.9.2019.02.07.git.e5d9627-1+deb10u1.dsc
 2ae3c963396d22e2d0b7200c6a4b4c5d35505030260f7f9087e01146ff4d46fe 2916 
purple-discord_0.9.2019.02.07.git.e5d9627-1+deb10u1.debian.tar.xz
Files:
 536c7c9a746dee68889445379357e558 2031 net optional 
purple-discord_0.9.2019.02.07.git.e5d9627-1+deb10u1.dsc
 05d262b8be5a9c1b3215fa77a487de33 2916 net optional 
purple-discord_0.9.2019.02.07.git.e5d9627-1+deb10u1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEYQsotVz8/kXqG1Y7MRa6Xp/6aaMFAl6lXjIACgkQMRa6Xp/6
aaPtyQ//RLWK/UGXscqcVH1w/k60FmfyY2AwBGg9+AcBAYFLr2h++V5kWXnnNLsb
mg3XYHGI/Gz+tggPsjOBuk4wHOHa6genGUinliRi+W7Zo7cFugbqsBLqS4yFF4l9
2G09RiAtAVx8K7HPr7LNE4JQ1SYMnxuMATa2xmPAhG3WhM5AWAWOMzWdPT9GFiCE
JvYeqUegJ0PVRcoVb4UoBw+fPWn5CN3IhZICZGqgGhlFJhyhnxe4d65ydXcq5VDv
QUSu64Hw6GBuevDd0sb70UZKie9H6omqbsE0nkSsOxMMKH9esbu0UkbM98YiqQXn
AFZ48+I0OFVqBFV9CgD+MaUvpl4RcBCLh6nlbt8WmXqqpXWKZpSKZ4cWu6lWNfvg
dMofDsd8QiVDkNku+j8RZwyGnKicS3PekbOteBzXZINOopy5JJne9qrrtQ/igEqL
yUD5ojzZTUXEZtLPzMnALTexAKutxEMH7GxRznvZ0D0nhST+xW+3zm++xOeBJA1D
QRQXpwdnh1p7Xobpmyn0MpgzrFdJIcgLbkvJ+Uh8mZLgQ3JpKG2HJ6U5ARC7ylz8
w+SFbDJeAYp1/dSJFNOaIXXrCFGl9lIEEcD/r5QRpNV1CnQu3090nuXuTH0sg1B+
fKOGEksupzAiKEPXOgDNlDNYJGRddR1orQUDVLVRNVPbXwncZXE=
=tThr
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to