Your message dated Mon, 15 Jun 2020 23:33:33 +0000 with message-id <[email protected]> and subject line Bug#960441: fixed in pciutils 1:3.7.0-1 has caused the Debian Bug report #960441, regarding pciutils: consider adding a superficial autopkgtest for the -dev package to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 960441: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=960441 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Source: pciutils Version: 1:3.6.4-1 Severity: wishlist Tags: patch While backporting the solution for #721270 into a Debian derivative, I added the attached autopkgtest to verify that the -dev package works correctly. I've found that tests like this are a useful way to automate checks that development files are packaged correctly: even though they don't have significant coverage of the actual library code, they can detect common mistakes like missing header files, wrong search paths, and missing dependencies on other -dev packages referenced by the pkg-config file. smcv>From 1468841c3285ce7c42673e1639a52129ce372254 Mon Sep 17 00:00:00 2001 From: Simon McVittie <[email protected]> Date: Tue, 12 May 2020 14:20:26 +0100 Subject: [PATCH] Add a superficial compile/link/execute autopkgtest for libpci-dev Signed-off-by: Simon McVittie <[email protected]> --- debian/tests/control | 3 +++ debian/tests/libpci-dev | 38 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+) create mode 100644 debian/tests/control create mode 100755 debian/tests/libpci-dev diff --git a/debian/tests/control b/debian/tests/control new file mode 100644 index 0000000..1f2d981 --- /dev/null +++ b/debian/tests/control @@ -0,0 +1,3 @@ +Tests: libpci-dev +Restrictions: allow-stderr, superficial +Depends: build-essential, libpci-dev, pkg-config diff --git a/debian/tests/libpci-dev b/debian/tests/libpci-dev new file mode 100755 index 0000000..60b343b --- /dev/null +++ b/debian/tests/libpci-dev @@ -0,0 +1,38 @@ +#!/bin/sh +# Copyright 2020 Collabora Ltd. +# SPDX-License-Identifier: GPL-2.0-or-later + +set -eux + +if [ -n "${AUTOPKGTEST_ARTIFACTS-}" ]; then + WORKDIR="$AUTOPKGTEST_ARTIFACTS" +else + WORKDIR="$(mktemp -d)" + trap 'cd /; rm -fr "$WORKDIR"' 0 INT QUIT ABRT PIPE TERM +fi + +if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then + CROSS_COMPILE="$DEB_HOST_GNU_TYPE-" +else + CROSS_COMPILE= +fi + +cd "$WORKDIR" + +cat <<EOF > sample.c +#include <pci/pci.h> + +int main(void) +{ + struct pci_access *a; + a = pci_alloc(); + pci_init(a); + pci_cleanup(a); + return 0; +} +EOF + +# Deliberately word-splitting pkg-config's output: +# shellcheck disable=SC2046 +"${CROSS_COMPILE}gcc" -osample sample.c $("${CROSS_COMPILE}pkg-config" --cflags --libs libpci) +./sample -- 2.26.2
--- End Message ---
--- Begin Message ---Source: pciutils Source-Version: 1:3.7.0-1 Done: Guillem Jover <[email protected]> We believe that the bug you reported is fixed in the latest version of pciutils, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Guillem Jover <[email protected]> (supplier of updated pciutils package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Tue, 16 Jun 2020 00:59:33 +0200 Source: pciutils Architecture: source Version: 1:3.7.0-1 Distribution: unstable Urgency: medium Maintainer: Guillem Jover <[email protected]> Changed-By: Guillem Jover <[email protected]> Closes: 960441 Changes: pciutils (1:3.7.0-1) unstable; urgency=medium . * New upstream release. * Switch to debhelper compatibility level 13. - Stop passing --add-udeb to dh_makeshlibs. - Stop passing ChangeLog to dh_installchangelogs. * Adapt to renamed lintian tag exit-in-shared-library. * Remove unneeded update-pciids.sh patched changes, due to the simplifications on the previous release. * Pass OPT to make via the conffiles environment variable instead of explicitly passing it prefixed to the command. * Do not build a static library anymore. This does not work on Linux systems anyway as libudev-dev does not provide a static library, and providing one for non-Linux systems would make handling this inconsistent in depending packages. In addition newer glibc generate a link-time warning on code using getpwuid() calls, requesting to use the dynamic library version. * Split the License text into its own License stanza in debian/copyright. * Add a superficial test case. Closes: #960441 Based on a patch by Simon McVittie <[email protected]>. * Install pci.ids(5) in pciutils. * List /usr/share/misc/pci.ids.gz explicitly in pciutils-udeb.install so that dh_missing knows about it. * Switch to the dh sequencer. Checksums-Sha1: 56b6df6ad02a34d82bbe47940e10223a787d597a 2515 pciutils_3.7.0-1.dsc faf65ed0452c85414206f04d2ed40a7b504fb911 516418 pciutils_3.7.0.orig.tar.gz e351221add098847b067d347b703134548d4d66f 833 pciutils_3.7.0.orig.tar.gz.asc 153446d5e28225936cc0f636fddbc9ddef5f462f 21048 pciutils_3.7.0-1.debian.tar.xz cfdb1bbe5b0dcc0862287342f4fe8f13fc4b4d2d 7015 pciutils_3.7.0-1_amd64.buildinfo Checksums-Sha256: 0da94e305ce1c4209d4281e89f2a4679f1ae345dd50e130cda62096703130d4e 2515 pciutils_3.7.0-1.dsc 08c27e01030d1fcc700d02bc2ea66c638f58a3d150e45e58852aa82ad4160d84 516418 pciutils_3.7.0.orig.tar.gz f1c3ef27541bba787c1a12d96580cf4df0c169783b12eea5ca36717970eeba6b 833 pciutils_3.7.0.orig.tar.gz.asc d890434cbf827bd04f416e87effe3ce2121f4d94af7f0335858df42d29798349 21048 pciutils_3.7.0-1.debian.tar.xz e07f4316b90f004d041eed22c035bd6ee2a504e08fd7950fd191852cccade09b 7015 pciutils_3.7.0-1_amd64.buildinfo Files: 5ffbdfa0f51c6250a208a2b911394160 2515 admin optional pciutils_3.7.0-1.dsc 51554c538b5a57b61123326e14ea28a1 516418 admin optional pciutils_3.7.0.orig.tar.gz 7f714d692ae5f197b6bd2cdaec1a909b 833 admin optional pciutils_3.7.0.orig.tar.gz.asc 4b73fbd798dfaf89568128905f16f45c 21048 admin optional pciutils_3.7.0-1.debian.tar.xz 967e59631fd12f024ece9d947175a2c9 7015 admin optional pciutils_3.7.0-1_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEETz509DYFDBD1aWV0uXK/PqSuV6MFAl7oAZ4ACgkQuXK/PqSu V6NT/hAAsDTDON8HVXWRKjqILglWvS+fSwaEsPNiPk1a9EJaezAlR6K2ryYR/npX OCLfnBdp0cIjiHGatPxzrj5NxgOGyeOyl9ZnHQtV12jpD4zYKb/HsLneIFfqpGjL WghyQTPHTO/TeL/xw24kIaqoA7KixyGiyWpkOcABOlUuPQoJRPXMPv/DAMZvsv8V oJaMwuHfOtYOu15egPO+GEu401O2QNDnc1Vypc3FsrB4GA02FVkxwoHrJq4MVwjL BQVpBWLJTOSpKcmH4j2EBe6LXsAw+251yyzEDKy0R8xWPNm4eaKUCsEWeMDLufNM yRdhNrldZhl49xVPeHJj1uNxeTTvEVpH4eAqHlJd4JrBelV9PuKSghDeE3VaZ2eW /qchX4ZEYmYso8mSyAvDPQKhaK//QgdXfrwHOokiww1WgWTVxo3btwHuVYQ5NvXS PnayViQcEXkCpBv/PwJxtytzcLHXJtLqeaGExYcQ2mAXWXHpC5ve6DXiV6WiWfyc +406N8Jto10aBZGoOVqS3tSPVFLbbhO5fCJe+wJScnxsHPwRbdUmxy6dB1Bvjdty l0Zd4KugazU4ZfpXBvR1V/fpJoDzhdnH+/FtZY4z1C8ujVEvjlIhiRuVcWkteoi8 XlfO1SBgnLt4ASeO/vlch8BxL1SLwUXnUMDt3yrICSABeRGFBN4= =QD6L -----END PGP SIGNATURE-----
--- End Message ---
