Your message dated Sat, 04 Jul 2020 08:48:33 +0000
with message-id <[email protected]>
and subject line Bug#963954: fixed in ndcube 1.3.2-2
has caused the Debian Bug report #963954,
regarding ndcube: test failure with new sunpy
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
963954: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=963954
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: ndcube
Version: 1.3.2-1
Severity: serious
Tags: patch

Hi Vincent,

I just uploaded the new sunpy version, and this unfortunately breaks the
ndcube testing due to a missing dependency:

Sunpy no longer strongly depends on parfive, only recommends it. The
tests however require them (even when they actually can't download
data), so it must be explicitly added as build+test dependency.

I created a patch which is attached, and I also for convenience created
a merge request for it
<https://salsa.debian.org/debian-astro-team/ndcube/-/merge_requests/2>

Additionally, the patch fixes the CI command line: use the AUTOPKGTEST
instead of ADTMP environment variable, and directly invoke pytest
instead of using a sommand line Python script.

Severity is set to "serious", since ndcube now FTBFS.

Best

Ole
>From e80151a13ed14e48110c0b9ed1510a0df8429545 Mon Sep 17 00:00:00 2001
From: Ole Streicher <[email protected]>
Date: Mon, 29 Jun 2020 09:34:50 +0200
Subject: [PATCH] Add parfive to the test dependencies

Sunpy no longer strongly depends on parfive, only recommends it. The
tests however require them (even when they actually can't download
data), so it must be explicitly added as build+test dependency.

Additionally, the patch fixes the CI command line: use the AUTOPKGTEST
instead of ADTMP environment variable, and directly invoke pytest
instead of using a sommand line Python script.
---
 debian/control       | 1 +
 debian/tests/control | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 8687225..07531eb 100644
--- a/debian/control
+++ b/debian/control
@@ -10,6 +10,7 @@ Build-Depends: debhelper (>= 12),
                python3-all,
                python3-astropy,
                python3-astropy-helpers,
+               python3-parfive,
                python3-pytest,
                python3-setuptools,
                python3-setuptools-scm,
diff --git a/debian/tests/control b/debian/tests/control
index 6a2e1da..dbecc28 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -1,4 +1,6 @@
-Test-Command: cd $ADTTMP && python3 -c "import ndcube; import pytest; exit(pytest.main(ndcube.__path__))"
+Test-Command: cd $AUTOPKGTEST_TMP && python3 -m pytest --pyargs ndcube
 Depends: python3-ndcube,
+         python3-parfive,
+         python3-pytest,
          python3-tk
 Restrictions: allow-stderr
-- 
2.27.0


--- End Message ---
--- Begin Message ---
Source: ndcube
Source-Version: 1.3.2-2
Done: Vincent Prat <[email protected]>

We believe that the bug you reported is fixed in the latest version of
ndcube, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vincent Prat <[email protected]> (supplier of updated ndcube package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 04 Jul 2020 09:08:25 +0200
Source: ndcube
Architecture: source
Version: 1.3.2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Astro Team <[email protected]>
Changed-By: Vincent Prat <[email protected]>
Closes: 963954
Changes:
 ndcube (1.3.2-2) unstable; urgency=medium
 .
   * Add parfive to the test dependencies (Closes: #963954)
   * Bump debhelper compatibility version to 13
   * Change back to the older maintainer email address
Checksums-Sha1:
 4e5030e616218363164a15d6f8b9cc995b76dc2f 2370 ndcube_1.3.2-2.dsc
 c6ba122255a1cc6746b4c177eb865536562f0e55 9224 ndcube_1.3.2-2.debian.tar.xz
 3edaddf87444d87e1da8a7a7ce81809a5644d7d6 12226 ndcube_1.3.2-2_amd64.buildinfo
Checksums-Sha256:
 b5491117e84754c3ecf38a811d6177f4260402d636c82d4468f9251409d4a02c 2370 
ndcube_1.3.2-2.dsc
 d357d05b17c5c025a09bc8b5c5fb94514f63b1f804e8aa1275395f4f141b66e3 9224 
ndcube_1.3.2-2.debian.tar.xz
 cc391f18750d2f68cc9fc67d80d99abda5db111ed3b6044ff218d3033c5baaac 12226 
ndcube_1.3.2-2_amd64.buildinfo
Files:
 5d05d483cd93862442393806f635511a 2370 python optional ndcube_1.3.2-2.dsc
 5b7f6f26979e667f66429db8a13259a0 9224 python optional 
ndcube_1.3.2-2.debian.tar.xz
 4aab9e2c0fa55b2be3662b324989260e 12226 python optional 
ndcube_1.3.2-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEEwN+g0Kj2VQgeB/icBzHNjq6Fm38FAl8APbsQHHZpdmlAZGVi
aWFuLm9yZwAKCRAHMc2OroWbfyyZD/99rMJQ0eBexc3OXmODfXSAGTwjd3M7oCLZ
1xiRVmth7gV7+iEZFUoYKhCIGF/O1Hvgz5Tdo1L9IPTcb++kD8J6fPog3CKPAqZZ
hZcM5Ea6mbfDe5xO6oSAtFaAtkW40wQ6CK6mIFAUV1d/pc6OyX+5x9RkoYa+zrIm
bGTGjmatj5G2xuILEgw+lzOFl4yHIVncfmN6dWO4EEY6q4Ib1A3cUJRvKDGZu25d
eNpk/H3j7Go6675Zq9VLGGXEUWAbVvZHmADiKjjnuCrDbQtlVLiHZ8ZGkJ2fCuL+
nOMgksOBadKrPp0zWhvSZLBSaFUjKzaf5EL8FbV028wVYuTmeWRKkxqiZu49kMwt
7M2uLVymaMUT0a47x6jszlyDx7V3/iPKbRtqhEehgi8xPKwzteBBz2jtIb8cSC6j
GGfXLDkA7y6XRK/TUhoiaMa+UyDybgXfDiEcvB4gHAVI+W0CF0lx0KXNfkF9Uavc
vkZD7eEShUL8Pj7TBHFVEDitFoV8JUby/kxsfxcTNgZVrEAcqL5GI6rb38yLji/9
v2VsLdFfaCW1JytzY3kqyByhPPEOdfgcq3kwWLvlpdrg1pWkt5WN4Czkdt+w/kSV
AGjSmNdu9+Yxv22AT0m8C/2RvYjOzP4NnFuHCnQIzXxQ9SkAnI77v1+yL9HI7mDV
s99IYXFwrg==
=mfVF
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to