Your message dated Tue, 11 Aug 2020 10:34:39 +0000
with message-id <[email protected]>
and subject line Bug#857971: fixed in xjdic 24-11
has caused the Debian Bug report #857971,
regarding xjdic: Eventually segfaults after EOF
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
857971: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857971
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: xjdic
Version: 24-10
Severity: normal
Tags: patch
$ xjdic < /dev/null > /dev/null
Segmentation fault
xjdic never checks the result of getchar() against EOF, resulting in an
infinite loop, which eventually segfaults.
The simplest solution is to check and exit in getcharxx(), before the
result is cast to an unsigned integer.
-- System Information:
Debian Release: 9.0
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.9.0-2-amd64 (SMP w/3 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
>From 5a636e5298cb55b57b766f75f2f7f94dd19d7154 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Bri=C3=A8re?= <[email protected]>
Date: Thu, 16 Mar 2017 15:24:31 -0400
Subject: [PATCH] Exit on EOF
---
xjdfrontend.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/xjdfrontend.c b/xjdfrontend.c
index 2104c3d..0e0eabc 100644
--- a/xjdfrontend.c
+++ b/xjdfrontend.c
@@ -305,7 +305,12 @@ int getcharxx()
}
else
{
- return(getchar());
+ int c = getchar();
+ if (c == EOF)
+ {
+ exit(0);
+ }
+ return(c);
}
}
/*====GetWinSize==== Hank Cohen's routine for getting the (new) window size==*/
--
2.11.0
--- End Message ---
--- Begin Message ---
Source: xjdic
Source-Version: 24-11
Done: Ludovic Drolez <[email protected]>
We believe that the bug you reported is fixed in the latest version of
xjdic, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Ludovic Drolez <[email protected]> (supplier of updated xjdic package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 10 Aug 2020 12:04:46 +0200
Source: xjdic
Architecture: source
Version: 24-11
Distribution: unstable
Urgency: medium
Maintainer: Ludovic Drolez <[email protected]>
Changed-By: Ludovic Drolez <[email protected]>
Closes: 853797 857968 857971 957985 965903
Changes:
xjdic (24-11) unstable; urgency=medium
.
* Thanks to Frederic Briere for all the following patches
* GCC-10 patch. Closes: #957985
* patch: May crash on long definitions when looking up plain form verbs.
Closes: #853797
* patch: Does not display spaces in definitions past 80 columns.
Closes: #857968
* patch: Eventually segfaults after EOF. Closes: #857971
* patch: Removal of obsolete debhelper compat 5 and 6 in bookworm.
Closes: #965903
Checksums-Sha1:
45b4eff1ae69834e640970ca86cd9f67b4b10b11 1277 xjdic_24-11.dsc
aefb334f296f0266c0343f47b921eb55a3dee4f4 11213 xjdic_24-11.diff.gz
4fba8474e09033872e5ff7c69491c66e2b016ac6 5771 xjdic_24-11_amd64.buildinfo
Checksums-Sha256:
e4fc4590cb0e10582a68823a8c114e1acf3a4c6b005b87a2a02a074aea069af8 1277
xjdic_24-11.dsc
4bb0a65f043a1a1e66cfd25b9479ff474cbc4f59b3e95d4d59d844aa950df1db 11213
xjdic_24-11.diff.gz
9a85d8b269661b92be7805786de8f9fb7b1046ae155ce3c84632ddb9c3a48c6b 5771
xjdic_24-11_amd64.buildinfo
Files:
28dd1c0a5dbeb248dcc8c0b8952b645c 1277 text optional xjdic_24-11.dsc
b4bee5a415f058e1f0424c81f8339fcf 11213 text optional xjdic_24-11.diff.gz
867c2ca948c2d756cf21c272911a6138 5771 text optional xjdic_24-11_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQFHBAEBCAAxFiEEKrWNbKjxjlSqtxlZi3UoEkf5wXwFAl8ybAETHGxkcm9sZXpA
ZGViaWFuLm9yZwAKCRCLdSgSR/nBfDZTB/0TOpTEAbFiM3/0Bv0fXaEY56AJGxUL
3S+ooC/hKOzhhejujUe3uv7k1mDh5prDOHu7YDjwmwwQ6H43VxRDU/nu4y3oUvAR
/SG9vZdFrXo7K7XQX1HQASaEUUPNp2Ai1FbZSmZwhItKiWAv2AvQTV6Cs+63CuHS
69RrpNLEuSJIllHUCCrD4D58XHlNKPSzn5Qdy2t6UdBrN7KwuI052wmyaWQ7KC8y
88WL/7rOpcybItz5QAzqsfCkNEeafJl+6L4WW0pBuiibC82qEZfoEEDRdrOWrExi
4pp8vOobf32v+v25nht8G2Q8Hwf9iC/B7KMgcAX3uPBKhC8eFx+jPqCm
=aGAi
-----END PGP SIGNATURE-----
--- End Message ---
