Your message dated Thu, 17 Sep 2020 09:08:56 +0200
with message-id <[email protected]>
and subject line Re: [Pkg-libvirt-maintainers] Bug#970481: virt-manager fails
to create directory pools on ext4
has caused the Debian Bug report #970481,
regarding virt-manager fails to create directory pools on ext4
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
970481: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=970481
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libvirt
Version: 6.6.0-2
The virt-manager fails to create a new dir pool on ext4. The bug is
already fixed upstream as 2edd63a0dbd445112db23596ee0128521e8f1ff
From 2edd63a0dbd445112db23596ee0128521e8f1ff5 Mon Sep 17 00:00:00 2001
From: Jiri Denemark <[email protected]>
Date: Wed, 5 Aug 2020 10:01:45 +0200
Subject: [PATCH] util: Fix logic in virFileSetCOW
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
When COW is not explicitly requested to be disabled or enabled, the
function is supposed to do nothing on non-BTRFS file systems.
Fixes commit 7230bc95aa78379c9ee20cf59394c5fc4305b75b.
https://bugzilla.redhat.com/show_bug.cgi?id=1866157
Signed-off-by: Jiri Denemark <[email protected]>
Reviewed-by: Daniel P. Berrangé <[email protected]>
---
src/util/virfile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virfile.c b/src/util/virfile.c
index 6ada3a708c28..7f22884b07d6 100644
--- a/src/util/virfile.c
+++ b/src/util/virfile.c
@@ -4522,7 +4522,7 @@ virFileSetCOW(const char *path,
}
if (buf.f_type != BTRFS_SUPER_MAGIC) {
- if (state == VIR_TRISTATE_BOOL_ABSENT) {
+ if (state != VIR_TRISTATE_BOOL_ABSENT) {
virReportSystemError(ENOSYS,
_("unable to control COW flag on '%s', not btrfs"),
path);
--
2.28.0
pgptMJFAH5fTN.pgp
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---
Version: 6.7.0-1
Hi,
On Thu, Sep 17, 2020 at 04:12:06AM +0200, Alexander 'lynxis' Couzens wrote:
> Package: libvirt
> Version: 6.6.0-2
>
> The virt-manager fails to create a new dir pool on ext4. The bug is
> already fixed upstream as 2edd63a0dbd445112db23596ee0128521e8f1ff
Already fixed in 6.7.0-1.
Cheers,
-- Guido
--- End Message ---
