Your message dated Sat, 19 Sep 2020 09:33:34 +0000
with message-id <[email protected]>
and subject line Bug#970359: fixed in ifupdown-extra 0.31
has caused the Debian Bug report #970359,
regarding ifupdown-extra: new style interface names are not correctly recognised
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
970359: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=970359
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ifupdown-extra
Version: 0.28
Severity: important
Tags: patch

Dear Maintainer,

00check-network-cable checks whether the interface it wants to check is an
ethernet interface and it will bail out if this is not the case.

It only checks for classic interface names (eth*, e.g. eth0) and not for new
style "predictable" interface names (enp*, e.g. enp0s31f6).


The "Configuration Files:" section of this report contains a patched version of
the config file. It has the following patch applied to fix the problem:

--- a/00check-network-cable     2020-09-15 09:18:03.105795364 +0200
+++ b/00check-network-cable     2020-09-15 09:41:07.803352174 +0200
@@ -145,7 +145,7 @@
 
 # Check our IFACE name, if it does not start with eth, bail out
 case $IFACE in
-       eth*)
+       enp* | eth*)
                check_status || [ "$ABORT_NO_LINK" != "yes" ] || exit 1
                ;;
        bond*)

-- System Information:
Debian Release: 10.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-10-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages ifupdown-extra depends on:
ii  bind9-host [host]            1:9.11.5.P4+dfsg-5.1+deb10u2
ii  curl                         7.64.0-4+deb10u1
ii  dpkg                         1.19.7
ii  iproute2                     4.20.0-2
ii  iputils-arping               3:20180629-2+deb10u1
ii  iputils-ping [ping]          3:20180629-2+deb10u1
ii  lsb-base                     10.2019051400
ii  net-tools                    1.60+git20180626.aebd88e-1
ii  netcat                       1.10-41.1
ii  netcat-traditional [netcat]  1.10-41.1

Versions of packages ifupdown-extra recommends:
ii  ethtool  1:4.19-1
ii  ndisc6   1.0.4-1

ifupdown-extra suggests no packages.

-- Configuration Files:
/etc/network/if-up.d/00check-network-cable changed:
rc="/etc/default/network-test"
ETHTOOL=/sbin/ethtool
alt_et=/usr/sbin/ethtool
[ -x "$ETHTOOL" ] || [ ! -x "$alt_et" ] || ETHTOOL=$alt_et
MIITOOL=/sbin/mii-tool
IPTOOL=/sbin/ip
DO_SYSLOG=yes
ABORT_NO_LINK=no
[ -r "$rc" ] && . "$rc"
if [ "$DO_SYSLOG" = yes ]; then
        OUTPUT="logger -i -p daemon.err -s"
else
        OUTPUT=echo
fi
LC_ALL=C
export LC_ALL
check_status_miitool() {
        local status=0
        if $MIITOOL "$IFACE" 2>&1 | grep -q "no link" ; then
                status=1
        fi
        return $status
}
check_status_ethtool() {
        local status=0
        local LINK="$($ETHTOOL "$IFACE" 2>&1 | grep "Link detected" 2>/dev/null 
|| :)"
        # If ethtool fails to print out the link line we break off
        # notice that ethtool cannot get the link status out of all
        # possible network interfaces
        [ -n "$LINK" ] || return 1
        if ! echo $LINK | grep -q "Link detected: yes" ; then
                status=1
        fi
        return $status
}
check_status_iplink() {
        local status=0
        local info=""
        [ -x "$IPTOOL" ] || return 0
        info=$($IPTOOL link show "$IFACE" 2>&1 | grep "$IFACE:" 2>/dev/null)
        if echo $info | grep -qE "NO-CARRIER|state DOWN|state LOWERLAYERDOWN" ; 
then
                status=1
        fi
        return $status
}
check_status() {
        local status=0 myid=$(id -u)
        ifconfig "$IFACE" >/dev/null 2>&1 || {
                $OUTPUT "ERROR: Interface $IFACE does not seem to be present" \
                        "in the system"
                return 0
        }
        # Use ethtool if installed (preferable to mii-tool)
        # If none are installed (or not running as root) we will test using
        # 'ip link show'
        if [ -x "$ETHTOOL" ] && [ $myid -eq 0 ]; then
                check_status_ethtool || status=$?
        elif [ -x "$MIITOOL" ] && [ $myid -eq 0 ]; then
                check_status_miitool || status=$?
        else
                check_status_iplink || status=$?
        fi
        [ $status -eq 0 ] ||
                $OUTPUT "WARNING: Initialising interface $IFACE which does" \
                        "not have a link"
        return $status
}
check_bond_status() {
        local status=1 inf slaves slave_iface
        slaves="/sys/class/net/$IFACE/bonding/slaves"
        [ -e "$slaves" ] || return 0
        # Loop over the list of slaves
        while read slave_ifaces; do
                for inf in $slave_ifaces; do
                        # Use ":" command to silence slaves. Run in subshell to 
preserve IFACE
                        (OUTPUT=: IFACE="$inf" check_status); status=$?
                        # One functional slave will suffice
                        [ $status -ne 0 ] || return 0
                done
        done <$slaves
        $OUTPUT "WARNING: Initialising bond $IFACE which does not have link" \
                "on any slave"
        return $status
}
[ "$IFACE" ] || {
    $OUTPUT "ERROR: Variable IFACE not set in environment"
    exit 1
}
case $IFACE in
        enp* | eth*)
                check_status || [ "$ABORT_NO_LINK" != "yes" ] || exit 1
                ;;
        bond*)
                check_bond_status || [ "$ABORT_NO_LINK" != "yes" ] || exit 1
                ;;
esac


-- no debconf information

--- End Message ---
--- Begin Message ---
Source: ifupdown-extra
Source-Version: 0.31
Done: =?utf-8?q?Javier_Fern=C3=A1ndez-Sanguino_Pe=C3=B1a?= <[email protected]>

We believe that the bug you reported is fixed in the latest version of
ifupdown-extra, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Javier Fernández-Sanguino Peña <[email protected]> (supplier of updated 
ifupdown-extra package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 19 Sep 2020 09:09:41 +0200
Source: ifupdown-extra
Architecture: source
Version: 0.31
Distribution: unstable
Urgency: medium
Maintainer: Javier Fernandez-Sanguino Peña <[email protected]>
Changed-By: Javier Fernández-Sanguino Peña <[email protected]>
Closes: 970359
Changes:
 ifupdown-extra (0.31) unstable; urgency=medium
 .
   * Fix some network scripts to adapt to the naming scheme introduced
     in v197 of systemd (in Debian 5 Lenny) in which Ethernet interfaces
     can be named 'enXXX' instead of 'ethXX'. This was preventing many
     scripts to work properly as they skipped interfaces that were not
     named 'ethXXX'. Thank you to Mart Lubbers for spotting this and providing
     a patch (Closes: 970359)
 .
     Scripts modified:
       - if-up-scripts/check-duplicate-ip and
         if-up-scripts/check-duplicate-ip6:
           * Replace the use of ETHTOOL with 'ip link xxx up' so it does not
             anymore need to be restricted to Ethernet addreses.
           * Do nothing if the interface is a serial line or WWAN interface,
             but work on any other interface as long as the conditions are met.
       - if-up-scripts/check-duplicate-ip6: Improve the logic to not report
         if the local link address reported by ndisc6 is the same as the
         link address of the interface (it appears to happen in my system
         in Wireless interfaces)
 .
       - if-up-scripts/check-gateway:
           * Replace the use of ETHTOOL with 'ip link xxx up'
           * Skip serial line interfaces as ARPPING will not work there
 .
       - if-up-scripts/check-network-cable:
           * Implement a generic test for all non-Ethernet and non-Bond
             interfaces just using 'ip link xxxx up'
           * Work with the new interface naming scheme ( en* | eth*) and
             restrict the use of ethtool or mii-tool to Ethernet interfaces
           * Make it possible to disable the script through configuration
             in /etc/default/network-test (DO_CABLETEST)
 .
        - scripts/network-test
           * Implement a generic test for all non-Ethernet
             interfaces just using 'ip link xxxx up'
           * Work with the new interface naming scheme ( en* | eth*) and
             restrict the use of ethtool or mii-tool to Ethernet interfaces
           * Replace the IPv4 lookup tool as it is not working anymore
           * Add Debug option (-v 4) to output all the information generated
             from the different commands analysed
           * Add a query to GeoIP API (only enabled if full debug is enabled)
 .
   * scripts/network-test:
      - Add documentation about the different options available to run the
        script (including verbosity levels)
      - Include information of additional external services introduced in this
        release (IPv6 and GeoIP info)
 .
   * debian/network-test-default: Introduce an option (DO_CABLETEST) to make it
     possible for system administrators to disable the
     /etc/network/if-up.d/00check-network-cable script if it shows up errors
     in their systems.
 .
   * debian/README: Give some information on the package and scripts as
     well as describe some known limitations - if an admin renames interfaces
     for his convenience some scripts might not work properly.
Checksums-Sha1:
 fa8483b778ad872149a0817c2c741ad45bb50c3a 1583 ifupdown-extra_0.31.dsc
 e8a52342b0c312df06487f46d0f605faa4c17dd5 652176 ifupdown-extra_0.31.tar.gz
 934298808e1698a675c033bcb415f204555b57a5 6446 
ifupdown-extra_0.31_source.buildinfo
Checksums-Sha256:
 36b3157bac0fee61c0a62a0c5e71626e3a23cc4b88f57d540c8ad7345ed58b16 1583 
ifupdown-extra_0.31.dsc
 1dbafbc1e63ffb42d3ca2230c5c938a83e3fdc924584240d836fb59a6faf6b57 652176 
ifupdown-extra_0.31.tar.gz
 4623d9c107ae9bb302efe4353f2fbb834cf378381e92284376b3f278dcbcd439 6446 
ifupdown-extra_0.31_source.buildinfo
Files:
 ca82b9a6f42020ecb22368af97d70e46 1583 admin optional ifupdown-extra_0.31.dsc
 994e6d54c9e7ad0ee81789feeb1d1b02 652176 admin optional 
ifupdown-extra_0.31.tar.gz
 1586f9606fd3c84799614137002333c3 6446 admin optional 
ifupdown-extra_0.31_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEFQ8Kq6ttIR3DT+AOix9vSKslf5gFAl9lyscACgkQix9vSKsl
f5gbmBAAsahB+FTsQlcajIIdYal4S7BMiHlLGP5Yy8z3xPIQZ43MuYh3GMwRw9J9
BJC6fzEjCPAsT4KHCAHyAnmRXvGuzXLaLVOTJiTMEXIJj1lLPqiMOksDwruhDV7x
PRRM9woRv4mTU9KaS2SQJOyqXOhbx9QbSqxzD2RdQMH8FakM+gEYt/6DTn4jGnhq
ste16A5kQS41d6yx1mbnuXQLd3ESIUjD7r7mpuD1thq/LyxRmRycPFj3GdZkJ4Bq
ZSCWrMYO8ATDkqxItJhYrlYt2zJ4XhwbJRRjmelLg4ji8uSFZ/F9Oyr/8fLgE15J
KmyE39olobfmaVCVKsqHmYGYDwHaLLpfS+LS0djnpPPsjTHSgGM59oo++P2uHi0M
/3fV1C2EWHFM45BBnI3vT9/Y3jFW0sVwoEuH9DHUT5iT+DvFbuVO2qbA6EclGSvC
oBDL+Hm3zxVqzpPJu7AB2MYxN3491p2Wun3JAp2EyVGj0N1YAQ9jTfwHU7FFugxY
utJC7hIibN7ucLU0msNhVhJKT0QgtPbgQnWKxucaqlLmVDvfyyGIQqXlukA+vqXm
0AudEggL1S9pjJ3A+plzZC1KAwdAMgMdVx8qH2K3pR1IsPn5cXdiELMPoRUQgH+m
QFCkuXqSFKZ4fXrShIHHk/BnXHXWP8amhycMLe9Ka3gABCuxSi4=
=QuPG
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to