Your message dated Sun, 18 Oct 2020 10:34:28 +0000
with message-id <[email protected]>
and subject line Bug#972378: fixed in fckit 0.9.0-2
has caused the Debian Bug report #972378,
regarding fckit: please make the build (mostly) reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
972378: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=972378
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: fckit
Version: 0.9.0-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: buildpath
X-Debbugs-Cc: [email protected]
Hi,
Whilst working on the Reproducible Builds effort [0] we noticed that
fckit could not be built reproducibly.
This is because it embeds the build path in various places, including
in the "--usage" help message. Not sure if the CMake file is even
useful in the binary package, so that might be something to confirm
before patching it.
Anyway, patch attached that makes the build (mostly) reproducible; the
rest of the unreproducibility is due to the Fortran toolchain, such as
assertions in the binary and in dh-fortran-mod (addressed in #965255).
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
--- a/debian/patches/reproducible_build.patch 1970-01-01 01:00:00.000000000
+0100
--- b/debian/patches/reproducible_build.patch 2020-10-17 11:12:34.597243518
+0100
@@ -0,0 +1,41 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2020-10-17
+
+--- fckit-0.9.0.orig/fckit-import.cmake.in
++++ fckit-0.9.0/fckit-import.cmake.in
+@@ -6,14 +6,9 @@
+ # granted to it by virtue of its status as an intergovernmental organisation
nor
+ # does it submit to any jurisdiction.
+
+-if( @PROJECT_NAME@_IS_BUILD_DIR_EXPORT )
+- set( FCTEST_GENERATOR @PYTHON_EXECUTABLE@
@CMAKE_CURRENT_SOURCE_DIR@/tools/fctest-generate-runner.py )
+- set( FYPP @CMAKE_CURRENT_SOURCE_DIR@/tools/fckit-eval.sh
@PYTHON_EXECUTABLE@ @CMAKE_CURRENT_SOURCE_DIR@/tools/fckit-fypp.py )
+-else()
+- set( FCKIT_INSTALL_PREFIX ${CMAKE_CURRENT_LIST_DIR}/../../.. )
+- set( FCTEST_GENERATOR @PYTHON_EXECUTABLE@
${FCKIT_INSTALL_PREFIX}/libexec/fctest-generate-runner.py )
+- set( FYPP ${FCKIT_INSTALL_PREFIX}/libexec/fckit-eval.sh @PYTHON_EXECUTABLE@
${FCKIT_INSTALL_PREFIX}/libexec/fckit-fypp.py )
+-endif()
++set( FCKIT_INSTALL_PREFIX ${CMAKE_CURRENT_LIST_DIR}/../../.. )
++set( FCTEST_GENERATOR @PYTHON_EXECUTABLE@
${FCKIT_INSTALL_PREFIX}/libexec/fctest-generate-runner.py )
++set( FYPP ${FCKIT_INSTALL_PREFIX}/libexec/fckit-eval.sh @PYTHON_EXECUTABLE@
${FCKIT_INSTALL_PREFIX}/libexec/fckit-fypp.py )
+
+ @FCKIT_PREPROCESS_FYPP@
+
+--- fckit-0.9.0.orig/src/apps/fckit.in
++++ fckit-0.9.0/src/apps/fckit.in
+@@ -42,14 +42,10 @@ info()
+ echo ""
+ echo "Build:"
+ echo " build type : @CMAKE_BUILD_TYPE@"
+- echo " timestamp : @EC_BUILD_TIMESTAMP@"
+ echo " op. system : @CMAKE_SYSTEM@ (@EC_OS_NAME@.@EC_OS_BITS@)"
+ echo " processor : @CMAKE_SYSTEM_PROCESSOR@"
+- echo " sources : @PROJECT_SOURCE_DIR@"
+ echo " c++ compiler : @CMAKE_CXX_COMPILER_ID@
@CMAKE_CXX_COMPILER_VERSION@"
+- echo " flags : @EC_CXX_FLAGS@"
+ echo " fortran compiler: @CMAKE_Fortran_COMPILER_ID@
@CMAKE_Fortran_COMPILER_VERSION@"
+- echo " flags : @EC_Fortran_FLAGS@"
+ echo ""
+ echo "Features:"
+ echo " MPI : $(print_feature @eckit_HAVE_MPI@)"
--- a/debian/patches/series 2020-10-17 10:42:19.834474336 +0100
--- b/debian/patches/series 2020-10-17 11:12:33.485228123 +0100
@@ -1,2 +1,3 @@
shared_lib.patch
paths.patch
+reproducible_build.patch
--- End Message ---
--- Begin Message ---
Source: fckit
Source-Version: 0.9.0-2
Done: Alastair McKinstry <[email protected]>
We believe that the bug you reported is fixed in the latest version of
fckit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Alastair McKinstry <[email protected]> (supplier of updated fckit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 18 Oct 2020 09:42:30 +0100
Source: fckit
Architecture: source
Version: 0.9.0-2
Distribution: unstable
Urgency: medium
Maintainer: Alastair McKinstry <[email protected]>
Changed-By: Alastair McKinstry <[email protected]>
Closes: 972378
Changes:
fckit (0.9.0-2) unstable; urgency=medium
.
* Make build reproducible. Closes: #972378
* Fix cmake scripts to build atlas-ecmwf:
- change refernences libfckit.so.0d -> libfckit-gfortran.so.0d
Checksums-Sha1:
8446145d1560dac466f9b148456761e889057f60 2128 fckit_0.9.0-2.dsc
c0ded4030171efa42f3f5a3241a2a244f61b5bd5 4768 fckit_0.9.0-2.debian.tar.xz
Checksums-Sha256:
e59e5a6f6ce8e3f8e52d3a97a0b1ebf709cdedc9256364776bbaad501c2f2681 2128
fckit_0.9.0-2.dsc
9f588a1e4992dd6c7e45af6573c8fd527d856ac62ccc595d417949b936990285 4768
fckit_0.9.0-2.debian.tar.xz
Files:
74925b8e04f2bf94f9660626b86dc027 2128 science optional fckit_0.9.0-2.dsc
0a7e2cc30de171d5fcc1c734c3610f77 4768 science optional
fckit_0.9.0-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEgjg86RZbNHx4cIGiy+a7Tl2a06UFAl+MFrcACgkQy+a7Tl2a
06XRKg//eAKKlROaiH0I5eCxjt6pxXAR93StgtBNalzSFPUPpJzESY5EeNV48Rac
MDmBEQ9qySI95GeOZnp8FTYoSRuk9YYTR11QfMu9flRJMT0CgsVtmR7vINdofmyF
epmU1VSUovBEs3HLXvroeQD+b7f0hjbUAJ9KysxcBUpNuHriFR20npAbxg5KKWmP
POeea8LjAIBqK6FDJQFfgBaRuZ9B7cH3xW11wNw2eidM0jBQAsQj6iQThE1nigI/
a/fOFB39Tyw7t3GNZ8xINPPupzLMbNbyE5nyDQreDlHBYCCBxDuI3MkwNSBdValH
XrvIcDXr/uC2N2nGpFR7MmhlOc6SDr/ZSyGb2FjchyuOkarsXt/I6LuT3ZzDtasC
1K5w5vKnGgJpHzqNh4x1YvP32VOIF/WI0p8MiAgFvnky1BD18QOIB/7qxtMa0Nn9
/fEO9VcU39QRDH4KE4LDM3p+qKOCm5aRyzVB0OPWiGeYg4HCQ6aNHyfHkPH/4k+9
ufOJmB8mUNirvZajNn0R1yITUkOvgXYv7yTPA8IqVwN6SDYhSk85q8BXxkoJ/TYV
3wHNR2qCYt8ykACLLfDHEAD4yzpBxPIHgnjspfohD/Oe/tYfT3d7RqL7DwEMzY0P
juFJ458r4FwtXyKV4cMAxxBQCzumJ5m10NEpQHX3SLRkZiyoWB0=
=aTNV
-----END PGP SIGNATURE-----
--- End Message ---
