Your message dated Mon, 19 Oct 2020 13:22:52 +0000
with message-id <[email protected]>
and subject line Bug#972496: fixed in softether-vpn
5.01.9674+git20200806+8181039+dfsg-2
has caused the Debian Bug report #972496,
regarding softether-vpn: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
972496: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=972496
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: softether-vpn
Version: 5.01.9674+git20200806+8181039+dfsg-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: hostname
X-Debbugs-Cc: [email protected]
Hi,
Whilst working on the Reproducible Builds effort [0] we noticed that
softether-vpn could not be built reproducibly.
This is because it embeds the build username and build hostname into
the final binary.
Patch attached that doesn't set these variables (by editing the CMake
build configuration). The build does not fail when we do not define
these because of #ifdef preprocessor macros in upstream's header
files that has fallbacks.
The build is not fully reproducible with this change though, but it
will be once we enable fixfilepath dpkg-buildflags feature area toggle
archive-wide. (There's a thread unfolding on dpkg-dev now; no need to
set this here for now.)
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
--- a/debian/patches/reproducible-build.patch 1970-01-01 01:00:00.000000000
+0100
--- b/debian/patches/reproducible-build.patch 2020-10-19 11:30:17.523909380
+0100
@@ -0,0 +1,24 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2020-10-19
+
+---
softether-vpn-5.01.9674+git20200806+8181039+dfsg.orig/src/Cedar/CMakeLists.txt
++++ softether-vpn-5.01.9674+git20200806+8181039+dfsg/src/Cedar/CMakeLists.txt
+@@ -43,17 +43,6 @@ endif()
+ # Version
+ add_definitions(-DCEDAR_VERSION_MAJOR=${PROJECT_VERSION_MAJOR}
-DCEDAR_VERSION_MINOR=${PROJECT_VERSION_MINOR}
-DCEDAR_VERSION_BUILD=${PROJECT_VERSION_PATCH})
+
+-# Builder
+-if(UNIX)
+- add_definitions(-DBUILDER_NAME="$ENV{USER}")
+-elseif(WIN32)
+- add_definitions(-DBUILDER_NAME="$ENV{USERNAME}")
+-endif()
+-
+-cmake_host_system_information(RESULT BUILDER_HOSTNAME QUERY HOSTNAME)
+-
+-add_definitions(-DBUILD_PLACE="${BUILDER_HOSTNAME}")
+-
+ # Remove leading 0 from date and time
+ string(REGEX REPLACE "^0([^ ]*)" "\\1" BUILD_DAY "${DATE_DAY}")
+ string(REGEX REPLACE "^0([^ ]*)" "\\1" BUILD_MONTH "${DATE_MONTH}")
--- a/debian/patches/series 2020-10-19 11:07:54.187577017 +0100
--- b/debian/patches/series 2020-10-19 11:30:16.675898707 +0100
@@ -1,2 +1,3 @@
static-link.patch
fix-systemd-units.patch
+reproducible-build.patch
--- End Message ---
--- Begin Message ---
Source: softether-vpn
Source-Version: 5.01.9674+git20200806+8181039+dfsg-2
Done: Andrej Shadura <[email protected]>
We believe that the bug you reported is fixed in the latest version of
softether-vpn, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andrej Shadura <[email protected]> (supplier of updated softether-vpn package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 19 Oct 2020 14:14:55 +0200
Source: softether-vpn
Architecture: source
Version: 5.01.9674+git20200806+8181039+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Andrej Shadura <[email protected]>
Changed-By: Andrej Shadura <[email protected]>
Closes: 972496
Changes:
softether-vpn (5.01.9674+git20200806+8181039+dfsg-2) unstable; urgency=medium
.
[ Chris Lamb ]
* Make the build reproducible (Closes: #972496).
Checksums-Sha1:
b5679bf9309eb22ddff4695000f9b372350917be 2216
softether-vpn_5.01.9674+git20200806+8181039+dfsg-2.dsc
3df293a3afd8e493d4111940060d21ba71300c31 4720
softether-vpn_5.01.9674+git20200806+8181039+dfsg-2.debian.tar.xz
Checksums-Sha256:
137f9290425d1a6570ad1e0957b93057e65729cde6562f8f3f84e7e4c6622579 2216
softether-vpn_5.01.9674+git20200806+8181039+dfsg-2.dsc
ff5d3206ee28b04553a24c13770e14c06aeaa833a34470a8e26a8fb04339cf21 4720
softether-vpn_5.01.9674+git20200806+8181039+dfsg-2.debian.tar.xz
Files:
175234bb09e3ae4288d4e1aff99aea04 2216 net optional
softether-vpn_5.01.9674+git20200806+8181039+dfsg-2.dsc
db67f82019b7a07cf34c1dad88fd2eb5 4720 net optional
softether-vpn_5.01.9674+git20200806+8181039+dfsg-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEeuS9ZL8A0js0NGiOXkCM2RzYOdIFAl+Ng2AACgkQXkCM2RzY
OdKkSQgAg+GEdLZl1DsO++s2XoFh2fZakQQfZ2EAAhQLQaBp5tcerNox69LXjIY1
F/T9FM3de/cduaVcPNb0qbUixxKg5Wvce7Sz61njnArwr9zJ0NU1XhBy9uWRk7+3
BoJ28SEt7nHxU3tvx3yImiu/c7irdou9b9vv5oADz/XDvbccd+8QCc/Zb/qKGLvh
ipsJiCI6fMgw3Roe/RwPHQDUuUrcuEHeutda0LsVHmMcgmzRxvGga9vSEg9w3idr
qwz28N3qkSTmS2+EOgplX82PfdgsNHSjanmRVelmQqKUa5XxlWhivnKQHM6o13Jc
JSYYjg6G9/lOonvIvprKBX/bcS4lhQ==
=g60M
-----END PGP SIGNATURE-----
--- End Message ---
