Your message dated Wed, 21 Oct 2020 19:03:35 +0000
with message-id <[email protected]>
and subject line Bug#972619: fixed in crmsh 4.2.0-4
has caused the Debian Bug report #972619,
regarding crmsh: spurious test_grep failure in autopkgtest
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
972619: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=972619
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: crmsh
Version: 4.2.0-3
Severity: important
Justification: blocks migration of openssh to testing

https://ci.debian.net/data/autopkgtest/testing/amd64/c/crmsh/7648090/log.gz
shows what I believe to be a spurious failure:

  FAIL: unittests.test_report.test_grep
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/usr/lib/python3/dist-packages/nose/case.py", line 197, in runTest
      self.test(*self.arg)
    File "/usr/share/crmsh/tests/unittests/test_report.py", line 238, in 
test_grep
      eq_(res, out.strip("\n"))
  AssertionError: 'Package: bash' != 'Package: bash\nPackage: bash'
  -------------------- >> begin captured stdout << ---------------------
  .EXT apt-cache show bash
  .EXT apt-cache show bash|grep "^Package:"
  
  --------------------- >> end captured stdout << ----------------------

The relevant code is:

    res = grep("^Package:", incmd="apt-cache show bash")[0]
    _, out = get_command_info("apt-cache show bash|grep \"^Package:\"")
    eq_(res, out.strip("\n"))

If there happen to be multiple versions of bash in the apt cache, then
grep(...)[0] will only show the first match, while the following
get_command_info() will show all of them.

I haven't tested this at all, but I suggest either something like:

    res = "\n".join(grep("^Package:", incmd="apt-cache show bash"))

... or:

    _, out = get_command_info("apt-cache show bash|grep -m1 \"^Package:\"")

Thanks,

-- 
Colin Watson (he/him)                              [[email protected]]

--- End Message ---
--- Begin Message ---
Source: crmsh
Source-Version: 4.2.0-4
Done: Valentin Vidic <[email protected]>

We believe that the bug you reported is fixed in the latest version of
crmsh, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Valentin Vidic <[email protected]> (supplier of updated crmsh package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 21 Oct 2020 20:42:26 +0200
Source: crmsh
Architecture: source
Version: 4.2.0-4
Distribution: unstable
Urgency: medium
Maintainer: Debian HA Maintainers 
<[email protected]>
Changed-By: Valentin Vidic <[email protected]>
Closes: 972619
Changes:
 crmsh (4.2.0-4) unstable; urgency=medium
 .
   * d/patches: fix flaky autopkgtest (Closes: #972619)
   * d/control: use debhelper v13
   * d/lintian-overrides: update override name
Checksums-Sha1:
 f7be8fda8b4408452fc93648661933b64c2d99b2 2323 crmsh_4.2.0-4.dsc
 02a9a0e791c575dfcee25acbd09187bf0ce9d32a 33148 crmsh_4.2.0-4.debian.tar.xz
 8428d3ee1811a4b4dcfe19cdb909468f8bfa15ca 6544 crmsh_4.2.0-4_source.buildinfo
Checksums-Sha256:
 e0a1d0da28ef76630b1aa01d4ee6856c8d77d006f9e0dd794820dbf2bcd35cde 2323 
crmsh_4.2.0-4.dsc
 d28a809f975bafeab1eb582fe1cb3ec9452cdf73dae2b1af81a252e7f935d654 33148 
crmsh_4.2.0-4.debian.tar.xz
 4d5958b2904bbe6c48aaad7d5e9c958d90f10a0a4af8f61193ee8107976e1135 6544 
crmsh_4.2.0-4_source.buildinfo
Files:
 39e3b27402b4c53aacca21cfa02e6b83 2323 admin optional crmsh_4.2.0-4.dsc
 285937a291e18fead9a560a81722619a 33148 admin optional 
crmsh_4.2.0-4.debian.tar.xz
 45295d7b21e570db673ab24d706a2680 6544 admin optional 
crmsh_4.2.0-4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEExaW53cM9k/u2PWfIMofYmpfNqHsFAl+QhOASHHZ2aWRpY0Bk
ZWJpYW4ub3JnAAoJEDKH2JqXzah7GqkP/3E9Aejz7/T7UnsWSq5NxcHw7gLbmJmU
fE4BHRsJvlDFoYzd4OwjZR8ZCmUJFc+SqI63reV1pzw5o/sof+OgcYtAn6emIe6p
T+9992f/Ycp/9yFEpRcakPHJ5vn22yT0KL6MgfBEnQYN7W73+hg25MkxGh3Oc6bL
qhJJlaKfnH5W33YfDVUjdrrBt3+WTKIGwNWxV4Ep+dWAVYBNGQ8vh6naCopSznFw
G89R2BSUbcuExn5qrMvT3pyzpjsQB9LAtjL2D34KF7rytEll2ZR3FXSZ3WUlfEre
8B8MS6CEyz/ni0nif2TxiZGPHxB3begExDBu2lcP3Joxhty8YMO6GDJNwW9IRplZ
kcLH2aKEsO6i2F7a2dJcuW1+mNKQUV4sKfHelzEPUqIv3AUdeoFJiBi/AqtOOgW7
NxFPDPhWYD+NGEcFqiiekCLT2iWoV8BoFDutwiS/xsgmiv4gAJnyZNBgDn1UjF6S
Cckwa9DwFsK91bJOBMe2Dg5xG2hjpjmnJLH3YpE5jm93ycjZJIKloLtaVykq57ne
cvoALJV0vOwEuR0T6iEovZMyQ1WmAx+rdpatAmwPWijPiVKyRbAssY4ITCXx+koo
vKEOZb03AwXqPnSe5YaXu902y9UgdlB/8DjdV/q24lcmzxpvjd4r6yC1Mv7q8Zxm
/hiPgk0rGlwm
=z75i
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to