Your message dated Mon, 26 Oct 2020 20:48:29 +0000
with message-id <[email protected]>
and subject line Bug#958727: fixed in autopkgtest 5.15
has caused the Debian Bug report #958727,
regarding autopkgtest-virt-ssh: support root-on-testbed when logging in as root
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
958727: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=958727
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
package: autopkgtest
version: 5.10
tags: patch
Hi,
When logging in as root, autopkgtest-virt-ssh should assume that
root-on-testbed is available. The current code doesn't do that.
If autopkgtest-virt-ssh is started with '--capability root-on-testbed', but
sudo fails, the 'root-on-testbed' capability is assumed to be absent and
removed. This should (at least) result in a warning, to allow easier
debugging.
The attached patch fixes both issues.
Thanks!
Ivo
--- /usr/bin/autopkgtest-virt-ssh 2020-04-24 18:20:34.417318935 +0000
+++ /usr/bin/autopkgtest-virt-ssh.root 2020-04-24 18:20:26.637316737 +0000
@@ -326,16 +326,18 @@
global sshconfig, sshcmd, capabilities, workdir
- if sshconfig['login'] != 'root':
- (sudocmd, askpass) = can_sudo(sshcmd)
- else:
+ if sshconfig['login'] == 'root':
(sudocmd, askpass) = (None, None)
- if sudocmd:
- if 'root-on-testbed' not in capabilities:
- capabilities.append('root-on-testbed')
+ capabilities.append('root-on-testbed')
else:
- if 'root-on-testbed' in capabilities:
- capabilities.remove('root-on-testbed')
+ (sudocmd, askpass) = can_sudo(sshcmd)
+ if sudocmd:
+ if 'root-on-testbed' not in capabilities:
+ capabilities.append('root-on-testbed')
+ else:
+ if 'root-on-testbed' in capabilities:
+ adtlog.warning('sudo command failed: removing root-on-testbed capability')
+ capabilities.remove('root-on-testbed')
extra_cmd = ''
if askpass:
--- End Message ---
--- Begin Message ---
Source: autopkgtest
Source-Version: 5.15
Done: Paul Gevers <[email protected]>
We believe that the bug you reported is fixed in the latest version of
autopkgtest, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Paul Gevers <[email protected]> (supplier of updated autopkgtest package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 26 Oct 2020 21:27:25 +0100
Source: autopkgtest
Architecture: source
Version: 5.15
Distribution: unstable
Urgency: medium
Maintainer: Debian CI team <[email protected]>
Changed-By: Paul Gevers <[email protected]>
Closes: 918882 958727 960267 970513 971749
Changes:
autopkgtest (5.15) unstable; urgency=medium
.
[ Sebastien Delafond ]
* Remove left over .new containers before trying to generate a new one
(Closes: #971749)
.
[ Antonio Terceiro ]
* virt-lxc: extract common initial argument list for lxc-copy
* virt-lxc: add option to limit disk usage by tests
.
[ Paul Gevers ]
* tests/lxd: mark test skippable and exit 77 in stead of 0 in case of
balling-out
* Add support for Architecture field (Closes: #970513)
* Check for empty Tests field (Closes: #918882)
* With --test-name, don't report when other tests are skipped
(Closes: #960267)
.
[ Simon McVittie ]
* Check restrictions with testbed compat, not during initialization
* Allow restrictions to be ignored from the command line
.
[ Ivo De Decker ]
* Assume root-on-testbed with autopkgtest-virt-ssh and improve debugging
(Closes: #958727)
Checksums-Sha1:
c44e68692c0d0a67ab5af477c4dc210922b1f3d1 1695 autopkgtest_5.15.dsc
cd8435a57b5aed546e4801d64e238413321d087a 186748 autopkgtest_5.15.tar.xz
Checksums-Sha256:
c5192a929d93fc281efe258b6337c4cd942507c7c74d170c3198147bb4b48275 1695
autopkgtest_5.15.dsc
1b3d12264034405f5d88cdce555e64a08fb0567e5a9256d382f034cd371f35dd 186748
autopkgtest_5.15.tar.xz
Files:
899d2bce385a145a35da8522d46f268a 1695 devel optional autopkgtest_5.15.dsc
f1f86b3efe11fe090cf487678d565764 186748 devel optional autopkgtest_5.15.tar.xz
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEWLZtSHNr6TsFLeZynFyZ6wW9dQoFAl+XMqYACgkQnFyZ6wW9
dQo3PAgAmBSquBbrFHCgozRTYzXQZX4NlwRcEC0sUPpqI+pVPHbWwKLc8YxCydeI
PkL8kbF0JGTPpSrxqSSpV9SwlVu9rK69UL1T+fAFe81lR2aDvpkMCwC5P9b+XqOg
MFUuxnpIVYnGg+3OfZVCt6mbKn+Br55FvuRzxWMSeZ4w/KxdwJXjdvgVXu6vzMH8
nJPaH2fLSCfkL4lWLcjBJoQ1csXq2AORGZ43W8BqaWACphvKhHqypV5ut9MvZ/0w
4Ta4y6/kv+oZiLYwJeUX+kawHo0Ve67TimX3IwU4wWsgBRQN5Ikeg78FOz6dDubs
OBAUPmeEzYOBm5NZI3PzISwMUgonsw==
=7CVJ
-----END PGP SIGNATURE-----
--- End Message ---
