Your message dated Tue, 27 Oct 2020 16:19:12 +0000
with message-id <[email protected]>
and subject line Bug#972937: fixed in gst-plugins-base1.0 1.18.1-1
has caused the Debian Bug report #972937,
regarding theoradec: Enables "telemetry" (statistics capture) even if not
requested, causing poor performance
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
972937: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=972937
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gstreamer1.0-plugins-base
Version: 1.14.4-2
Severity: normal
Tags: patch fixed-upstream
Forwarded:
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/887
The latest version of Proton (Valve's branch of Wine, used to run Windows
games under Steam) runs in a Debian 10-based container
(Steam Runtime 2 'soldier'), instead of the Ubuntu 12.04-based
LD_LIBRARY_PATH library bundle (Steam Runtime 1 'scout') that was used
in previous releases.
During the move from Steam Runtime 1 to 2, Proton developers noticed
a performance regression in their GStreamer-based video decoding,
which they were able to track down to the theoradec plugin. This plugin
uses libtheora, which has an optional feature called "telemetry" that
records statistics. It can be enabled or disabled at build-time; if
enabled at build-time, it is disabled by default at runtime. Activating
it at runtime involves setting some options, and incurs a significant
performance cost to convert each decoded frame from YUV to RGB for use
by Cairo (30-40ms per frame for 1920x1080 video).
Note that despite its name, as far as I'm aware "telemetry" does not
send the statistics anywhere, it just captures them - so it isn't a
privacy problem, and is really just "-metry", with no "tele-" involved :-)
In Debian, the telemetry feature is enabled in libtheora at build-time.
GStreamer's theoradec plugin attempts to set the telemetry options to
user-specified values. However, in released versions of libtheora,
setting the telemetry options to any value - even 0 - is documented to
have the side-effect of enabling the telemetry feature and triggering
the performance regression.
This can be fixed in three ways:
1. Disable telemetry at compile-time in libtheora.
We did this in the Steam Runtime as a temporary solution, but it's a
feature regression for libtheora, and the libtheora maintainers in
Debian presumably don't want that, so let's discard this option.
2. In GStreamer, if the telemetry options are set to 0, don't propagate
that into libtheora so that the expensive YUV -> RGB conversion is
not done, even with current releases of libtheora. This is
<https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/887>
and is what this bug represents. It has been merged upstream and was
backported to 1.18.x (for 1.18.1, I think) in
<https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/892>.
3. In libtheora, if the telemetry options are all explicitly set to 0
(for example by current versions of GStreamer), behave as though they
had not been set at all, and therefore don't enable the expensive
YUV -> RGB conversion. This is
<https://gitlab.xiph.org/xiph/theora/-/issues/2312> and
<https://gitlab.xiph.org/xiph/theora/-/merge_requests/4>, and I'll
open a separate libtheora bug to represent this. It has been merged
upstream for v1.2.0, but there hasn't been an upstream release since
1.2.0 alpha 1 (which doesn't have this change) in 2010, so it seems
unlikely that there will be a release with this change any time soon.
Following the principle that bad interactions between two components are
most robust if fixed on *both* sides, solutions 2 and 3 have both been
accepted upstream, and I suggest that they should also happen in Debian.
The Steam Runtime maintainers will probably be doing a backport of this
into 1.14.x, so I'll try to send a patch later.
Thanks,
smcv
--- End Message ---
--- Begin Message ---
Source: gst-plugins-base1.0
Source-Version: 1.18.1-1
Done: =?utf-8?q?Sebastian_Dr=C3=B6ge?= <[email protected]>
We believe that the bug you reported is fixed in the latest version of
gst-plugins-base1.0, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sebastian Dröge <[email protected]> (supplier of updated gst-plugins-base1.0
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 27 Oct 2020 17:14:05 +0200
Source: gst-plugins-base1.0
Architecture: source
Version: 1.18.1-1
Distribution: unstable
Urgency: medium
Maintainer: Maintainers of GStreamer packages
<[email protected]>
Changed-By: Sebastian Dröge <[email protected]>
Closes: 970324 972937
Changes:
gst-plugins-base1.0 (1.18.1-1) unstable; urgency=medium
.
* New upstream bugfix release (Closes: #972937).
* debian/control:
+ Add dependency on libwayland-dev on Linux (Closes: #970324).
Checksums-Sha1:
b6f9194257d6bf0546189b537d6061dab67ef47b 3836 gst-plugins-base1.0_1.18.1-1.dsc
9da1f552f776002dff0eebff9788e3857092fccf 3157952
gst-plugins-base1.0_1.18.1.orig.tar.xz
5d0db5363d23859e0a2b879f213f9441a619cf10 42684
gst-plugins-base1.0_1.18.1-1.debian.tar.xz
08e34cb663a0f2e99f96475118f0d77c050e5e60 17724
gst-plugins-base1.0_1.18.1-1_amd64.buildinfo
Checksums-Sha256:
471f9fb02ce5393bfae3991fecdad1c90a50b6a993591f826a72e93fea8699ad 3836
gst-plugins-base1.0_1.18.1-1.dsc
1ba654d7de30f7284b4c7071b32f881b609733ce02ab6d9d9ea29386a036c641 3157952
gst-plugins-base1.0_1.18.1.orig.tar.xz
ab3ad37b085add61ecf9e10ccbfffe23a3c19647ba3518c4e58a17647a53a996 42684
gst-plugins-base1.0_1.18.1-1.debian.tar.xz
fc43b48d1aff2aee677f4beda4dc77d66bf4303560577c4b9e257590ff8c60fe 17724
gst-plugins-base1.0_1.18.1-1_amd64.buildinfo
Files:
22afccc922b72267abd5a2e96753d391 3836 libs optional
gst-plugins-base1.0_1.18.1-1.dsc
686081ec256a5d2d731237f13ea82f70 3157952 libs optional
gst-plugins-base1.0_1.18.1.orig.tar.xz
42f50c63032e0e46fd6385193205508f 42684 libs optional
gst-plugins-base1.0_1.18.1-1.debian.tar.xz
637691baa09064328913b42d5a0caefb 17724 libs optional
gst-plugins-base1.0_1.18.1-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQKmBAEBCgCQFiEEf0vHzDygb5cza7/rBmjMFIbC17UFAl+YQRxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDdG
NEJDN0NDM0NBMDZGOTczMzZCQkZFQjA2NjhDQzE0ODZDMkQ3QjUSHHNsb21vQGNv
YXhpb24ubmV0AAoJEAZozBSGwte1oIIP/2lPJFvd17AkrxnMr7f7h+n+OoV6HIpN
zdl1IYdPn0V/b7SmW7+EM41OT8Ni13hSUe0Xx7Sh8+ZP9HN1OP1gfLemTVD4FodA
gSv5UFHy1JhviHt/ec9uZ52SilLE5qveisZKlYt4d9XmWQfahlX+K8Y0ibeLvQ2J
buL1U0iqyrmfCA98rEOTNwHcRzGJ8h5L2FCsGs0TyK318pxP9FFFcb08jsEdh+3B
MKNUj52Xp8+yZq/khNKr7Z+pheeZgE9sXYFCaM8rHmJP2CWVmv9gCPMfZH8d9/TA
nRazxATMQ24i4Yoa4L1H1OqzwhRewDcbRvTywyQCPNLd75DvtlqrsIBWrb2d4HFU
mpnfxcs368Yg4SO59hrWYSBEuacDat3b+p+IHZtZL5TO0TAEej7QMQUGK8+CDA7E
GGvcTc94l/EAGrT38gbtt5HGMRp/PYnaVM74alsk2DZadW+uV5wOf4ahOmLqIbel
ZYI8ZF+qmo5seup0DYMs5vPqhJxJrbi/JhXtPWe4Et7YxXMNouVrpmR7UhAT2NSW
/Si7LNkH+O6Fpr+i2MB3AbUE30h3Hb3kID//h3GiufvCOUu8sKvAyvhNL8s9xeyf
TzqF1qEGdZfd2fdnoKJuS/6GEkS7TvdGEVXSdvxoeX4NddRifqDIr/sw6OHbu7qe
k+YsOY0FSThe
=h+zP
-----END PGP SIGNATURE-----
--- End Message ---
