Your message dated Thu, 19 Nov 2020 11:05:42 +0000
with message-id <[email protected]>
and subject line Bug#975100: fixed in zeromq3 4.3.3-4
has caused the Debian Bug report #975100,
regarding zeromq3: FTBFS on hurd-i386
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
975100: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=975100
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: zeromq3
Version: 4.3.3-3
Severity: important
Tags: ftbfs, patch
User: [email protected]
Usertags: hurd
Hello,
zeromq3 fails to build from source due to a PATH_MAX issue in
tests/testutil.cpp, and a missing declaration of
make_random_ipc_endpoint in tests/testutil_unity.{hpp,cpp}
Additionally, since 4 tests are XFAIL the patch debian_rules.diff is
needed for a proper build.
Build-tested on GNU/Linux and GNU/Hurd.
Thanks!
--- a/debian/rules 2019-01-26 13:49:45.000000000 +0100
+++ b/debian/rules 2020-11-18 20:04:36.000000000 +0100
@@ -6,7 +6,7 @@
export TEST_VERBOSE=1
-ifeq ($(DEB_BUILD_ARCH_OS), kfreebsd)
+ifneq (, filter $(DEB_BUILD_ARCH_OS), kfreebsd hurd)
DO_TEST = no
endif
Index: zeromq3-4.3.3/tests/testutil.cpp
===================================================================
--- zeromq3-4.3.3.orig/tests/testutil.cpp
+++ zeromq3-4.3.3/tests/testutil.cpp
@@ -476,10 +476,14 @@ fd_t bind_socket_resolve_port (const cha
TEST_ASSERT_SUCCESS_RAW_ERRNO (_mkdir (buffer));
strcat (buffer, "/ipc");
#else
- char buffer[PATH_MAX] = "";
- strcpy (buffer, "tmpXXXXXX");
+ char *buffer = NULL;
+ size_t len = 10;
+ buffer = (char*) malloc(len);
+ strncpy (buffer, "tmpXXXXXX", len);
#ifdef HAVE_MKDTEMP
TEST_ASSERT_TRUE (mkdtemp (buffer));
+ len += 7;
+ buffer = (char *)realloc (buffer, len);
strcat (buffer, "/socket");
#else
int fd = mkstemp (buffer);
@@ -487,12 +491,17 @@ fd_t bind_socket_resolve_port (const cha
close (fd);
#endif
#endif
+ len += strlen((*(struct sockaddr_un *) &addr).sun_path);
+ buffer = (char *)realloc (buffer, len);
strcpy ((*(struct sockaddr_un *) &addr).sun_path, buffer);
memcpy (my_endpoint_, "ipc://", 7);
- strcat (my_endpoint_, buffer);
+ len += strlen(my_endpoint_);
+ buffer = (char *)realloc (buffer, len);
+ strncat (my_endpoint_, buffer, len);
// TODO check return value of unlink
unlink (buffer);
+ free (buffer);
#else
return retired_fd;
#endif
Index: zeromq3-4.3.3/tests/testutil_unity.cpp
===================================================================
--- zeromq3-4.3.3.orig/tests/testutil_unity.cpp
+++ zeromq3-4.3.3/tests/testutil_unity.cpp
@@ -298,7 +298,7 @@ void bind_loopback_tipc (void *socket_,
test_bind (socket_, "tipc://<*>", my_endpoint_, len_);
}
-#if defined(ZMQ_HAVE_IPC) && !defined(ZMQ_HAVE_GNU)
+#if defined(ZMQ_HAVE_IPC)
void make_random_ipc_endpoint (char *out_endpoint_)
{
#ifdef ZMQ_HAVE_WINDOWS
Index: zeromq3-4.3.3/tests/testutil_unity.hpp
===================================================================
--- zeromq3-4.3.3.orig/tests/testutil_unity.hpp
+++ zeromq3-4.3.3/tests/testutil_unity.hpp
@@ -272,7 +272,7 @@ void bind_loopback_ipc (void *socket_, c
// Binds to an ipc endpoint using the tipc wildcard address.
void bind_loopback_tipc (void *socket_, char *my_endpoint_, size_t len_);
-#if defined(ZMQ_HAVE_IPC) && !defined(ZMQ_HAVE_GNU)
+#if defined(ZMQ_HAVE_IPC)
// utility function to create a random IPC endpoint, similar to what a ipc://*
// wildcard binding does, but in a way it can be reused for multiple binds
// TODO also add a len parameter here
--- End Message ---
--- Begin Message ---
Source: zeromq3
Source-Version: 4.3.3-4
Done: Laszlo Boszormenyi (GCS) <[email protected]>
We believe that the bug you reported is fixed in the latest version of
zeromq3, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Laszlo Boszormenyi (GCS) <[email protected]> (supplier of updated zeromq3 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 19 Nov 2020 11:27:16 +0100
Source: zeromq3
Architecture: source
Version: 4.3.3-4
Distribution: unstable
Urgency: medium
Maintainer: Laszlo Boszormenyi (GCS) <[email protected]>
Changed-By: Laszlo Boszormenyi (GCS) <[email protected]>
Closes: 975100 975151
Changes:
zeromq3 (4.3.3-4) unstable; urgency=medium
.
* Add missed libbsd-dev dependency to libzmq3-dev (closes: #975151).
* Backport upstream fix of tests fails to receive on slow architectures.
.
[ Svante Signell <[email protected]> ]
* Fix FTBFS on Hurd-i386 (closes: #975100).
Checksums-Sha1:
8eb710e8d1d9db237682cf77a97e9ee8657bdace 1873 zeromq3_4.3.3-4.dsc
6ca0f78a73f206c4dfa818fc71028959f11ff130 24808 zeromq3_4.3.3-4.debian.tar.xz
Checksums-Sha256:
27dacec82dd6c037031883a144539d89036ababd11a917731d2ef87ac5fcaa8a 1873
zeromq3_4.3.3-4.dsc
011c03da56e941ae0b7c6c0451fb74ee004c3e7c0d5e0c7b9134548362a6fb08 24808
zeromq3_4.3.3-4.debian.tar.xz
Files:
e3900a2848c324be61407c31d8a8d563 1873 libs optional zeromq3_4.3.3-4.dsc
83cbf1091948036905fa43633f09ef3b 24808 libs optional
zeromq3_4.3.3-4.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEfYh9yLp7u6e4NeO63OMQ54ZMyL8FAl+2TMwACgkQ3OMQ54ZM
yL9ODBAAs9YbpcArv4k/2GL5Tyt4lnYIs3VaCzm8psHw2JNZIKp7NSmZ2GO5FpMb
lB7eFgnMPOxshyJXm8pPeVD4i7D9wgGOA/4SJJRAK/Rk/Di0zjIq1xRJUUbmYm3S
kohC8Vkc7OzkCzM4uc/0mGwVqOUOTlbBQ7RHLGN2n8bops9jasYlZVKfgmPPWjof
4ojquqnxMJlrxwNF27o+QJhvv+5tlqm74+PAAbIlLNWxkQsJNbrQjmvwtzdxGCW9
4rj15e7+9SoyF4S52gkDDnlyJrm7mDAItEaD1XJFN3OKjnCXUx6zbmrc4JdheFk6
tbB1b6g5Ltd1Zxor2ElsqeTrgOcW0k81C/SILJsFYvbcvnMbuUzbTKZgQRTVXTzF
RChqPLZS+Q/PngNHoOk04c8HeJYQBNalKdJ7p44O73me2lPBsUbJg0mIbE4WSXs5
20b7WWTCQUqX2qwu1mVzM2wbv9P7cKXrPYUBsI0MpVQgAXMy3wRQpUBLIN3108nH
425INCrCTvcfMPLlMVE8p3KYMnoO1hMaNXBuQoRZh80VReKjnsxiceczZKK2t/VK
QSjbVhvPaR6Z85gfRQgKYPVBqmk/3xZJl+wulXu1yEDSxGBHlO2hmbVa4PhRdPE1
K1Qj9JmwTAegZDBz7d8FZgL+EbeHO2dJkzpfXlr7JmvdAk+w9V4=
=mzYK
-----END PGP SIGNATURE-----
--- End Message ---
