Your message dated Mon, 23 Nov 2020 13:11:01 -0800
with message-id <[email protected]>
and subject line Re: Bug#833818: dnssec-trigger: please make the build
reproducible
has caused the Debian Bug report #833818,
regarding dnssec-trigger: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
833818: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=833818
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: dnssec-trigger
Version: 0.13~svn685-5
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: timestamps
X-Debbugs-Cc: [email protected]
Hi,
Whilst working on the "reproducible builds" effort [0], we noticed
that dnssec-trigger could not be built reproducibly.
Patch attached.
[0] https://wiki.debian.org/ReproducibleBuilds
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
--- a/debian/patches/reproducible-build.patch 1970-01-01 01:00:00.000000000
+0100
--- b/debian/patches/reproducible-build.patch 2016-08-08 23:33:50.479553264
+0100
@@ -0,0 +1,23 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2016-08-08
+
+--- dnssec-trigger-0.13~svn685.orig/Makefile.in
++++ dnssec-trigger-0.13~svn685/Makefile.in
+@@ -54,7 +54,7 @@ pidfile=@pidfile@
+ login_command=@login_command@
+ login_location=@login_location@
+ unbound_control_path=@unbound_control_path@
+-DATE=$(shell date +%F -r $(srcdir)/Changelog)
++DATE=$(shell date -u +%F -r $(srcdir)/Changelog)
+
+ do_subst = sed -e 's,[@]SHELL[@],$(SHELL),g' \
+ -e 's,[@]PACKAGE[@],$(PACKAGE),g' \
+@@ -96,7 +96,6 @@ LIBOBJS=@LIBOBJS@
+ RUNTIME_PATH=@RUNTIME_PATH@
+ DEPFLAG=@DEPFLAG@
+ EXPORT_DYNAMIC=@EXPORT_DYNAMIC@
+-DATE=$(shell date +%Y%m%d)
+ BUILD=build/
+
+ WINDRES=@WINDRES@
--- a/debian/patches/series 2016-08-08 23:09:05.211264776 +0100
--- b/debian/patches/series 2016-08-08 23:22:49.654088164 +0100
@@ -4,3 +4,4 @@
strip-version-number-from-config.patch
fix-desktop-file-dirs.patch
dnssec-trigger-nm-1.1.90.patch
+reproducible-build.patch
--- a/debian/rules 2016-08-08 23:09:05.211264776 +0100
--- b/debian/rules 2016-08-08 23:34:02.875655750 +0100
@@ -9,6 +9,8 @@
export DEB_CFLAGS_MAINT_APPEND = -Wall -pedantic -g -pipe $(if $(findstring
noopt,$(DEB_BUILD_OPTIONS)),-O0,-O2)
export DEB_LDFLAGS_MAINT_APPEND = -Wl,-z,defs -Wl,--as-needed
+export SHELL = /bin/sh
+
%:
dh $@ --with autoreconf,systemd,python2
--- End Message ---
--- Begin Message ---
Package: dnssec-trigger
Version: 0.17+repack-4
thanks
On Mon, 2020-11-23 at 10:30 +0000, Chris Lamb wrote:
> Hi,
>
> > The good news is it looks like I applied the patch, but I forgot to
> > close the bug.
> >
> > The bad news is it's still not reproducible.
>
> It looks like you fixed this in:
>
>
> https://salsa.debian.org/dns-team/dnssec-trigger/commit/f0fcf105fc1cfd22be0cb0970cc9f433e8f81d4c
>
> I believe you can close this bug now. Thanks. :)
Cool thank you for letting me know.
Diane
--- End Message ---
