Your message dated Sun, 29 Nov 2020 00:33:32 +0000
with message-id <[email protected]>
and subject line Bug#946443: fixed in libnotify 0.7.9-2
has caused the Debian Bug report #946443,
regarding libnotify: Please make autopkgtests cross-test-friendly
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
946443: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946443
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libnotify
Version: 0.7.8-1
Severity: minor
Tags: patch
User: [email protected]
Usertags: origin-ubuntu focal ubuntu-patch
Dear maintainers,
In Ubuntu, we are in the process of moving the i386 architecture to a
compatibility-only layer on amd64, and therefore we are also moving our
autopkgtest infrastructure to test i386 binaries in a cross-environment.
This requires changes to some tests so that they are cross-aware and can do
the right thing.
The libnotify tests currently fail in this environment, because they are
build tests that do not invoke the toolchain in a cross-aware manner, and
also because they declare a test dependency on a virtual package
'notification-daemon' which may or may not be cross-installable. I've
verified that the attached patch lets the tests successfully build (and run)
i386 tests on an amd64 host.
Note that upstream autopkgtest doesn't currently set DEB_HOST_ARCH so this
is a complete no-op in Debian for the moment. Support for cross-testing in
autopkgtest is currently awaiting review at
https://salsa.debian.org/ci-team/autopkgtest/merge_requests/69 and once
landed, will still have no effect unless autopkgtest is invoked with a '-a'
option. So this change should be safe to land in your package despite this
not being upstream in autopkgtest.
Thanks for considering,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru libnotify-0.7.8/debian/tests/build libnotify-0.7.8/debian/tests/build
--- libnotify-0.7.8/debian/tests/build 2019-08-14 03:48:50.000000000 -0700
+++ libnotify-0.7.8/debian/tests/build 2019-12-08 13:39:28.000000000 -0800
@@ -9,6 +9,13 @@
WORKDIR=$(mktemp -d)
trap "rm -rf $WORKDIR" 0 INT QUIT ABRT PIPE TERM
cd $WORKDIR
+
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+ CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+ CROSS_COMPILE=
+fi
+
cat <<EOF > libnotify_test.c
#include <libnotify/notify.h>
#include <assert.h>
@@ -33,8 +40,8 @@
}
EOF
-gcc -o libnotify_test libnotify_test.c \
-`pkg-config --cflags --libs libnotify` -Wall -Werror
+${CROSS_COMPILE}gcc -o libnotify_test libnotify_test.c \
+`${CROSS_COMPILE}pkg-config --cflags --libs libnotify` -Wall -Werror
echo "build: OK"
[ -x libnotify_test ]
dbus-run-session -- xvfb-run ./libnotify_test
diff -Nru libnotify-0.7.8/debian/tests/control
libnotify-0.7.8/debian/tests/control
--- libnotify-0.7.8/debian/tests/control 2019-08-14 03:48:50.000000000
-0700
+++ libnotify-0.7.8/debian/tests/control 2019-12-08 20:21:11.000000000
-0800
@@ -1,2 +1,2 @@
Tests: build
-Depends: build-essential, dbus (>= 1.8), notification-daemon, xauth, xvfb,
libnotify-dev, pkg-config
+Depends: build-essential, dbus (>= 1.8), notification-daemon:native, xauth,
xvfb, libnotify-dev, pkg-config
--- End Message ---
--- Begin Message ---
Source: libnotify
Source-Version: 0.7.9-2
Done: Simon McVittie <[email protected]>
We believe that the bug you reported is fixed in the latest version of
libnotify, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Simon McVittie <[email protected]> (supplier of updated libnotify package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 28 Nov 2020 16:27:35 +0000
Source: libnotify
Architecture: source
Version: 0.7.9-2
Distribution: unstable
Urgency: medium
Maintainer: Debian GNOME Maintainers
<[email protected]>
Changed-By: Simon McVittie <[email protected]>
Closes: 946443
Changes:
libnotify (0.7.9-2) unstable; urgency=medium
.
* Team upload
.
[ Steve Langasek ]
* Make autopkgtests cross-test-friendly (Closes: #946443)
.
[ Simon McVittie ]
* Preferentially build-depend on libgdk-pixbuf-2.0-dev.
We don't need the deprecated Xlib integration that is also pulled in
by the older libgdk-pixbuf2.0-dev package (see #974870).
* d/tests/build: Silence shellcheck warnings
* Silence Lintian warning for gtk-doc documentation (see #970275)
* d/upstream/metadata: Add.
* Standards-Version: 4.5.1 (no changes required)
* Set Rules-Requires-Root to no
Checksums-Sha1:
0d29927e678a59f091e49ce3c0321e12312bd91c 2691 libnotify_0.7.9-2.dsc
ac37267cf7c7c0d18f4e1110c9737067a2483f19 8736 libnotify_0.7.9-2.debian.tar.xz
9f6c74577eae3297b2eb65a44f7efcca87842dd2 14257
libnotify_0.7.9-2_source.buildinfo
Checksums-Sha256:
d0f93f857dff339bb0af636825ff984ad6badbe9870ccdd92533c1bbfccd3c4e 2691
libnotify_0.7.9-2.dsc
3fb0d9c736b74a9cc840da8785b74c8c1ceaf0d5b1942981786fe631c0df71ca 8736
libnotify_0.7.9-2.debian.tar.xz
815bb42a8f791f3feadb8a9f03038a939af43e4229a9f6afbfba197c6cfb64ad 14257
libnotify_0.7.9-2_source.buildinfo
Files:
cabcbcff5a3b51114cfe107d44115920 2691 libs optional libnotify_0.7.9-2.dsc
1d37b95fc66278f0beebf9067eacc17a 8736 libs optional
libnotify_0.7.9-2.debian.tar.xz
bcabebca0874cbea921bc3975ddc15ec 14257 libs optional
libnotify_0.7.9-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEENuxaZEik9e95vv6Y4FrhR4+BTE8FAl/C5+sACgkQ4FrhR4+B
TE8ZtxAAs5i4p5+piUWqm35+GpUA4CicpRQY3IapYJfFvrdvCesR4mILOHodsv00
TwiRDmFhadf3FhWBetcc6n5GtAR7Sg69BIRTXKg4Cpsdmlv7T1GRhnzwoovqDC4C
axRW3Z77e1Z+C2sftj1gmg63s37fchKthhXfijtKNgINOp3kqH+ROQ3p+BFIjKip
a63SSr7fUw77Z40JcZ4OzBlB5Y1Vu4Q7inrw7Lk2o/A/aSJLXGjlnGWkh1NClR89
o1NCSpDEHAvQGdh9ptaGlgsdfID/DhPgzgk2QnRD0erc3PYpg0hbHXIjr9YiugVb
qszTrPXQB8eMCNfFlSvXC6unc2Si5nyz8JIFi6AFUgPosdHqVMaLuvBBoJCYX0X8
Fh6Vt4g9NqlbKZvxW1ZuuXMDBc40FZxFwEnqMZul+rOsPmLc2KA24Zdtq5hUwek3
+o+OsLSm/PAdl0FlMNrq7dOfYUHCM2meGz1MuvR1kl4XHS9qhr1aJCLPcdFMN2xQ
zvNJXe9MEnUsLg/VfJ766rYFODc0RYMuHFiksXSR7/4DhZ0PCWlpwgRV/S1rN5XQ
ZtO0lzll4/acRKDLig/4L3eqnsgeguARzZNb2nEZZcJN+RV3+N0VN5kNx3ZNj2CF
ohR81CNc8Sw7t6z25EDxEjrVQYtY51UQVI8egjzcqVr6qjQfsSA=
=mcH1
-----END PGP SIGNATURE-----
--- End Message ---
