Your message dated Tue, 16 May 2006 17:43:10 +0200
with message-id <[EMAIL PROTECTED]>
and subject line Bug#333653: liblircclient0: Realloc call in lirc_client.c is
one byte short
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: liblircclient0
Version: 0.7.1pre2-10
Severity: normal
Tags: Patch
Trying to track down a different error, valgrind pointed out that the
realloc call in lirc_nextcode is off by one, as it fails to include
the extra byte that was originally malloc'd to hold the NULL terminating
the string.
This patch fixes it.
--- tools/lirc_client.c.org 2005-10-13 16:10:17.000000000 +1000
+++ tools/lirc_client.c 2005-10-13 15:53:14.000000000 +1000
@@ -1483,7 +1483,7 @@ int lirc_nextcode(char **code)
char *new_buffer;
packet_size+=PACKET_SIZE;
- new_buffer=(char *) realloc(lirc_buffer,packet_size);
+ new_buffer=(char *) realloc(lirc_buffer,packet_size+1);
if(new_buffer==NULL)
{
return(-1);
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (990, 'unstable'), (950, 'unstable'), (900, 'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
--
Paul "TBBle" Hampson, [EMAIL PROTECTED]
8th year CompSci/Asian Studies student, ANU
Shorter .sig for a more eco-friendly paperless office.
pgpfIf03yjHi5.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Hi,
This bug has been fixed somewhere between version 0.7.1pre2-10 and
version 0.8.0-2 (version in unstable). I am therefore closing the bug.
Bye,
Aurelien
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian GNU/Linux developer | Electrical Engineer
`. `' [EMAIL PROTECTED] | [EMAIL PROTECTED]
`- people.debian.org/~aurel32 | www.aurel32.net
--- End Message ---
