Your message dated Sat, 02 Jan 2021 23:50:58 +0000
with message-id <[email protected]>
and subject line Bug#970508: fixed in dialog 1.3-20201126-1
has caused the Debian Bug report #970508,
regarding dialog: --aspect and --tab-len options don't work
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
970508: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=970508
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dialog
Version: 1.3-20190211-ca-003-1
Severity: normal
Tags: patch upstream
The --aspect and --tab-len options are processed in the process_common_options
subroutine called from main. The code changes the corresponding members of the
dialog_state structure. After this has happened, the code in main calls then
init_dialog routine which unconditionally sets both the aspect ratio and the
tab len to its default value, thereby overwriting any changes which happened
as part of options processing.
The patch fixes this by changing the init_dialog code such that it only sets
these members to their default values if they don't have a value already (ie,
if their value is 0). It also removes a redundant "set aspect ratio to default
if still 0" statement from process_common_options.
-- System Information:
Debian Release: 10.5
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.19.0-8-amd64 (SMP w/24 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages dialog depends on:
ii debianutils 4.8.6.1
ii libc6 2.28-10
ii libncursesw6 6.1+20181013-2+deb10u2
ii libtinfo6 6.1+20181013-2+deb10u2
dialog recommends no packages.
dialog suggests no packages.
-- no debconf information
diff --git a/dialog.c b/dialog.c
index b6fa6d4..6ec740d 100644
--- a/dialog.c
+++ b/dialog.c
@@ -1827,9 +1827,6 @@ process_common_options(int argc, char **argv, int offset,
bool output)
offset++;
}
- if (dialog_state.aspect_ratio == 0)
- dialog_state.aspect_ratio = DEFAULT_ASPECT_RATIO;
-
return offset;
}
diff --git a/util.c b/util.c
index 64b67d9..e0a5938 100644
--- a/util.c
+++ b/util.c
@@ -322,8 +322,10 @@ init_dialog(FILE *input, FILE *output)
setlocale(LC_ALL, "");
dialog_state.output = output;
- dialog_state.tab_len = TAB_LEN;
- dialog_state.aspect_ratio = DEFAULT_ASPECT_RATIO;
+ if (dialog_state.tab_len == 0)
+ dialog_state.tab_len = TAB_LEN;
+ if (dialog_state.aspect_ratio == 0)
+ dialog_state.aspect_ratio = DEFAULT_ASPECT_RATIO;
#ifdef HAVE_COLOR
dialog_state.use_colors = USE_COLORS; /* use colors by default? */
dialog_state.use_shadow = USE_SHADOW; /* shadow dialog boxes by
default? */
--- End Message ---
--- Begin Message ---
Source: dialog
Source-Version: 1.3-20201126-1
Done: Santiago Vila <[email protected]>
We believe that the bug you reported is fixed in the latest version of
dialog, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Santiago Vila <[email protected]> (supplier of updated dialog package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 03 Jan 2021 00:25:00 +0100
Source: dialog
Architecture: source
Version: 1.3-20201126-1
Distribution: unstable
Urgency: medium
Maintainer: Santiago Vila <[email protected]>
Changed-By: Santiago Vila <[email protected]>
Closes: 915949 942025 954185 954220 970508 973318
Changes:
dialog (1.3-20201126-1) unstable; urgency=medium
.
* New upstream release.
* Fix automatic box height. Closes: #915949.
* Fix return code for last-key feature. Closes: #942025.
* Backtitle should no longer disappear on resize. Closes: #954185.
* Fix program abort on resize. Closes: #954220.
* Fix options --aspect and --tab-len. Closes: #970508.
* Add Multi-Arch: foreign. Closes: #973318.
* Switch to dh.
Checksums-Sha1:
a3cba88166eed1c2746ac16244d7af09254329ed 1714 dialog_1.3-20201126-1.dsc
b8ae21603ac1e28c1aa50d7c465d0f4c807e6201 555473 dialog_1.3-20201126.orig.tar.gz
b76671ff30ad260192d0c4e2f09ed6051924b04f 265
dialog_1.3-20201126.orig.tar.gz.asc
22d8ac23820d318cf8090e0a110100235999a3fc 11364
dialog_1.3-20201126-1.debian.tar.xz
279f44beadb8726b0fbc9d062f2595b08b1dcf9b 5103
dialog_1.3-20201126-1_source.buildinfo
Checksums-Sha256:
09b799cd6b83e0972c9fe37ca9fb9fa096223b455f36554515dea91fa2416467 1714
dialog_1.3-20201126-1.dsc
c9233a6c8ea33a59e2378e5146ae2bd13b519744cfdb647af7420adac5ad3866 555473
dialog_1.3-20201126.orig.tar.gz
04f69934acdb3c3a01a3bcb4180501869c54ebc5d51f67282e34ab14056540ec 265
dialog_1.3-20201126.orig.tar.gz.asc
a8ad7361b7021af458ff060e454b1afcc545995cfc5a653462df738a5ad51505 11364
dialog_1.3-20201126-1.debian.tar.xz
3f8fe14d3d65965e0f8529f9ac870790d19f903f620a06f04ebe5ed84be359e2 5103
dialog_1.3-20201126-1_source.buildinfo
Files:
16866f434f8f5d0694fe3f211413a9cd 1714 misc optional dialog_1.3-20201126-1.dsc
14bf3b33de348838ff30aff0aa9d1c2e 555473 misc optional
dialog_1.3-20201126.orig.tar.gz
e7054d1c8bd94f160fe506fd3943f41a 265 misc optional
dialog_1.3-20201126.orig.tar.gz.asc
c3a02c9f2b2badbe7fd8010872455f38 11364 misc optional
dialog_1.3-20201126-1.debian.tar.xz
7d2903952495fc8a57a91fa6c27f9879 5103 misc optional
dialog_1.3-20201126-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEE1Uw7+v+wQt44LaXXQc5/C58bizIFAl/xASwACgkQQc5/C58b
izJ4jgf/Vw7BJdo8IZEzQ/x/Zinrsa9QWlqSbZJs58nBFi414FduJmA0nttNNFpG
wL/95E9ZCbC6ca/akw1rQ4uHweEpeOqp/HoOcKsR9QaLSBPFfdY7W25Gc1W+IXZg
Kkbnu9XeFRsSm188P5N+juGWUUlHPPCTzNjLt7dNQH0hrt2z2+ipI9Twpkc0+F2o
t30CGspxG7+loRdPOkIUR2qPeZtKW4EcA0vhKJUx1onHyRVlLFYseldfm57DuANg
UiEzuaoYyC+LCZ5HYmqHDC+wotvrzITCJ3vaBo6l9jlD30XCTOndLTHdwJgYxRM6
pu1X+bYEulcWVUKMnNM4Z3i5/IeXpQ==
=jk+C
-----END PGP SIGNATURE-----
--- End Message ---
