Your message dated Sun, 10 Jan 2021 17:33:35 +0000
with message-id <[email protected]>
and subject line Bug#830847: fixed in lm-sensors 1:3.6.0-3
has caused the Debian Bug report #830847,
regarding lm-sensors: initscript stop and restart actions should ensure the
process has stopped before returning
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
830847: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=830847
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: lm-sensors
Version: 1:3.4.0-3
Tags: patch
User: [email protected]
Usertags: initscript-actions
Dear maintainer,
lm-sensors's initscript does not check whether the process has actually
terminated before returning successfully.
This can result in a non-deterministic race condition where resources
that are required by a corresponding "start" or "restart" action (eg.
TCP ports, exclusive filesystem locks, etc.) are not yet available to
the new instance because the older process is still releasing them in
the background.
This then results in the new process failing to start which is often
hidden from the sysadmin for some time unless a monitoring system is
in use. Note that adding "sleep" calls merely masks the problem and
is thus not a valid fix.
For the same/parallel reasons, the stop and restart actions should
return a non-zero exit code if the daemon failed to stop.
Patch attached.
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
diff --git a/debian/fancontrol.init b/debian/fancontrol.init
index 2caa3d6..f14df72 100644
--- a/debian/fancontrol.init
+++ b/debian/fancontrol.init
@@ -40,13 +40,13 @@ case "$1" in
;;
stop)
log_daemon_msg "Stopping $DESC" "$NAME"
- start-stop-daemon --stop --quiet --pidfile $PIDFILE --oknodo --startas
$DAEMON $CONF
+ start-stop-daemon --stop --quiet --pidfile $PIDFILE --oknodo --retry 30
--startas $DAEMON $CONF
+ ret=$?
rm -f $PIDFILE
- log_end_msg $?
+ log_end_msg $ret
;;
restart)
$0 stop
- sleep 3
$0 start
;;
force-reload)
@@ -55,12 +55,10 @@ case "$1" in
fi
;;
status)
- status_of_proc $DAEMON $NAME $CONF && exit 0 || exit $?
+ status_of_proc $DAEMON $NAME $CONF
;;
*)
log_success_msg "Usage: /etc/init.d/fancontrol
{start|stop|restart|force-reload|status}"
exit 1
;;
esac
-
-exit 0
diff --git a/debian/sensord.init b/debian/sensord.init
index 4d70d43..90e19df 100644
--- a/debian/sensord.init
+++ b/debian/sensord.init
@@ -40,12 +40,11 @@ case "$1" in
;;
stop)
log_daemon_msg "Stopping $DESC" "$NAME"
- start-stop-daemon --stop --quiet --pidfile $PIDFILE --oknodo --exec
$DAEMON
+ start-stop-daemon --stop --quiet --pidfile $PIDFILE --oknodo --retry 30
--exec $DAEMON
log_end_msg $?
;;
restart)
$0 stop
- sleep 1
$0 start
;;
force-reload)
@@ -54,11 +53,9 @@ case "$1" in
fi
;;
status)
- status_of_proc $DAEMON $NAME && exit 0 || exit $?
+ status_of_proc $DAEMON $NAME
;;
*)
echo "Usage: /etc/init.d/sensord
{start|stop|restart|force-reload|status}"
exit 1
esac
-
-exit 0
--- End Message ---
--- Begin Message ---
Source: lm-sensors
Source-Version: 1:3.6.0-3
Done: Aurelien Jarno <[email protected]>
We believe that the bug you reported is fixed in the latest version of
lm-sensors, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Aurelien Jarno <[email protected]> (supplier of updated lm-sensors package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 10 Jan 2021 17:58:28 +0100
Source: lm-sensors
Architecture: source
Version: 1:3.6.0-3
Distribution: unstable
Urgency: medium
Maintainer: Aurelien Jarno <[email protected]>
Changed-By: Aurelien Jarno <[email protected]>
Closes: 830847 973521
Changes:
lm-sensors (1:3.6.0-3) unstable; urgency=medium
.
* Bump debhelper compatibility to 13.
* Bump Standards-Version to 4.5.1 (no changes).
* Update fancontrol.service to use the /run directory instead of /var/run.
Closes: #973521.
* Ensure the process has stopped before returning in fancontrol initscript.
Closes: #830847.
Checksums-Sha1:
55bcbdb0efd59849dcf9b631f72aa10670ac3530 2004 lm-sensors_3.6.0-3.dsc
114b3b6b40fdff24776de9dac2a7ca49cd39e538 25868 lm-sensors_3.6.0-3.debian.tar.xz
6e4a7bb3690e9da5a4e22afa3d2bf6873c0e4795 5598
lm-sensors_3.6.0-3_source.buildinfo
Checksums-Sha256:
5d24dc089f800ae4674a11d06d4490fcf9bc1cd6c186b10cc82ed4884c1da585 2004
lm-sensors_3.6.0-3.dsc
eaabd73b23aebcd4be722351906a5e9d3f0306a48b1ed8e1db060aaa4272faca 25868
lm-sensors_3.6.0-3.debian.tar.xz
31b2e78a4e00a5a822fbf580740663610022c6f54c049f9d664b46b47b5487d8 5598
lm-sensors_3.6.0-3_source.buildinfo
Files:
d8e66ab258c7f11e48b31a8a283ebc36 2004 utils optional lm-sensors_3.6.0-3.dsc
a4e385a8ef7960c1a4b00aebcd4d2e9d 25868 utils optional
lm-sensors_3.6.0-3.debian.tar.xz
ec35cefc0e252ba018ab2b3a4bebfea4 5598 utils optional
lm-sensors_3.6.0-3_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEUryGlb40+QrX1Ay4E4jA+JnoM2sFAl/7OLkACgkQE4jA+Jno
M2uX4w//eHz10NAmSuXJIPqnrsYA4vrICfHiLxKwrHJXV1mLml9zBS3gXgR5/NZy
LBwY//XHW4sb7IEQOd9+mqaeFlGW+PVslwKMyKtwP5Pu7NpjQDjYblLP+W4yuRHd
cw9m86isze7s4mjg3MBQASDx9vS3EB2Lg2TLPU2b2i7bXsg217fun9ZAqjMmnhj+
UxJEC93abWW7a5ozoGy/ELZ1a8BRtDf7PIfYUmNNu5qOM7cnopP4PiDr4FrNzC7U
SniGyTqSIyDBqeWtoLeciPre7x1uBFbsQR/KB7PU1lR5cONrYFnXq8Y83uFIQSz5
qd48ap0Fmmb8j0AI36Tf4OVz4iJ5Ors0GXmNfzIMUVcPrmm4ByuD4loln/hCrK42
G1lcq/+zI7W3b5Xi5Luulk3r8bu13LJWtpUDLhTSQWcX6eV+f4xmeRo+JI5+dQgW
LEdKY+iQCdzW9bz09e15ZrffadcBNVob3t43hJUnp5VDUwkrowzk02L+JnJ4RNYS
yuhjsk3jC+QmqxpkOrfUFloE2Zobkc4c51axVy1RcKG8tO5zbY3IA1vFecvfKlso
Yv4jvf4HrHjqylHayScvOeIEYTot6M4hCvSqi6czQtBwnMOz5LugW/IrUXqPh4+u
IB5TWch8bTWSK/mcxML/Wm0DYUQgGS+ykGMcqip+tGSGgxsr2YY=
=W88f
-----END PGP SIGNATURE-----
--- End Message ---
