Your message dated Sat, 16 Jan 2021 13:49:41 +0000
with message-id <[email protected]>
and subject line Bug#978742: fixed in mmdebstrap 0.7.4-1
has caused the Debian Bug report #978742,
regarding mmtarfilter: Slow performance with many path exclusions
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
978742: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=978742
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: mmdebstrap
Version: 0.7.3-1
Severity: normal
File: /usr/bin/mmtarfilter
X-Debbugs-Cc: [email protected]

With a large number of path exclusions specified (around 500),
mmtarfilter starts to become a noticeable performance bottleneck.

It looks like mmtarfilter checks each file linearly against each filter
using fnmatch.

Python's fnmatch implementation works by translating shell patterns into regular
expressions. Python also provides a function to do that translation
separate from fnmatch. One fairly simple optimization would be to walk the list 
of
patterns *once*, take each series of consecutive exclude or include
filters, turn each one into a regex, join all the regexes in
each group together using (?:...)|(?:...) , and compile the resulting
regexes once. That should provide a substantial performance improvement.

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 
'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.9.0-5-amd64 (SMP w/4 CPU threads)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages mmdebstrap depends on:
ii  apt      2.1.15
ii  perl     5.32.0-6
ii  python3  3.9.1-1

Versions of packages mmdebstrap recommends:
pn  arch-test            <none>
pn  fakechroot           <none>
ii  fakeroot             1.25.3-1.1
ii  gpg                  2.2.20-1
pn  libdistro-info-perl  <none>
ii  mount                2.36.1-4
pn  uidmap               <none>

Versions of packages mmdebstrap suggests:
ii  apt [apt-transport-https]  2.1.15
pn  apt-transport-tor          <none>
ii  apt-utils                  2.1.15
pn  binfmt-support             <none>
ii  ca-certificates            20200601
ii  debootstrap                1.0.123
ii  distro-info-data           0.45
ii  dpkg-dev                   1.20.5
pn  perl-doc                   <none>
pn  proot                      <none>
pn  qemu-user                  <none>
pn  qemu-user-static           <none>
pn  squashfs-tools-ng          <none>

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: mmdebstrap
Source-Version: 0.7.4-1
Done: Johannes 'josch' Schauer <[email protected]>

We believe that the bug you reported is fixed in the latest version of
mmdebstrap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Johannes 'josch' Schauer <[email protected]> (supplier of updated mmdebstrap 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 16 Jan 2021 14:28:29 +0100
Source: mmdebstrap
Architecture: source
Version: 0.7.4-1
Distribution: unstable
Urgency: medium
Maintainer: Johannes 'josch' Schauer <[email protected]>
Changed-By: Johannes 'josch' Schauer <[email protected]>
Closes: 978733 978742
Changes:
 mmdebstrap (0.7.4-1) unstable; urgency=medium
 .
   * new upstream release
      - Optimize mmtarfilter to handle many path exclusions (closes: #978742)
      - Do not run an additional env command inside the chroot (closes: #978733)
Checksums-Sha1:
 165664f8082c68f7c2e52df231b71cbe108cd6b0 2299 mmdebstrap_0.7.4-1.dsc
 e6a39a67534eaa5d121869b04e24552e97095b71 97038 mmdebstrap_0.7.4.orig.tar.gz
 709d7c283f1aa69f4467e4177c7b6a0e0578c0df 9700 mmdebstrap_0.7.4-1.debian.tar.xz
Checksums-Sha256:
 202adf5b93a31d281d0444bab2df52330e650b94e74c66aeb59b1beeda0f9df2 2299 
mmdebstrap_0.7.4-1.dsc
 5fb625e6819ed8d70e766cb6f4fe196471c34b1014eb238cf55ccf718159cc27 97038 
mmdebstrap_0.7.4.orig.tar.gz
 9cd3b30ebc7f4499c3bb65e1821cdd780a96af833945c0dc6b18663d34d8e2f6 9700 
mmdebstrap_0.7.4-1.debian.tar.xz
Files:
 53ec9ee8984f47c7c38b9ac609df4e62 2299 admin optional mmdebstrap_0.7.4-1.dsc
 fdffed825c630fed786b68024748cdf9 97038 admin optional 
mmdebstrap_0.7.4.orig.tar.gz
 e48949736381ab99f084c0151ee708d0 9700 admin optional 
mmdebstrap_0.7.4-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElFhU6KL81LF4wVq58sulx4+9g+EFAmAC64MACgkQ8sulx4+9
g+F3rA/9HTygRS/GWrUZ+myixE16pq9uS85cQCIIfWQEFh9Do2lTpa4+E4OfeLdB
MHd7hKZVPpWG5KFqQkzxurvv+x/U/AnyRZSWsIVYoPaGe20IeJUVdt6J381Fa8Lw
f/xUW/M0rk0nxp8Uq2cyJM7UcMNojJMZOSFYjN7kjpfb4f4uCXz2p4mxVBtSjpBj
KsYjQT+joT9wqtIYErWmj92EG24zw8GvdDNPd+xzbQcpgMljkpzdDml0A7DkxJJp
goEZ6gmcAnEkIf2a8JKGYSpSic7iITb4a2W7lvbWExfDDtxCBUSFDbHXBVedEFB5
5E1iVgrXXvRoZgAXi4LHGaFhZ7ZF6HizS+bEGy3WLBOJMNhGd7mpxZL2YJr+DrzY
p5CwD2d70KJ4UOS4Oso4bZXs9LMSUn8xErAP/qKCyyCdxJl7UnPsasbDzCpbXQrU
/RQ2SCu9p7HW2PLiAyAz6mZ/Rw4xdh4TjiPYU9IAaREd7Bs9JqV2zukhvzZGFRBP
iKiniEnXY2PZkJ59dJvx3RYHERO+B6aegmh7xi9OBnI/JzVikIInIiQV4wBx89fh
G66SG5i8SepM/bLWCLKHX33LUH5+goB3RcDzbVZjSGIaq/jtbD+cQjjVkQVNzPgB
ljJ6k1VMaO5YYuCshPgyJ1pDF+ESrskxJk8GpyErblM1NbFYuOQ=
=NbAV
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to