Your message dated Wed, 27 Jan 2021 10:34:23 +0000
with message-id <[email protected]>
and subject line Bug#978530: fixed in libvshadow 20190323-2
has caused the Debian Bug report #978530,
regarding libvshadow: memory tests fundamentally broken, please disable them on
riscv64
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
978530: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=978530
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libvshadow
Version: 20190323-1.1
Severity: normal
Tags: ftbfs patch upstream
User: [email protected]
Usertags: riscv64
Hi,
libvshadow fails to build on riscv64:
https://buildd.debian.org/status/fetch.php?pkg=libvshadow&arch=riscv64&ver=20190323-1.1&stamp=1580585132&raw=0
This is due to fundamentally broken tests assuming that memcpy and
memset can fail returning NULL, and interposing these libc functions in
the tests with functions that sometimes return NULL. This tests should
be simply removed as they do not make sense. See bug #978433 for more
details as the same code is basically replicated in dozen of packages.
A simpler way to fix the issue for riscv64 is to disable all memory
tests on this architecture, as it is already done for a long list of
cases. This is what the patch below does:
--- libvshadow-20190323/debian/patches/01-disable-memory-tests-on-riscv64.patch
1970-01-01 01:00:00.000000000 +0100
+++ libvshadow-20190323/debian/patches/01-disable-memory-tests-on-riscv64.patch
2020-12-27 14:51:29.000000000 +0100
@@ -0,0 +1,11 @@
+--- libvshadow-20190323.orig/tests/vshadow_test_memory.h
++++ libvshadow-20190323/tests/vshadow_test_memory.h
+@@ -28,7 +28,7 @@
+ extern "C" {
+ #endif
+
+-#if defined( HAVE_GNU_DL_DLSYM ) && defined( __GNUC__ ) && !defined(
LIBVSHADOW_DLL_IMPORT ) && !defined( __arm__ ) && !defined( __clang__ ) &&
!defined( __CYGWIN__ ) && !defined( __hppa__ ) && !defined( __mips__ ) &&
!defined( __sparc__ ) && !defined( HAVE_ASAN )
++#if defined( HAVE_GNU_DL_DLSYM ) && defined( __GNUC__ ) && !defined(
LIBVSHADOW_DLL_IMPORT ) && !defined( __arm__ ) && !defined( __clang__ ) &&
!defined( __CYGWIN__ ) && !defined( __hppa__ ) && !defined( __mips__ ) &&
!defined( __sparc__ ) && !defined( __riscv ) && !defined( HAVE_ASAN )
+ #define HAVE_VSHADOW_TEST_MEMORY 1
+ #endif
+
--- libvshadow-20190323/debian/patches/series 1970-01-01 01:00:00.000000000
+0100
+++ libvshadow-20190323/debian/patches/series 2020-12-27 14:51:29.000000000
+0100
@@ -0,0 +1 @@
+01-disable-memory-tests-on-riscv64.patch
Regards,
Aurelien
--- End Message ---
--- Begin Message ---
Source: libvshadow
Source-Version: 20190323-2
Done: Sebastien Delafond <[email protected]>
We believe that the bug you reported is fixed in the latest version of
libvshadow, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sebastien Delafond <[email protected]> (supplier of updated libvshadow package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 27 Jan 2021 10:03:41 +0100
Source: libvshadow
Architecture: source
Version: 20190323-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Security Tools <[email protected]>
Changed-By: Sebastien Delafond <[email protected]>
Closes: 978530
Changes:
libvshadow (20190323-2) unstable; urgency=medium
.
[ Samuel Henrique ]
* Configure git-buildpackage for Debian
.
[ Debian Janitor ]
* Use secure copyright file specification URI.
* Set debhelper-compat version in Build-Depends.
* Set upstream metadata fields: Bug-Database, Bug-Submit, Repository,
Repository-Browse.
* Update standards version to 4.5.0, no changes needed.
* Remove Section on libvshadow1 that duplicates source.
* Update watch file format version to 4.
* Use cross-build compatible macro for finding pkg-config.
.
[ Sébastien Delafond ]
* Disable memory tests on riscv-64 (Closes: #978530)
Checksums-Sha1:
c3733aca6b0e6e5d4aa1fd276c6c22d9b015c1cc 1881 libvshadow_20190323-2.dsc
005cefe144d57d59bd17d9a0cbf7063a33c089af 4656
libvshadow_20190323-2.debian.tar.xz
b9d2170f536d7295569df1e0b99fb09965a689a1 8558
libvshadow_20190323-2_amd64.buildinfo
Checksums-Sha256:
35e07415e5f4315220c37c290bd19649d709dcaa1b2553a892648e8ab09d7631 1881
libvshadow_20190323-2.dsc
e1baa2f28f22abf826f7c075348d564a450f69c4bddbc4cf939abeafa3f752db 4656
libvshadow_20190323-2.debian.tar.xz
88e9b35fa27e458f4ae4601e087907cbbf1a7ae8d935beac1970a380fc912f3a 8558
libvshadow_20190323-2_amd64.buildinfo
Files:
6438122a9fb8bec3175ee9855f06abd8 1881 libs optional libvshadow_20190323-2.dsc
a25290b6b0bb48a46c44a1c47eeaef7f 4656 libs optional
libvshadow_20190323-2.debian.tar.xz
f7da5982e5f28528153e10d0b835c1cf 8558 libs optional
libvshadow_20190323-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEAqSkbVtrXP4xJMh3EL6Jg/PVnWQFAmARPlYACgkQEL6Jg/PV
nWR4IAgArSD61+qWJqREAvScx6EiXvWt6UMZKQGz4d/0n2JAXFCOysrf5hiOuhOA
qxLbQbX1kPVwBNtdRiRUeXipbrZBRzLo5l20HBkogJQ3A3lo9u3QHbpUjfIJ0w+g
Ftfw0l/hJLT7UIz0J79SWUr+ghf+qLFN11794jy86AEr+PXTgjjjKdmMwyVpmPbb
tnT4fwOGeKH8Z0vv1BWPoM7/QPvS6hY1IW1i5IB0xbYmlDIB3by90KhwNUBF1UMi
Wd5af0oh06w1HkzHyzMkdO1mzOUEiMA1M/dyOob89uMejI45K2M4TE2FxmhTaQc4
8TXyuoXpaXVphHrVyN1P/xYFt3NcCw==
=i3L2
-----END PGP SIGNATURE-----
--- End Message ---
