Your message dated Sun, 31 Jan 2021 21:04:43 +0000
with message-id <[email protected]>
and subject line Bug#861537: fixed in detox 1.3.2-1
has caused the Debian Bug report #861537,
regarding detox: causes malformed UTF-8 characters when no default character is 
set - fails to "fall through"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
861537: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861537
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: detox
Version: 1.2.0-5
Severity: normal
Tags: upstream patch

Dear Maintainer,

detox does not "pass through" - that is, when configuring a .tbl table
file with not default, or "default" with nothing else on the line,
followed by those changes I want to achieve with my files, detox fails
to achieve desired outcome. Instead with certain UTF-8 characters, detox
creates malformed output characters (i.e. incomplete).

Here's an example of what I cannot achieve with detox (only changing a
few problematic chars, keeping all the greek, cyrillic etc chars),
running in uxterm (or xterm -u8):

$ cat /home/justa/etc/detox/ztest.tbl
start
0x0026          _and_   # AMPERSAND

# Chars to translate to _
0x0020          _       # space
0x0021          _       # !
0x0022          _       # "
0x0024          _       # $
0x0027          _       # '
0x002a          _       # *
0x002f          _       # /
0x003a          _       # :
0x003b          _       # ;
0x003c          _       # <
0x003e          _       # >
0x003f          _       # ?
0x0040          _       # @
0x005c          _       # \
0x0060          _       # `
0x007c          _       # |

# Chars to translate to -
0x0028          -       # (
0x0029          -       # )
0x005b          -       # [
0x005d          -       # ]
0x007b          -       # {
0x007d          -       # }
end

$ cat ~/.detoxrc
sequence gnu {
   utf_8 {filename "/home/justa/etc/detox/ztest.tbl";};
};

$ env|egrep "LOC|LANG|UTF|utf|LC"
LC_ALL=zen.UTF-8
MAILCHECK=0
LANG=zen.UTF-8
XTERM_LOCALE=zen.UTF-8
 unset -v CLASSPATH_LOCAL;

$ # (my custom locale is just UTF-8 with a custom default date format)

$ touch "mÉ Æ.txt"

$ ls *txt; ls -l *txt; ls -lb *txt
mÉ Æ.txt
-rw------- 1 justa justa 0 Apr 30 22:04 mÉ Æ.txt
-rw------- 1 justa justa 0 Apr 30 22:04 mÉ\ Æ.txt


What I want is for the file "mÉ Æ.txt" to end up with the following
name:
 mÉ_Æ.txt


but instead as we can see:

$ detox -vs gnu *txt                                                            
                                                                                
                                      
Scanning: mÉ Æ.txt
mÉ Æ.txt -> m .txt

$ ls *txt; ls -l *txt; ls -lb *txt
m? ?.txt
-rw------- 1 justa justa 0 Apr 30 22:04 m? ?.txt
-rw------- 1 justa justa 0 Apr 30 22:04 m\207\ \204.txt


and we see that some malformed chars have been created,
(whatever that is, I'm not sure).


The patch, thanks to Vasily Kolobkov, is quite simple - basically just a
missing "continue;" is added in a couple of places, fixing up the
clean_safe and clean_iso8859_1 methods. There's probably a similar
change needed in clean_utf_8 method - this is not yet done.

Patch 1 is just the fix.

Patch 2 adds example table files for fine grained "cascading" in user
defined detox config sequences.

Patch 3 tidies up the "sample" filenames, which don't need to end with
".sample" and are actually required in a normal installation anyway, and
so e.g. on Debian stable, result in duplicate files (should be symlinks
at least, but shouldn't be duplicated anyway - DRY/ remove redunancy).




-- System Information:
Debian Release: 8.7
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500, 
'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-0.bpo.2-amd64 (SMP w/4 CPU cores)
Locale: LANG=zen.UTF-8, LC_CTYPE=zen.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set 
to zen.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages detox depends on:
ii  libc6  2.19-18+deb8u7

detox recommends no packages.

detox suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: detox
Source-Version: 1.3.2-1
Done: Joao Eriberto Mota Filho <[email protected]>

We believe that the bug you reported is fixed in the latest version of
detox, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joao Eriberto Mota Filho <[email protected]> (supplier of updated detox 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 31 Jan 2021 16:15:56 -0300
Source: detox
Architecture: source
Version: 1.3.2-1
Distribution: unstable
Urgency: medium
Maintainer: Joao Eriberto Mota Filho <[email protected]>
Changed-By: Joao Eriberto Mota Filho <[email protected]>
Closes: 861537
Changes:
 detox (1.3.2-1) unstable; urgency=medium
 .
   * New upstream version 1.3.2. (Closes: #861537)
   * debian/control: bumped Standards-Version to 4.5.1.
   * debian/copyright: updated upstream and packaging copyright years.
   * debian/tests/: added a new test and files to check #861537 (detox over
     UTF-8 filenames).
Checksums-Sha1:
 a0f92d524306c2f827ac4069cd4f12480781535d 1847 detox_1.3.2-1.dsc
 389f8ecc71a26dd1009d5c96dcf57e279acad9a5 104236 detox_1.3.2.orig.tar.gz
 a24901ee8619b53352911b8ba43f1760f5311624 6524 detox_1.3.2-1.debian.tar.xz
 8fe1a1340fb8be48158621225217859c8254cbd0 5688 detox_1.3.2-1_source.buildinfo
Checksums-Sha256:
 f9d688caab5921e7dfab592f58285b1de7babdff30f6710ff861588c5c655dfb 1847 
detox_1.3.2-1.dsc
 e9ca24faddda92d03234b3a72dc00139e3d8dca562d78c8e723c45e8384e9fc7 104236 
detox_1.3.2.orig.tar.gz
 f915de41844a870fc5d65e03df4fcb86a1a8b73ee1b709183b21d7456eed1331 6524 
detox_1.3.2-1.debian.tar.xz
 3e4cad24c1c975c3077d6c04adbe56ff77f92c8d70ac18f672bd11c44e201c48 5688 
detox_1.3.2-1_source.buildinfo
Files:
 e75510604cda3be1120b78429b37f9d2 1847 utils optional detox_1.3.2-1.dsc
 815910c5a2ea744ec6b347a4c96bc38c 104236 utils optional detox_1.3.2.orig.tar.gz
 9f189fe3df21dc8fa7a1a55de96321ab 6524 utils optional 
detox_1.3.2-1.debian.tar.xz
 a9f8ff47a4ce76411d7fe2ff109f710d 5688 utils optional 
detox_1.3.2-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENX3LDuyVoBrrofDS3mO5xwTr6e8FAmAXFEgACgkQ3mO5xwTr
6e/sZA//RcEaSSHdlCjm+yQTmwrqlJSA5SRjFSA4vn1SH82Ti5z7EZnD4tEOwg8x
sw03pcVa1cjxUtMFEo0UgXfOBzo8VwhI5DhMdHLES3QwB7HnlCio3KZ8dYDC5gnE
f5lN4YI4KOSZ3/Jn2xlWw1r67Ci6BwyNlhFnOSOy07qZjhAJkuNdON9Nu/dwq7YE
z7VzRAavygF7rOiKrBdHuOunfQZHcwIOQnTXbvyM8orLMqjGd082nBR+NqaSxIqg
DwOl73mf+NGUke1lNFrmtOrDqcwD9maIjpjB1jPC7m3aXv5NNso0O3fvWbkxlj/y
yEMneiAwazSLrSyjHLVYCQkSlbwHfBF82fIdlvBPgDEvPCWOqgVviBK2uRxzgbll
NuFJlzA3VeOH17VyT9+BlUpLj7tSUlzGEk3Tp+hYcIiD+Tyf+giYMz6YLHhW5JOH
zrwI/QG4/dct4ULsfotZkRiwwlGF7txWagrL7wBcY9HhX7rvY8zgeM5ux5Hw281y
JmCFCr9SDM7FeZqr18q046RSQLDPbL5W8hpsdCEW/Yg7i+Kim+2ai7voQqbzWUGn
OOY/Up4tRO9LJM10VcKyr5+8ESce3nUSggO8DvLvhag5AjKDqFwWAo1Hd+xtihqY
l6ZfbBiRxcGxVAo7wCe1r3ZKJsqtnHtsPYmE0niyOAkHgxuBces=
=84LY
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to