Your message dated Mon, 22 May 2006 18:11:55 -0400 with message-id <[EMAIL PROTECTED]> and subject line Bug#336604: messages inconsistent wrt spacing before exclamation mark has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: e2fsprogs Version: 1.38-2 Severity: minor e2fsprogs isn't consistent in its use of spaces before an exclamation mark. The patch below fixed this by removing some spaces. (Interestingly, I couldn't find the error message in the sources where I noticed this inconsistency, namely "group descriptors corrupted !"). diff -urN e2fsprogs-1.38~/ext2ed/dir_com.c e2fsprogs-1.38/ext2ed/dir_com.c --- e2fsprogs-1.38~/ext2ed/dir_com.c 2005-10-31 13:09:51.000000000 +0000 +++ e2fsprogs-1.38/ext2ed/dir_com.c 2005-10-31 13:17:37.000000000 +0000 @@ -19,7 +19,7 @@ We assume that the user reached here using the dir command of the inode type and not by using settype dir, so that init_dir_info is indeed called to gather the required information. -type_data is not changed ! It still contains the inode of the file - We handle the directory in our own +type_data is not changed! It still contains the inode of the file - We handle the directory in our own variables, so that settype ext2_inode will "go back" to the inode of this directory. First written on: April 28 1995 diff -urN e2fsprogs-1.38~/ext2ed/disk.c e2fsprogs-1.38/ext2ed/disk.c --- e2fsprogs-1.38~/ext2ed/disk.c 2005-10-31 13:09:51.000000000 +0000 +++ e2fsprogs-1.38/ext2ed/disk.c 2005-10-31 13:11:35.000000000 +0000 @@ -158,7 +158,7 @@ original=(unsigned char *) malloc (length*sizeof (unsigned char)); if (original==NULL) { - wprintw (command_win,"Fatal error - Can\'t allocate %lu bytes !"); + wprintw (command_win,"Fatal error - Can\'t allocate %lu bytes!"); refresh_command_win ();fclose (fp);return (0); } diff -urN e2fsprogs-1.38~/ext2ed/doc/ext2ed-design.sgml e2fsprogs-1.38/ext2ed/doc/ext2ed-design.sgml --- e2fsprogs-1.38~/ext2ed/doc/ext2ed-design.sgml 2005-10-31 13:09:51.000000000 +0000 +++ e2fsprogs-1.38/ext2ed/doc/ext2ed-design.sgml 2005-10-31 13:17:16.000000000 +0000 @@ -109,7 +109,7 @@ <Para> However, I didn't have the luxury of choice when I started my project - -Linux is a relatively new (and great !) operating system. The extended-2 +Linux is a relatively new (and great!) operating system. The extended-2 filesystem is even newer - Its first release lies somewhere in 1993 - Only passed two years until I started working on my project. </Para> @@ -143,7 +143,7 @@ </Para> <Para> -The kernel sources are a rare bonus ! You don't get everyday the full +The kernel sources are a rare bonus! You don't get everyday the full sources of the operating system. There is so much that can be learned from them, and it is the ultimate source - The exact answer how the kernel works is there, with all the fine details. At the first week I started to @@ -155,7 +155,7 @@ </Para> <Para> -However, this was exactly the interesting part ! It is frustrating to know +However, this was exactly the interesting part! It is frustrating to know it all from advance - I think that the discovery itself, bit by bit, is the key to a true learning and understanding. </Para> @@ -238,7 +238,7 @@ <Para> I didn't know almost anything of the structure of the ext2 filesystem. Reading the sources was not enough - I needed to experiment. However, a tool -for experiments in the ext2 filesystem was exactly my project ! - Kind of a +for experiments in the ext2 filesystem was exactly my project! - Kind of a paradox. </Para> @@ -1106,7 +1106,7 @@ The various commands are reached by the user through the <Literal remap="tt">dispatch</Literal> function. This is not surprising. The fact that can be surprising, at least in a first look, is that <Literal remap="tt">you'll find the dispatch call in many of my -own functions !</Literal>. +own functions!</Literal>. </Para> <Para> @@ -2321,7 +2321,7 @@ <Para> <Literal remap="tt">This is one of the best examples of the power of the object oriented design and of the dispatching mechanism. The operation is complicated, yet the -implementation is surprisingly short !</Literal> +implementation is surprisingly short!</Literal> </Para> <Para> @@ -2355,7 +2355,7 @@ </Para> <Para> -Note the number of the dispatch calls ! +Note the number of the dispatch calls! </Para> <Para> @@ -2366,13 +2366,13 @@ specific cd command</Literal> to take us from there (The object is <Literal remap="tt">dir</Literal>, so that <Literal remap="tt">dispatch</Literal> will call the <Literal remap="tt">cd</Literal> command of the <Literal remap="tt">dir</Literal> type). Note that a symbolic link following could bring us back to the root directory, -thus the innocent calls above treats nicely such a recursive case ! +thus the innocent calls above treats nicely such a recursive case! </Para> <Para> I feel that the above is <Literal remap="tt">intuitive</Literal> - I was expressing myself "in the language" of the ext2 filesystem - (Go to the inode, etc), and the code was -written exactly in this spirit ! +written exactly in this spirit! </Para> <Para> @@ -3136,7 +3136,7 @@ It will just <Literal remap="tt">CONTINUE</Literal> until the last entry. The returned structure (of type <Literal remap="tt">struct_file_info</Literal>) will have its number in the -<Literal remap="tt">dir_entry_num</Literal> field, and this is exactly the required number ! +<Literal remap="tt">dir_entry_num</Literal> field, and this is exactly the required number! </Para> </Sect2> diff -urN e2fsprogs-1.38~/ext2ed/doc/ext2fs-overview.sgml e2fsprogs-1.38/ext2ed/doc/ext2fs-overview.sgml --- e2fsprogs-1.38~/ext2ed/doc/ext2fs-overview.sgml 2005-10-31 13:09:51.000000000 +0000 +++ e2fsprogs-1.38/ext2ed/doc/ext2fs-overview.sgml 2005-10-31 13:21:31.000000000 +0000 @@ -126,7 +126,7 @@ </Sect1> <Sect1> -<Title>A filesystem - Why do we need it ?</Title> +<Title>A filesystem - Why do we need it?</Title> <Para> I thought that before we dive into the various small details, I'll reserve a @@ -139,7 +139,7 @@ <Para> Everyone knows the meaning of the word <Literal remap="tt">file</Literal> - A bunch of data put -somewhere. where ? This is an important question. I, for example, usually +somewhere. where? This is an important question. I, for example, usually throw almost everything into a single drawer, and have difficulties finding something later. </Para> diff -urN e2fsprogs-1.38~/ext2ed/init.c e2fsprogs-1.38/ext2ed/init.c --- e2fsprogs-1.38~/ext2ed/init.c 2005-10-31 13:09:51.000000000 +0000 +++ e2fsprogs-1.38/ext2ed/init.c 2005-10-31 13:10:39.000000000 +0000 @@ -476,7 +476,7 @@ { prepare_to_close (); - printf ("Killed by signal %d !\n",sig_num); + printf ("Killed by signal %d!\n",sig_num); exit (1); } diff -urN e2fsprogs-1.38~/misc/findsuper.c e2fsprogs-1.38/misc/findsuper.c --- e2fsprogs-1.38~/misc/findsuper.c 2005-10-31 13:09:51.000000000 +0000 +++ e2fsprogs-1.38/misc/findsuper.c 2005-10-31 13:16:26.000000000 +0000 @@ -153,7 +153,7 @@ exit(1); } - /* Now, go looking for the superblock ! */ + /* Now, go looking for the superblock! */ printf(_("starting at %Ld, with %d byte increments\n"), sk, skiprate); printf(_(" thisoff block fs_blk_sz blksz grp last_mount\n")); for (; lseek64(fd, sk, SEEK_SET) != -1 && -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable') Architecture: powerpc (ppc) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.12-1-powerpc Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Versions of packages e2fsprogs depends on: ii e2fslibs 1.38-2 ext2 filesystem libraries ii libblkid1 1.38-2 block device id library ii libc6 2.3.5-7 GNU C Library: Shared libraries an ii libcomerr2 1.38-2 common error description library ii libss2 1.38-2 command-line interface parsing lib ii libuuid1 1.38-2 universally unique id library e2fsprogs recommends no packages. -- debconf-show failed -- Martin Michlmayr http://www.cyrius.com/
--- End Message ---
--- Begin Message ---On Sun, Mar 05, 2006 at 03:01:56AM +0000, Martin Michlmayr wrote: > * Martin Michlmayr <[EMAIL PROTECTED]> [2005-12-27 11:48]: > > I guess if it wasn't fsck.ext3, it might have been the kernel. Yes, > > indeed: > > > > linux-2.6-2.6.14/fs/ext3/super.c: printk (KERN_ERR "EXT3-fs: > > group descriptors corrupted !\n"); > > Are you going to put a fix (for this minor spacing inconsistency) in > the kernel? In any case, I suppose this bug filed against e2fsprogs > can be closed since the message comes from the kernel. I was leaving this open as reminder to myself until I got around to dealling with it. I've submitted the patch to the kernel and it's in Andrew Morton's -mm tree. - Ted
--- End Message ---
