Your message dated Wed, 17 Mar 2021 18:18:24 +0000
with message-id <[email protected]>
and subject line Bug#985410: fixed in bioawk 1.0-4
has caused the Debian Bug report #985410,
regarding bioawk FTCBFS -- execute maketab during build
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
985410: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985410
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: bioawk
Version: 1.0-3
Severity: normal
Tags: patch
X-Debbugs-Cc: [email protected], [email protected]

Dear Maintainer,

Since bioawk seems to execute maketab to generate proctab.c which is not 
allowed during cross build
it could be simply built with build compiler to generate proctab.c

Since maketab binary is not being installed, such a compilation would
not give any exec format problems. I compared the output of ./maketab
i.e. proctab.c across amd64, i386 and arm64 as well as skimmed through
the code. Compiling this particular file with build compiler does not
seem like a problem.

I'm attaching my patch along, and will commit to salsa if it looks good.

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 5.7.0-2-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff --git a/debian/changelog b/debian/changelog
index e2280a3..f74bbe9 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+bioawk (1.0-4) UNRELEASED; urgency=medium
+
+  * d/p/cross.patch: Fix non-cross buildability
+  * Use dpkg buildtools to set CC and CC_FOR_BUILD
+
+ -- Nilesh Patra <[email protected]>  Wed, 17 Mar 2021 22:23:42 +0530
+
 bioawk (1.0-3) unstable; urgency=medium
 
   * Change test dependency from swarm to
diff --git a/debian/patches/cross.patch b/debian/patches/cross.patch
new file mode 100644
index 0000000..1b56827
--- /dev/null
+++ b/debian/patches/cross.patch
@@ -0,0 +1,14 @@
+Description: Compile maketab with build compiler, since it executes during 
build time - the generated proctab.c does not seem to vary across arches
+Author: Nilesh Patra <[email protected]>
+Last-Update: 2021-03-17
+--- a/Makefile
++++ b/Makefile
+@@ -53,7 +53,7 @@
+       ./maketab >proctab.c
+ 
+ maketab:      ytab.h maketab.c
+-      $(CC) $(CFLAGS) $(CPPFLAGS) maketab.c -o maketab $(LDFLAGS)
++      $(CC_FOR_BUILD) $(CFLAGS) $(CPPFLAGS) maketab.c -o maketab $(LDFLAGS)
+ 
+ names:
+       @echo $(LISTING)
diff --git a/debian/patches/series b/debian/patches/series
index a17d1e6..dea1943 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
 Makefile.patch
 hardening.patch
+cross.patch
diff --git a/debian/rules b/debian/rules
index dd4dd7e..fd7fd8d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,6 +1,8 @@
 #!/usr/bin/make -f
 export DH_VERBOSE = 1
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+DPKG_EXPORT_BUILDTOOLS = nonempty
+include /usr/share/dpkg/buildtools.mk
 
 %:
        dh $@

--- End Message ---
--- Begin Message ---
Source: bioawk
Source-Version: 1.0-4
Done: Nilesh Patra <[email protected]>

We believe that the bug you reported is fixed in the latest version of
bioawk, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nilesh Patra <[email protected]> (supplier of updated bioawk package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 17 Mar 2021 22:23:42 +0530
Source: bioawk
Architecture: source
Version: 1.0-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team 
<[email protected]>
Changed-By: Nilesh Patra <[email protected]>
Closes: 985410
Changes:
 bioawk (1.0-4) unstable; urgency=medium
 .
   * d/p/cross.patch: Fix non-cross buildability
   * Use dpkg buildtools to set CC and CC_FOR_BUILD
     (Closes: #985410)
Checksums-Sha1:
 e3dfd108e45f0391dad5a23f1197ed6ce0ecd8c9 2025 bioawk_1.0-4.dsc
 8ed2d80083a10e9d84620836f5b6759d5217f956 5268 bioawk_1.0-4.debian.tar.xz
 55ca97b176ebf26a69d5894c2bf646ae25852eb1 5705 bioawk_1.0-4_amd64.buildinfo
Checksums-Sha256:
 18688b2c672101e20420708550cd509550a95a4eba2a70046b3914df848a661d 2025 
bioawk_1.0-4.dsc
 570369085ec775800845a4798562d44732af97d589141c1e390b0a203c2aef32 5268 
bioawk_1.0-4.debian.tar.xz
 2f9a1ae02a43588f16adf995598d5b9be6983efb8f08ec99ddf029a609d906c7 5705 
bioawk_1.0-4_amd64.buildinfo
Files:
 61a87244e9e76db8afc9ffe71786bbb3 2025 science optional bioawk_1.0-4.dsc
 98b07c7a021ee9631fbb2f422c036ad8 5268 science optional 
bioawk_1.0-4.debian.tar.xz
 681f9b3cf0571186f199984f190b70ba 5705 science optional 
bioawk_1.0-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEEPpmlJvXcwMu/HO6mALrnSzQzafEFAmBSQ+YUHG5wYXRyYTk3
NEBnbWFpbC5jb20ACgkQALrnSzQzafFw0Q//a442e9tFcuROfTiy9R9uUFt2Y3IH
92xTWRn4CXnI8a+OEkidhA5NN33dAZK8rfB1YMpfUj+Rk6ZTgO/XQXDwJs5nG+sN
J6ltL5wL/yDb3sjsjpfw1Bfyy3W+b+OdNAobzD835M5Tg1qYtSk0nx2Mt9RPrprR
bZUxf0oDEOI2IKpXI9T+9Qfpj9oSxP9OiX5DSLOWOeEwKqz45bS5ioZl2hvvKVOJ
cvJzUYrvrpEr/HjrV+3SE/vSTpRltiMnvP0NSHpkk9Qf6+WPwwI5BhbFhWgubOLp
538xRLD068PLJJ4ObHQaIjnXI177SfHPeQqXqwuui6pXBZNE0zO9TYusYP1ZT7rx
i26lkdtsmNFnhU1Q923ZQoVmSAtI9GJDhK3Q0gXAEmhsnanFVGnD6L7TNquCJn57
b3AYGWk9qVBDKPa9tFbbXhxZLq73YPsnGAGkgVkIuuRd+vC/Z1eCwLgIez/1L14f
B8UHa6YUunRy2Vcc5JsV4WT6J+ti/LLlqRc7of/Hk72dkUyBPpH/y3ok+4isxSqJ
X8k8zY7+boYFD/rdAe4yUuv1DNYMcaevuLYgJ0YzUZsD2na0dW5RNTqHePQ3IQqC
kR5EMOejsWctgH6wxKzqTfynQdU97UMK8bfFOtefNa3ir0VpUuG3vu04LywYHLzd
fuVztGiJmyLMhc0=
=b+fc
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to