Your message dated Tue, 27 Jul 2021 23:33:32 +0000
with message-id <[email protected]>
and subject line Bug#991227: fixed in runit 2.1.2-41
has caused the Debian Bug report #991227,
regarding runit: Broken switch from SysVinit - needs hardreset
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
991227: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991227
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: runit
Version: 2.1.2-40
Severity: important
Tags: patch
X-Debbugs-Cc: [email protected]
The fix for #919699 introduced a regression described in #990774: when shutdown,
halt or reboot is called with parameters it does nothing. This includes the -f
flag.
A consequence is that the switch Sysvinit --> runit-init can be broken.
When plain shutdown or reboot are called (for instance by a graphical desktop
env),
SysVinit is told to enter runlevel 0 or 6, but then it expects halt -f or
reboot -f
to finish the job (but they are noop, so the system is left in a wierd state).
When reboot is called the system initate the shutdown process, then stops and
the user can login into emergency shell: from there, only if the user call
again reboot,
the system will complete the shutdown process (after about 15 seconds of
waiting).
If shutdown is called the system initate the shutdown process but then stops:
all
tty's are down, no way to login, and init does not complete the shutdown. From
there
one can only press the reset button.
Runit-init users are not affected only because, when stage3 returns (because
halt -f is a noop)
runit uses it's own internal code to poweroff or reboot.
The switch from systemd is not affected because systemd uses it's own internal
code
to perform the shutdown.
I've already tested that the patch for #990774, attached below,
fix this issue too
patch: (the last two lines with the -r flag are not strictly needed here )
--- ./shutdown.c 2020-01-13 01:07:09.185373016 +0100
+++ ./shutdown-new.c 2021-07-15 14:51:04.482088733 +0200
@@ -134,14 +134,16 @@
}
for (i = 1; i != argc; ++i) {
- if (strcmp(argv[i], "-f"))
+ if (strcmp(argv[i], "-f") == 0)
cfg->force = true;
- if (strcmp(argv[i], "--force"))
+ if (strcmp(argv[i], "--force") == 0)
cfg->force = true;
- if (strcmp(argv[i], "-w"))
+ if (strcmp(argv[i], "-w") == 0)
cfg->wtmp_only = true;
- if (strcmp(argv[i], "--wtmp-only"))
+ if (strcmp(argv[i], "--wtmp-only") == 0)
cfg->wtmp_only = true;
+ if (strcmp(argv[i], "-r") == 0)
+ cfg->action = ACTION_REBOOT;
}
}
-- System Information:
Debian Release: 11.0
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 5.7.0-1-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_FIRMWARE_WORKAROUND, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en
Shell: /bin/sh linked to /bin/dash
Init: runit (via /run/runit.stopit)
Versions of packages runit depends on:
ii libc6 2.31-12
ii sysuser-helper 1.3.5.1
Versions of packages runit recommends:
ii runit-init 2.1.2-41exp1
Versions of packages runit suggests:
ii socklog 2.1.0+repack-4+b1
-- Configuration Files:
/etc/default/runit changed [not included]
/etc/runit/ctrlaltdel changed [not included]
/etc/runit/runsvdir/single/sulogin/run [Errno 2] No such file or directory:
'/etc/runit/runsvdir/single/sulogin/run'
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: runit
Source-Version: 2.1.2-41
Done: Lorenzo Puliti <[email protected]>
We believe that the bug you reported is fixed in the latest version of
runit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Lorenzo Puliti <[email protected]> (supplier of updated runit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 25 Jul 2021 16:35:08 +0200
Source: runit
Architecture: source
Version: 2.1.2-41
Distribution: unstable
Urgency: medium
Maintainer: Lorenzo Puliti <[email protected]>
Changed-By: Lorenzo Puliti <[email protected]>
Closes: 990774 991227
Changes:
runit (2.1.2-41) unstable; urgency=medium
.
* Cherry-pick shutdown.c fixes from experimental
for incoming stable release:
- fix broken switch from SysVinit due to wrong
command line parsing logic (Closes: #991227)
- reboot the system with -r flag instead of poweroff
(Closes: #990774)
- Update shutdown(8) manpage
Checksums-Sha1:
e7c510f38bf36edbf93d734e0a3befd2cd7b0739 2263 runit_2.1.2-41.dsc
1e52fb26b9891f6246f3cdf5d0228df7da0d6d27 44952 runit_2.1.2-41.debian.tar.xz
8fa446e4627b1dba97c68f76d1bce1ad9d87e2e6 5799 runit_2.1.2-41_source.buildinfo
Checksums-Sha256:
adaefd46a3d4f6369b393871ffa3c736122bdbe9dd13968b42ebf9b5b44236ef 2263
runit_2.1.2-41.dsc
ea7bde97be18ae4ef4d10816dd33a2b942c403c8b62a7a9933a0ff0282d7473f 44952
runit_2.1.2-41.debian.tar.xz
1073956cb6b479780ec91ba79199651ed32281e2af7cca882de4de64051621a5 5799
runit_2.1.2-41_source.buildinfo
Files:
f9310e5b043a749f36a68a2d330a8023 2263 admin optional runit_2.1.2-41.dsc
025f21e2cdca5cea853c82341bf039f9 44952 admin optional
runit_2.1.2-41.debian.tar.xz
9b618f254123bba06b8e34fb865ef237 5799 admin optional
runit_2.1.2-41_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAmEAlCMACgkQweDZLphv
fH4PeBAAnpABURmTBkzkXtIWDoI3aELHgOuXpQeKmnDBS7a62oD6aZtDrKYPKk53
ZOkww1AvSQT1NjuF6rAXCBAN+lWYk5tctGcQn4gyNovqCC++N+S6THfMIu0X6P65
TXoYqG48bQhVrpPAUsP9zOXx4jZHFGVAs1cxmtATY3Yo9hx5S9UJ+NQuUpMhzuMH
zcZ9txPgkQKIl/1Eq5w49yrepEXjVoVJ16tS7MxOHHcyTcqosSRxQFFtDxn9As/r
ZrYCFj47M11vp0rT+LMNIZFf8ChdWeEBhIVErCdMTl2HK7uMurGWqfdhzna3qBYp
HqXVdkmC2R0mp0YzzaI5GQrEwymIYvh5jk0vr8FdX6KL4rIgQX7/kd6AHDc5A+yv
z5uAVcZogp8KfDyMyr6oU1XU/z17b8rswRXLUPa4uQ+hODMd0uw/j1MWY3Mf97RD
5PupH3ksdfaQgTM7eaz97AdDxUTIi3g+9tVzlJM97iOLP7bD4H05Uo7+z5I/2jTa
tvbx1CMGYKMKl2MGX6mnYbxrOhGd8NGjE4UT0GlQnxCTqebODyRFQJlFEUn4IHRs
MQvu688MHHcqfggMFx1FWvuesx2eYXMR/mlWWcLBL4DFvbngEJRepJ9ih18HaN0N
gBlQ0aIUQTs4JZRHjRQa82XB5xQo/ulgd2c8Ylb8DaBaukDHSNA=
=xTxx
-----END PGP SIGNATURE-----
--- End Message ---
