Your message dated Wed, 20 Oct 2021 00:03:29 +0000
with message-id <[email protected]>
and subject line Bug#988280: fixed in gftp 2.7.1~beta-1
has caused the Debian Bug report #988280,
regarding gftp: FTBFS on hurd-i386: fatal error: stropts.h: No such file or 
directory
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
988280: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988280
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gftp
Severity: important
Version: 2.7.0b-1
Tags: ftbfs,patch
User:hahawang
Usertags: hurd,hurd-i386

X-Debbugs-CC:[email protected],[email protected]

I decide to fix a broken package found at the recommended page(https://people.debian.org/~sthibault/out_of_date.txt)named `gftp`.

After I download the package source and try to build without any modifications under the debian hurd running in qemu (debian-hurd-20210219.img),  I got the following error.

```

pty.c:64:10: fatal error: stropts.h: No such file or directory
   64 | #include <stropts.h>
      |          ^~~~~~~~~~~
compilation terminated.

```

So that I decide to check the source code and find the following line:


```

#if !(defined(__FreeBSD__) || defined(__NetBSD__) || defined(__APPLE__) || defined(__linux__))
#include <stropts.h>
#endif

```

Obviously, the GNU Hurd also haven't the `stropt.h`, so It is better to add a check of GNU-hurd at this line. By following the document available at https://sourceforge.net/p/predef/wiki/OperatingSystems/,

I have fixed the build failure, patches avaiable at the end of this email.

Although, IMHO it's trivial, so I decide to report this bug along with a patch directly to the debian bug tracking system, but also hopes for your advises and reviews!

Thank you!

---

hahawang


--- a/lib/pty.c
+++ b/lib/pty.c
@@ -60,7 +60,7 @@

 #elif HAVE_GRANTPT

-#if !(defined(__FreeBSD__) || defined(__NetBSD__) || defined(__APPLE__) || defined(__linux__)) +#if !(defined(__FreeBSD__) || defined(__NetBSD__) || defined(__APPLE__) || defined(__linux__) || defined(__gnu_hurd__))
 #include <stropts.h>
 #endif

--- End Message ---
--- Begin Message ---
Source: gftp
Source-Version: 2.7.1~beta-1
Done: Andreas Rönnquist <[email protected]>

We believe that the bug you reported is fixed in the latest version of
gftp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Rönnquist <[email protected]> (supplier of updated gftp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 19 Oct 2021 23:11:11 +0200
Source: gftp
Architecture: source
Version: 2.7.1~beta-1
Distribution: unstable
Urgency: medium
Maintainer: Andreas Rönnquist <[email protected]>
Changed-By: Andreas Rönnquist <[email protected]>
Closes: 988280
Changes:
 gftp (2.7.1~beta-1) unstable; urgency=medium
 .
   * New upstream version 2.7.1~beta
     - Fixes FTBFS on Hurd missing stropts.h (Closes: #988280)
   * Remove patch fix_format_not_a_string_literal...
     - applied upstream
   * Upgrade to Standards Version 4.6.0.1
Checksums-Sha1:
 673cda1919def313a6076d8f47f25c6d5a0cddc4 2075 gftp_2.7.1~beta-1.dsc
 7066d2fc899e97c6be47091c2ecf4aa2dd2cc00f 892512 gftp_2.7.1~beta.orig.tar.xz
 9b92baf9a3abf0f785cbb36bd4f35d824081b786 10060 gftp_2.7.1~beta-1.debian.tar.xz
 1ca5766349d06d66159835d97d1f77b4dca524c2 12729 
gftp_2.7.1~beta-1_source.buildinfo
Checksums-Sha256:
 e97c8eb855086c3c2a264a133b2ba104039c6b778aadf4746bc511671eaabf7d 2075 
gftp_2.7.1~beta-1.dsc
 968cc26862627e5843c9896e460303397bbbab2f58b50fcdc1e7ef3d569bae53 892512 
gftp_2.7.1~beta.orig.tar.xz
 f56ecfa83433f7e8570a5207f590bcb59e6975d6117311818784ffcc90c259ec 10060 
gftp_2.7.1~beta-1.debian.tar.xz
 dbdb590a5c4211c828f7b704ff45995bbd3def22acd9ef56be219c5dbd1e2b9b 12729 
gftp_2.7.1~beta-1_source.buildinfo
Files:
 23cec074f85d6d064c96d059aaac7c09 2075 net optional gftp_2.7.1~beta-1.dsc
 03e7b033900deef371d540828de6f5c6 892512 net optional 
gftp_2.7.1~beta.orig.tar.xz
 6d168633c49e8607f1cab2b43548869a 10060 net optional 
gftp_2.7.1~beta-1.debian.tar.xz
 d3f68c3a89dc28a25ad27bc942c11b7c 12729 net optional 
gftp_2.7.1~beta-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEE2zBuSxD/2Y7021XXGUtjGrLaKIgFAmFvWD8RHGd1c25hbkBn
dXNuYW4uc2UACgkQGUtjGrLaKIh9VxAAlqeVO1tY83dPtLIkomw2S6xBkOnPf1AP
bBguxb5WQGHM9n2epEdfgrnY8JHFISyTNyiLh7X49O3HhSkSSrnptSaGgIOUTFtO
yPtHxf0AQngQ981q7eUrJ27tNnMNNPJJSdo9HQwfypg5I/4AOyWQvtmX5K16xcEn
7/VuDTwgo1gY+pn/2t+4WC1gBPu1IxDXx+bs9PLKllfbf0yUfALYeKtw4pXCoBGA
IeQ+rG/HJOrKLaWkzcmrBhWFAuRglo2rAhHgmMGyiXJKJjsQHaxhpgpc2C27iD1Q
q/5OKJ9FEEzPr59kPzKb9R9m5zeFn/xBoWBdlvx7dFuXnyUnV06D4FCJUhzy8OC0
/FQ2BpRFP607uS1tQ6bP08PBe5XCBgs/ArTHWR7ZrgdkRXq+fFYNgbniV4JqXYOF
X98skweX+A4Udl1yLIlIDOnUhs9/wR9Io5w0aBs0zTKJU7XMaM3OHnTaBHS1I5/z
JDYesw+b01pnMuJqTrxT3V7Qb21vrZYGb8CBki18zVK3BDgdGz0UTTQ+B+FeIZmR
BL5uBocRltfxnQwktNxnodD85LKo2JPuG3c0CXwuMRi6sSjs6tU9BnkPmRkBkXdE
Q1UhKb39noBJ8JFXWVWKVJ9U40vaqlktNkr9jXzvdGw3zf1X3A5uOi70JYuNAyWK
GTYwqnTdlEY=
=VWfc
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to