Your message dated Tue, 16 Nov 2021 18:36:05 +0000
with message-id <[email protected]>
and subject line Bug#998655: fixed in salt 3004+dfsg1-3
has caused the Debian Bug report #998655,
regarding salt-minion: network.managed state with bridge interfaces breaks 
ifupdown, thus breaking networking
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
998655: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=998655
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: salt-minion
Version: 3002.6+dfsg1-4
Severity: normal
Tags: patch upstream
X-Debbugs-Cc: [email protected]

Hi Debian salt maintainers,

when using salt to create network bridge interfaces, this broke my
complete network connectivity on the target machine. After some
digging around, I found an associated upstream bugreport also
containing a pull-request containing a patch, but I'd like to document
this in debian, hoping this might justify inclusion of the fix in the
next bullseye point release.

When adding interfaces with:

foo-state:
  network.managed:
    - type: bridge
    - ...

the resulting entry in /etc/network/interfaces will look like:
iface ext-txx inet manual
.
   bridge_ports eno1.10

With this dot making ifupdown refuse to start any network interfaces:
# ifup -a
ifup: /etc/network/interfaces:12: option with empty value
ifup: couldn't read interfaces file "/etc/network/interfaces"


Severity normal is somehow a "guess", it will trigger only in narrow
environments, but may disconnect a machine from the network completely
(because ifupdown refuses to work with a broken interfaces file), so
may need physical access to a machine to restore service.


upstream bugreport and pull-request can be found here:
https://github.com/saltstack/salt/issues/58195
https://github.com/saltstack/salt/pull/61095/

So the cause is a trailing dot in a jinja template file.


Thanks for having a look,
Yours
Matthias Merz


-- System Information:
Debian Release: 11.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-8-amd64 (SMP w/24 CPU threads)
Kernel taint flags: TAINT_FIRMWARE_WORKAROUND
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages salt-minion depends on:
ii  dctrl-tools           2.24-3+b1
ii  init-system-helpers   1.60
ii  lsb-base              11.1.0
ii  python3               3.9.2-3
ii  python3-pycryptodome  3.9.7+dfsg1-1+b2
ii  python3-systemd       234-3+b4
ii  python3-zmq           20.0.0-1+b1
ii  salt-common           3002.6+dfsg1-4

Versions of packages salt-minion recommends:
ii  debconf-utils  1.5.77
ii  dmidecode      3.3-2
ii  e2fsprogs      1.46.2-2
pn  sfdisk         <none>

Versions of packages salt-minion suggests:
pn  python3-augeas  <none>

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: salt
Source-Version: 3004+dfsg1-3
Done: Benjamin Drung <[email protected]>

We believe that the bug you reported is fixed in the latest version of
salt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Benjamin Drung <[email protected]> (supplier of updated salt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 16 Nov 2021 18:46:14 +0100
Source: salt
Built-For-Profiles: noudeb
Architecture: source
Version: 3004+dfsg1-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Salt Team <[email protected]>
Changed-By: Benjamin Drung <[email protected]>
Closes: 998655 999590
Changes:
 salt (3004+dfsg1-3) unstable; urgency=medium
 .
   * Wrap long lines in Python code and documentation
   * Do not require contextvars for Python >= 3.7 (Closes: #999590)
   * Remove faulty dot in network interfaces template to fix network.managed
     state with bridge interfaces to break networking (Closes: #998655)
   * salt-doc: Replace duplicate image by symlinks
Checksums-Sha1:
 e06ec58b13748bb610d9e0ed8d2fe2d04b9a0c35 4640 salt_3004+dfsg1-3.dsc
 579b8b1effd872d73593d95117a63d547c4db6b8 120080 salt_3004+dfsg1-3.debian.tar.xz
 f1b102aaa6705b3f266289dce7db3d6bb2645e5e 14663 
salt_3004+dfsg1-3_source.buildinfo
Checksums-Sha256:
 951b94c4c17864f81b9face8272fe873b783f32d40acbe40bf1e032acb25aff8 4640 
salt_3004+dfsg1-3.dsc
 4a024edea8a16395568a7fdbdeeacaf8fcf7091f0ed4af5ff23205fc9a9a14ee 120080 
salt_3004+dfsg1-3.debian.tar.xz
 bfd3bce2774c87cbcec7d12b7161a7e46c199e3bc159c282d500f55863162efc 14663 
salt_3004+dfsg1-3_source.buildinfo
Files:
 fff6e0d9cbffa7dcbcd31ccaf140f29d 4640 admin optional salt_3004+dfsg1-3.dsc
 8714f67dbfa3c8aabe1d1ca99775d828 120080 admin optional 
salt_3004+dfsg1-3.debian.tar.xz
 6eea235c998abcd2cbc720c293eb1635 14663 admin optional 
salt_3004+dfsg1-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE5/q3CzlQJ15towl13YzVpd6MfnoFAmGT9DQACgkQ3YzVpd6M
fnp6XxAAlMG9IwucJ6ipW/Zj1He8GCZLbH1tN9zFnVEODg7bOuD+0UDAID5sN5EO
Ot1ngSHEL42un+ydEHSEw0kRNlbCxxv1TfXAeQDylJtjQkPwX0zs8KLSdRe6ztvS
6jRCVlF1N7SkbfBv6f61gTYPNlVUZpHj1QfHrF3kLGF97hSlCB4S2MfZObxz/RlT
PPUaljMopBY+H9JC96310Zg5uLr1x0wbtoUU+0d4q5iQOMKbTkRSfHrU2178vuCW
RivCuQ1ASD8wpBVUiZGRiYLyq0iTHAsSQ5Are6hHdi0F0X7GUUgO7OwY9VkHbjPY
GjPuqbSmzx6E119Y1ArPXbFGuhETY+KY8qL0jjInpETJzDDdIhgaoemv1q2+8rcz
faPVLx1dTQKMoEKDHkqCf0R6Ec+WWIlweR0g28AFiT79vmKUqzyeTCVdXkFOPKdZ
YORXS1J14yzJKztfRZnNkHu48J7x5w/oFPm1A6tgEOigqNjxC5kMeEaxY4gRkOul
P1uN1HEtnKGVIyuw0/Lc3R5FN+40kCciUq+C6Db7U2uPhLAUYouOrJl5DSlXWcM0
Wy3v4MJG9tM9Vc7M4ghjWomgkVZG5IHUodfiicIx6/jyQLMtUmEPouXwMxpsuL2Y
bBm4LFgLp72pV30NdEUO+qcyj/YE+Jv4eYIlCcZ2teYAs6Om/D0=
=q1uY
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to