Your message dated Wed, 17 Nov 2021 13:30:32 +0100
with message-id
<ca+7wuszu3mhhbsqc7ee2sbv4ywn4q4fc6htfezvhwr3kbth...@mail.gmail.com>
and subject line dcmtk: wrongly assumes that CMAKE_SYSTEM_VERSION to be
non-empty
has caused the Debian Bug report #900196,
regarding dcmtk: wrongly assumes that CMAKE_SYSTEM_VERSION to be non-empty
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
900196: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900196
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: dcmtk
Version: 3.6.2-3
Severity: minor
Tags: patch upstream
User: [email protected]
Usertags: rebootstrap
While trying to make dcmtk cross buildable, I found a little bug in the
build system. It assumes that CMAKE_SYSTEM_VERSION is non-empty. This is
true most of the time, but CMakeDetermineSyste.cmake says:
# CMAKE_SYSTEM_VERSION - on unix this is uname -r, for windows it is empty
It also happens to break cross building as debhelper does not presently
pass this variable.
I think the best way out here would be to quote the variable to avoid
any issues. Please consider applying the attached patch.
Helmut
--- dcmtk-3.6.2.orig/CMake/dcmtkPrepare.cmake
+++ dcmtk-3.6.2/CMake/dcmtkPrepare.cmake
@@ -380,7 +380,7 @@
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -D_XOPEN_SOURCE_EXTENDED -D_XOPEN_SOURCE=500 -D_NETBSD_SOURCE -D_DEFAULT_SOURCE -D_BSD_COMPAT -D_OSF_SOURCE -D_POSIX_C_SOURCE=199506L")
SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -D_XOPEN_SOURCE_EXTENDED -D_XOPEN_SOURCE=500 -D_NETBSD_SOURCE -D_DEFAULT_SOURCE -D_BSD_COMPAT -D_OSF_SOURCE -D_POSIX_C_SOURCE=199506L")
# Solaris, FreeBSD and newer versions of OpenBSD fail with these flags
- ELSEIF(NOT ${CMAKE_SYSTEM_NAME} MATCHES "SunOS" AND NOT ${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD" AND (NOT ${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD" OR ${CMAKE_SYSTEM_VERSION} VERSION_LESS 4))
+ ELSEIF(NOT "${CMAKE_SYSTEM_NAME}" MATCHES "SunOS" AND NOT "${CMAKE_SYSTEM_NAME}" MATCHES "FreeBSD" AND (NOT "${CMAKE_SYSTEM_NAME}" MATCHES "OpenBSD" OR "${CMAKE_SYSTEM_VERSION}" VERSION_LESS 4))
# Compiler flags for all other non-Windows systems
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -D_XOPEN_SOURCE_EXTENDED -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_DEFAULT_SOURCE -D_BSD_COMPAT -D_OSF_SOURCE -D_POSIX_C_SOURCE=199506L")
SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -D_XOPEN_SOURCE_EXTENDED -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_DEFAULT_SOURCE -D_BSD_COMPAT -D_OSF_SOURCE -D_POSIX_C_SOURCE=199506L")
--- End Message ---
--- Begin Message ---
Control: fixed -1 3.6.4-2.1
According to upstream, this bug is solved:
% git show --oneline 3522835b65 | head -1
3522835b6 Fixed issue with undefined CMAKE_SYSTEM_VERSION.
% git tag --contains=3522835b65
DCMTK-3.6.4
DCMTK-3.6.5
DCMTK-3.6.5+_20191213
DCMTK-3.6.6
--- End Message ---
