Your message dated Wed, 19 Jan 2022 21:05:45 +0000
with message-id <[email protected]>
and subject line Bug#990222: fixed in crmsh 4.3.1-1
has caused the Debian Bug report #990222,
regarding crmsh: Bundled vim addons cannot be enabled.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
990222: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990222
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: crmsh
Version: 4.2.1-2
Severity: normal
Tags: patch
X-Debbugs-Cc: [email protected]

The vim syntax highlighting addon seems to be broken:

root@crmshtest:~# vim-addons status
# Name                     User Status  System Status
haproxy                     removed       installed
pcmk                        unavailable   unavailable


The attached patch fixes this.  Unfortunately it took me quite a while
to work out how to enable the syntax highlighting plugin in the first
place, so I wonder if it might be a good idea to either:

. break it out into a separate binary package, in the same way that e.g.
haproxy does ("vim-haproxy").

or:

. Include a README.Debian with something like the description from the
vim-haproxy package, stating that vim syntax highlighting is included in
the package, which will enable syntax highlighting of pacemaker
configuration files e.g. when using:

crm configure edit

but as-per debian policy it will need to be manually enabled
e.g. with:

vim-addons install --system-wide pcmk


Thanks!

Tim.
diff -Naur debian/rules ../../crmsh-4.2.1/debian/rules
--- debian/rules        2020-03-15 19:22:40.000000000 +0000
+++ ../../crmsh-4.2.1/debian/rules      2021-06-23 11:33:55.626799728 +0100
@@ -51,7 +51,7 @@
        install -m 644 -D contrib/bash_completion.sh 
debian/tmp/usr/share/bash-completion/completions/crm
 # install vim plugin
        install -m 644 -D debian/vim-pcmk.yaml 
debian/tmp/usr/share/vim/registry/vim-pcmk.yaml
-       install -m 644 -D contrib/pcmk-ftdetect.vim 
debian/tmp/usr/share/vim/addons/ftplugin/vim-pcmk.vim
+       install -m 644 -D contrib/pcmk-ftdetect.vim 
debian/tmp/usr/share/vim/addons/ftdetect/pcmk.vim
        install -m 644 -D contrib/pcmk.vim 
debian/tmp/usr/share/vim/addons/syntax/pcmk.vim
        rm -r debian/tmp/usr/share/doc/crmsh/contrib/
 
diff -Naur debian/vim-pcmk.yaml ../../crmsh-4.2.1/debian/vim-pcmk.yaml
--- debian/vim-pcmk.yaml        2020-03-15 19:22:40.000000000 +0000
+++ ../../crmsh-4.2.1/debian/vim-pcmk.yaml      2021-06-23 11:34:27.367392895 
+0100
@@ -1,5 +1,5 @@
 addon: pcmk
 description: "The Pacemaker crmsh plugin for Vim"
 files:
-  - ftplugin/pcmk-ftdetect.vim
+  - ftdetect/pcmk.vim
   - syntax/pcmk.vim

--- End Message ---
--- Begin Message ---
Source: crmsh
Source-Version: 4.3.1-1
Done: Valentin Vidic <[email protected]>

We believe that the bug you reported is fixed in the latest version of
crmsh, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Valentin Vidic <[email protected]> (supplier of updated crmsh package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 19 Jan 2022 21:13:36 +0100
Source: crmsh
Architecture: source
Version: 4.3.1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian HA Maintainers 
<[email protected]>
Changed-By: Valentin Vidic <[email protected]>
Closes: 990222 992708
Changes:
 crmsh (4.3.1-1) unstable; urgency=medium
 .
   [ Valentin Vidic ]
   * New upstream version 4.3.1 (Closes: #992708)
   * d/patches: refresh for new version
   * d/tests: update for new version
   * d/control: update Standards-Version
   * d/copyright: update year
   * d/watch: update github url
   * d/rules: fix installation of vim syntax plugin (Closes: #990222)
 .
   [ Athos Ribeiro ]
   * d/t/testsuite.sh: set timezone for time conversion tests
   * d/p/0017-Fix-health-scripts-python-38-support.patch: remove deprecated
     function usage
   * d/p/0018-Replace-crmd.patch: replace crmd calls with pacemaker-controld
   * d/p/0019-Add-hb_report-dpkg-support.patch: Add dpkg support to hb_report
Checksums-Sha1:
 a9b4a8e1fc8425592bfce94b00d4299832ebf237 2272 crmsh_4.3.1-1.dsc
 ca63c8a204dc19bff892799a977c2adfeb3f05f8 1108680 crmsh_4.3.1.orig.tar.gz
 52e35f21ab0bdf90b26bb7a73466715a1655d513 29780 crmsh_4.3.1-1.debian.tar.xz
 9201bc1f6229c0413dc500182e449ebf7552dfc8 6724 crmsh_4.3.1-1_source.buildinfo
Checksums-Sha256:
 5099b1f5b60b7c9b199752a382efc2927f48d1ed1fd936c11aa7f52559ef7706 2272 
crmsh_4.3.1-1.dsc
 34244aeea8c4649c84a4107b8ea47e60d2b4ecf48727f03293f6984e90437cb3 1108680 
crmsh_4.3.1.orig.tar.gz
 7033941f600d2244cd048a7b353f217049863b5f3098d665acb4bbe3ad904559 29780 
crmsh_4.3.1-1.debian.tar.xz
 ea06f7a0be50ba10dc03b53d83d0aaac99ea11fa4a939c97eb9b4149a43f7658 6724 
crmsh_4.3.1-1_source.buildinfo
Files:
 fa6e64038d12dc6151707216e018da4d 2272 admin optional crmsh_4.3.1-1.dsc
 d38b2508ba0039ae63683b903b98d03b 1108680 admin optional crmsh_4.3.1.orig.tar.gz
 3a5d59e7252d50de2c94510ec422de54 29780 admin optional 
crmsh_4.3.1-1.debian.tar.xz
 5a57d1dc3a149cf8f636c3e1a71ed156 6724 admin optional 
crmsh_4.3.1-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEExaW53cM9k/u2PWfIMofYmpfNqHsFAmHoensSHHZ2aWRpY0Bk
ZWJpYW4ub3JnAAoJEDKH2JqXzah7vlAP/0KfmoryTzUNDJf23SGLigAYeJIJ9awQ
fZSaCLIbnn03txQoS4nGmQyc5ToHnjMhojMy5JAghxJ79ANKDeolbSXBZTQanbvw
nywrk0qGaL2cFkOOaWa4LQ709MhkXzcqMPGKw2PFePxeboMtGjs9I9+m3ihsiByX
AOUD2FjsWN4TiLDizjRit8nHPFev0aOFDnUOqmbTZNUatHT46JmqytAeblOtyyfl
q8p+UP/G16Li/kZ+p/MZqWNpoGT8sLzL3hovLzFyVpZ4Y+luZrhAEhrCr6in+uHp
Z1c8z87SEFj38EuwQFCOjPBwQME3dCf+qxW62HnCm5phyZTZcV2Rtf4JAF41bek9
koqFJNdpMVZTomEkE1moxADzw4rV9J0hWWD7Yvbv5M3h0nNbwsvoeE0viWOs9Opm
b8/vGv0krOKAJojKrDicauCvEFbERETcl05ck1hUDzpMAKLvT6pOrTEOciL+zb0B
0huhTyx/uEfBQfDkRMFef6tk5723iTXNhe5Viga5+KRR7ipMZBnEmwdh5z34hgcA
0Xhuh7eDOQb1UqbbhkpWAbdHKKoarGvursva8P8h4FUNEn/jC/6fl1G4D7mJRYxz
eGKBs28j8u8b801Ce/KAlFxGihVETegD44gRANSjf7MFbFiXkNciq5yquM/qrBjQ
BhE6Nbj0lypH
=7Xt3
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to