Your message dated Tue, 31 May 2022 20:41:28 +0000
with message-id <[email protected]>
and subject line Bug#1011340: fixed in wireplumber 0.4.10-2
has caused the Debian Bug report #1011340,
regarding Does not include an autopkgtest and missing depends
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1011340: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011340
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: wireplumber
Version: 0.4.10-1
It would be nicer if the package had autopkgtests testing. The attached
patch is adding a trivial build test on the model of the ones used for
most GNOME libraries, it ensure that a simple case builds and that the
dev isn't missing any depends.
We are using that change in Ubuntu now as having tests is a requirement
to promote packages and we plan to preinstall wireplumber as part of the
switch to pipewire.
The missing depends have been caught by the test failing on our first
upload ;-)
Thanks for considering
diff -Nru wireplumber-0.4.10/debian/changelog wireplumber-0.4.10/debian/changelog
--- wireplumber-0.4.10/debian/changelog 2022-05-11 14:01:51.000000000 +0200
+++ wireplumber-0.4.10/debian/changelog 2022-05-19 15:26:07.000000000 +0200
@@ -1,3 +1,13 @@
+wireplumber (0.4.10-2) UNRELEASED; urgency=medium
+
+ * debian/tests:
+ - add a basic build autopkgtest for the library
+ * debian/control:
+ - libwireplumber-0.4-dev depends on libglib2.0-dev and libglib2.0-dev,
+ those are required by the .pc
+
+ -- Sebastien Bacher <[email protected]> Thu, 19 May 2022 15:26:07 +0200
+
wireplumber (0.4.10-1) unstable; urgency=medium
* Team upload.
diff -Nru wireplumber-0.4.10/debian/control wireplumber-0.4.10/debian/control
--- wireplumber-0.4.10/debian/control 2022-05-11 14:01:51.000000000 +0200
+++ wireplumber-0.4.10/debian/control 2022-05-19 15:26:07.000000000 +0200
@@ -43,6 +43,8 @@
Architecture: linux-any
Multi-Arch: same
Depends: ${misc:Depends},
+ libglib2.0-dev,
+ libpipewire-0.3-dev,
libwireplumber-0.4-0 (= ${binary:Version}),
gir1.2-wp-0.4 (= ${binary:Version}),
Description: Development files for WirePlumber
diff -Nru wireplumber-0.4.10/debian/tests/build wireplumber-0.4.10/debian/tests/build
--- wireplumber-0.4.10/debian/tests/build 1970-01-01 01:00:00.000000000 +0100
+++ wireplumber-0.4.10/debian/tests/build 2022-05-19 15:26:07.000000000 +0200
@@ -0,0 +1,30 @@
+#!/bin/sh
+# autopkgtest check: Build and run a program against libwireplumber, to verify that
+# the headers and pkg-config file are installed correctly
+
+set -e
+
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+ CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+ CROSS_COMPILE=
+fi
+
+cat <<EOF > libwireplumber_test.c
+#include <wp/wp.h>
+
+int main(void)
+{
+ wp_init (WP_INIT_ALL);
+ return 0;
+}
+EOF
+
+# deliberately word-splitting pkg-config output:
+# shellcheck disable=SC2046
+"${CROSS_COMPILE}gcc" -o libwireplumber_test libwireplumber_test.c \
+$("${CROSS_COMPILE}pkg-config" --cflags --libs wireplumber-0.4)
+echo "build: OK"
+[ -x libwireplumber_test ]
+./libwireplumber_test
+echo "run: OK"
diff -Nru wireplumber-0.4.10/debian/tests/control wireplumber-0.4.10/debian/tests/control
--- wireplumber-0.4.10/debian/tests/control 1970-01-01 01:00:00.000000000 +0100
+++ wireplumber-0.4.10/debian/tests/control 2022-05-19 14:05:24.000000000 +0200
@@ -0,0 +1,3 @@
+Tests: build
+Depends: build-essential, pkg-config, libwireplumber-0.4-dev
+Restrictions: allow-stderr superficial
--- End Message ---
--- Begin Message ---
Source: wireplumber
Source-Version: 0.4.10-2
Done: Dylan Aïssi <[email protected]>
We believe that the bug you reported is fixed in the latest version of
wireplumber, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Dylan Aïssi <[email protected]> (supplier of updated wireplumber package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 31 May 2022 22:14:51 +0200
Source: wireplumber
Architecture: source
Version: 0.4.10-2
Distribution: unstable
Urgency: medium
Maintainer: Utopia Maintenance Team
<[email protected]>
Changed-By: Dylan Aïssi <[email protected]>
Closes: 1011340
Changes:
wireplumber (0.4.10-2) unstable; urgency=medium
.
[ Debian Janitor ]
* Avoid explicitly specifying -Wl,--as-needed linker flag.
.
[ Sebastien Bacher ]
* debian/tests:
- add a basic build autopkgtest for the library
* debian/control:
- libwireplumber-0.4-dev depends on libglib2.0-dev and libpipewire-0.3-dev,
those are required by the .pc
(Closes: #1011340)
.
[ Dylan Aïssi ]
* Add Conflicts and Replaces for pipewire-media-session
* Add Suggests for libspa-0.2-bluetooth
* Add myself in Uploaders
* Remove useless .dirs files
* Standards-Version: 4.6.1 (no changes needed)
Checksums-Sha1:
350919661520653ba3ea1810aeb2bc7e86384330 2614 wireplumber_0.4.10-2.dsc
75e42f344b9d8b3cedffcac3f7d0f77e8939e708 7252
wireplumber_0.4.10-2.debian.tar.xz
7fa0a96cb8b048f439b64060cd7ac9fbc6bb8481 11135
wireplumber_0.4.10-2_amd64.buildinfo
Checksums-Sha256:
68aed4eaa5d89bfae1cd8bfa7616e00d0b28a665d1e177641e61655f6711f010 2614
wireplumber_0.4.10-2.dsc
e04e41429fab15e15d9c5a13b8c49c3a5a6ab1cd264b0475b28a2b76821cbaba 7252
wireplumber_0.4.10-2.debian.tar.xz
92f3f4cd63a973f260f76c2b0337c0c25b8beb785278557c422f1ef76550adcc 11135
wireplumber_0.4.10-2_amd64.buildinfo
Files:
5e08b32fc99ba7e80329c6cba405a7c0 2614 libs optional wireplumber_0.4.10-2.dsc
fec6a4f5f127bbf8e96e630eb4f9755a 7252 libs optional
wireplumber_0.4.10-2.debian.tar.xz
65beba6ee28a83a084f5c3b936b3e408 11135 libs optional
wireplumber_0.4.10-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEmjwHvQbeL0FugTpdYS7xYT4FD1QFAmKWeJAACgkQYS7xYT4F
D1QFnBAAouwcvF8zQ9T0dQ+aasA3uP76AxwVjBs+DW2lIKDT0Vd5YlZT4bmfW3Lc
qYKOYZ9HKw7wyW9zWMYDdNY1t/IUExCdBEijjwSz/hmX9EuBpFX9jIXCZpAAJdDc
mmI4Lu8GFSQh4uKG6skdQpGsYxUOJSyfxKaHd00UU2ArgdMiVdlTgrp7U9e9dB0/
WB3C9N5oiPQgn2AwuTpIsktdqXkmMS7NWOWyrKGJAp+HiUBSV+eMt+0y1jQERM69
WR9E8d9acmogTcU669irYLhtGpNYxW9wFRII/ENjVHXGZTXd+5T8PbuAgtTtIOis
vOlJmt/2Ufkg7bWAmR1A8XuXn5UlRCoNLViGR/yPnIkJ4gWkvsTdUnBxo6QjJRJv
rrtrdC7EKp5Jlq1VwkgXTRqIE4TxmAo/Ee09yOQA+r4WxiaNynXhG7S0k64pflf2
bviojls6hQo0sXk29MFxowBeCb8hwi9UW5uBS2OutYOg5i6GjHWudabMK3//d97R
YvcfF9nV77ADnXBFXs9ojGdIY3jBUFVBvvp5Puvx/xkiW00cHUvPUMZirKMgXRTL
dz+D1tSGsfyqimpMblg8Mm9w814kYoj1631tXaqhdDcjY1rPWUYw4BTRwdoDXB4t
OZ5YvD+n7HF0vrmaA8f9l/hTml59UvyuYguQoN0Qg/rwy9K0TOk=
=xZRd
-----END PGP SIGNATURE-----
--- End Message ---
