Your message dated Wed, 20 Jul 2022 17:01:17 +0200
with message-id <[email protected]>
and subject line Re: keepassx: please use source mtime as creation date when
generating icons
has caused the Debian Bug report #763699,
regarding keepassx: please use source mtime as creation date when generating
icons
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
763699: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=763699
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: keepassx
Version: 0.4.3+dfsg-0.1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: timestamps
Hi!
As part of the “reproducible builds” project [1], we have detected that
keepassx embeds the current date and time when it generates the software
icon in multiple sizes.
This prevents keepassx build from being reproducible:
https://jenkins.debian.net//userContent/diffp/keepassx_0.4.3+dfsg-0.1.diffp.html
The attached patch will set the `date:create` and `date:modify` fields
according to the mtime of the source files. keepassx then builds
reproducibly.
[1]: https://wiki.debian.org/ReproducibleBuilds
--
Lunar .''`.
[email protected] : :Ⓐ : # apt-get install anarchism
`. `'`
`-
diff -Nru keepassx-0.4.3+dfsg/debian/changelog keepassx-0.4.3+dfsg/debian/changelog
--- keepassx-0.4.3+dfsg/debian/changelog 2013-03-20 17:03:52.000000000 +0000
+++ keepassx-0.4.3+dfsg/debian/changelog 2014-10-01 21:55:54.000000000 +0000
@@ -1,3 +1,11 @@
+keepassx (0.4.3+dfsg-0.2~reproducible1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Use source file mtime as creation and modfication time while converting
+ icons for build reproducibility.
+
+ -- Jérémy Bobbio <[email protected]> Wed, 01 Oct 2014 21:54:51 +0000
+
keepassx (0.4.3+dfsg-0.1) unstable; urgency=high
* Non-maintainer upload.
diff -Nru keepassx-0.4.3+dfsg/debian/rules keepassx-0.4.3+dfsg/debian/rules
--- keepassx-0.4.3+dfsg/debian/rules 2012-04-07 16:14:51.000000000 +0000
+++ keepassx-0.4.3+dfsg/debian/rules 2014-10-01 21:54:44.000000000 +0000
@@ -4,6 +4,11 @@
%:
dh $@ --parallel --buildsystem=qmake_qt4
+MEDIUM_ICON = share/keepassx/icons/keepassx.png
+MEDIUM_ICON_DATE = $(shell date '+%Y-%m-%dT%H:%M:%S%:z' --reference='$(MEDIUM_ICON)')
+LARGE_ICON = debian/keepassx.svg
+LARGE_ICON_DATE = $(shell date '+%Y-%m-%dT%H:%M:%S%:z' --reference='$(LARGE_ICON)')
+
override_dh_auto_install:
dh_auto_install
@@ -17,15 +22,27 @@
cp share/keepassx/icons/keepassx_small.png \
debian/keepassx/usr/share/icons/hicolor/16x16/apps/keepassx.png
- convert share/keepassx/icons/keepassx.png -resize 24x24 \
+ convert -resize 24x24 \
+ -set date:create $(MEDIUM_ICON_DATE) \
+ -set date:modify $(MEDIUM_ICON_DATE) \
+ $(MEDIUM_ICON) \
debian/keepassx/usr/share/icons/hicolor/24x24/apps/keepassx.png
cp share/keepassx/icons/keepassx.png \
debian/keepassx/usr/share/icons/hicolor/32x32/apps/keepassx.png
- convert -density 72 -background none debian/keepassx.svg \
+ convert -density 72 -background none \
+ -set date:create $(LARGE_ICON_DATE) \
+ -set date:modify $(LARGE_ICON_DATE) \
+ $(LARGE_ICON) \
debian/keepassx/usr/share/icons/hicolor/48x48/apps/keepassx.png
- convert -density 96 -background none debian/keepassx.svg \
+ convert -density 96 -background none \
+ -set date:create $(LARGE_ICON_DATE) \
+ -set date:modify $(LARGE_ICON_DATE) \
+ $(LARGE_ICON) \
debian/keepassx/usr/share/icons/hicolor/64x64/apps/keepassx.png
- convert -density 192 -background none debian/keepassx.svg \
+ convert -density 192 -background none \
+ -set date:create $(LARGE_ICON_DATE) \
+ -set date:modify $(LARGE_ICON_DATE) \
+ $(LARGE_ICON) \
debian/keepassx/usr/share/icons/hicolor/128x128/apps/keepassx.png
cp debian/keepassx.svg \
debian/keepassx/usr/share/icons/hicolor/scalable/apps/keepassx.svg
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Version: 2.0.3-1
Hi,
keepassx builds reproducible since version 2.0.3-1 (and even before, I
think), let's close this bug now.
Cheers,
Philip
OpenPGP_signature
Description: OpenPGP digital signature
--- End Message ---
