Your message dated Sat, 13 Aug 2022 06:59:39 +0000
with message-id <[email protected]>
and subject line Bug#575848: Removed package(s) from unstable
has caused the Debian Bug report #247437,
regarding dh-kpatches: Lack of exit message w/ no IDX leaves user guessing
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
247437: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=247437
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dh-kpatches
Version: 0.99.10
Severity: normal

When attempting to apply a couple of patches that modify the top level Makefile's EXTRAVERSION value, kernel-patch scripts in Debian 3.0 made with dh-kpatches exit returning 0 and don't give an error message. This makes the make-kpkg program think that every thing's OK. Running the scripts by hand is even more puzzling because nothing seems to happen.

In my case the lsm and xfs patches appear to add -lsm and -xfs respectively to the EXTRAVERSION value. This may be SOP documented somewhere for keeping conflicting patches from applying auto magically, but it even keeps the debianlogo patch from applying unless it is applied first in the list and there isn't a message as to why it failed. make-kpkg makes it seem that it actually worked when it didn't (not make-kpkg's fault). It seems that the IDX seeking loop finds no patch matching for example 2.4.17-lsm and the program exits success (0) at the last line.

An else condition for if [ "$IDX" ] that gave an error message and exited with a failure would help.

Pseudo-patch:
----
    else
        echo >&2 ""<patchname>" patch for $KVERSION does not apply cleanly"
    fi
+else
+    echo >&2 "Unable to find a patch matching $KERNELRELEASE"
+    echo >&2 "Try setting KPATCH_<patchid> to the target patch version"
+    if [ -n "$EXTRAVERSION" ]
+    then
+ echo >&2 "or applying patches that set $EXTRAVERSION after this patch"
+    fi
+    exit 1
fi

###

exit 0
----

Example of trying to apply patches with make-kpkg:
----
$ fakeroot make-kpkg --added-patches=lsm,debianlogo,xfs debian
...
Testing whether LSM Support for Linux patch for 2.4.17 applies (dry run):
LSM Support for Linux patch for 2.4.17 succeeded
Removing empty files after patching:
Done.
Patch /usr/src/kernel-patches/all//apply/lsm processed fine
Patch /usr/src/kernel-patches/all//apply/debianlogo processed fine
Patch /usr/src/kernel-patches/all//apply/xfs processed fine
touch stamp-patch
...
----

I see that you've completely changed the code for this program in recent versions, but hopefully this bug will leave a trace for others using patches made with this package in 3.0/Woody.

Thanks for all your work. :)

-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux onyx 2.4.18-1-k6 #1 Wed Apr 14 19:00:29 UTC 2004 i586
Locale: LANG=C, LC_CTYPE=C

Versions of packages dh-kpatches depends on:
ii debhelper 4.0.2 helper programs for debian/rules ii perl 5.6.1-8.7 Larry Wall's Practical Extraction

Versions of patches:
kernel-patch-2.4-lsm             2002.03.14-1 Linux Security Modules patch
kernel-patch-xfs                 1.0.2+20020304-2 SGI Journaling FS
kernel-patch-debianlogo          1.0-2 Swirl logo

--
Jacob Anawalt


--- End Message ---
--- Begin Message ---
Version: 0.99.36+nmu4+rm

Dear submitter,

as the package dh-kpatches has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/575848

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
[email protected].

Debian distribution maintenance software
pp.
Thorsten Alteholz (the ftpmaster behind the curtain)

--- End Message ---

Reply via email to